Sync analysis options (#29)

analysis_options.yaml

@@ -14,8 +14,6 @@
 # kept in sync with it.
 
 analyzer:
-  language:
-    enableSuperMixins: true
   strong-mode:
     implicit-dynamic: false
   errors:
@@ -41,14 +39,15 @@ linter:
     - annotate_overrides
     # - avoid_annotating_with_dynamic # conflicts with always_specify_types
     - avoid_as
-    # - avoid_bool_literals_in_conditional_expressions # not yet tested
+    - avoid_bool_literals_in_conditional_expressions
     # - avoid_catches_without_on_clauses # we do this commonly
     # - avoid_catching_errors # we do this commonly
     - avoid_classes_with_only_static_members
     # - avoid_double_and_int_checks # only useful when targeting JS runtime
     - avoid_empty_else
-    # - avoid_field_initializers_in_const_classes # not yet tested
+    - avoid_field_initializers_in_const_classes
     - avoid_function_literals_in_foreach_calls
+    # - avoid_implementing_value_types # not yet tested
     - avoid_init_to_null
     # - avoid_js_rounded_ints # only useful when targeting JS runtime
     - avoid_null_checks_in_equality_operators
@@ -57,38 +56,48 @@ linter:
     - avoid_relative_lib_imports
     - avoid_renaming_method_parameters
     - avoid_return_types_on_setters
-    # - avoid_returning_null # we do this commonly
+    # - avoid_returning_null # there are plenty of valid reasons to return null
-    # - avoid_returning_this # https://github.com/dart-lang/linter/issues/842
+    # - avoid_returning_null_for_future # not yet tested
+    - avoid_returning_null_for_void
+    # - avoid_returning_this # there are plenty of valid reasons to return this
     # - avoid_setters_without_getters # not yet tested
+    # - avoid_shadowing_type_parameters # not yet tested
     # - avoid_single_cascade_in_expression_statements # not yet tested
     - avoid_slow_async_io
-    # - avoid_types_as_parameter_names # https://github.com/dart-lang/linter/pull/954/files
+    - avoid_types_as_parameter_names
     # - avoid_types_on_closure_parameters # conflicts with always_specify_types
-    # - avoid_unused_constructor_parameters # https://github.com/dart-lang/linter/pull/847
+    - avoid_unused_constructor_parameters
+    - avoid_void_async
     - await_only_futures
     - camel_case_types
     - cancel_subscriptions
     # - cascade_invocations # not yet tested
-    # - close_sinks # https://github.com/flutter/flutter/issues/5789
+    # - close_sinks # not reliable enough
-    # - comment_references # blocked on https://github.com/dart-lang/dartdoc/issues/1153
+    # - comment_references # blocked on https://github.com/flutter/flutter/issues/20765
-    # - constant_identifier_names # https://github.com/dart-lang/linter/issues/204
+    # - constant_identifier_names # needs an opt-out https://github.com/dart-lang/linter/issues/204
     - control_flow_in_finally
+    # - curly_braces_in_flow_control_structures # not yet tested
+    # - diagnostic_describe_all_properties # not yet tested
     - directives_ordering
     - empty_catches
     - empty_constructor_bodies
     - empty_statements
+    # - file_names # not yet tested
+    - flutter_style_todos
     - hash_and_equals
     - implementation_imports
-    # - invariant_booleans # https://github.com/flutter/flutter/issues/5790
+    # - invariant_booleans # too many false positives: https://github.com/dart-lang/linter/issues/811
     - iterable_contains_unrelated_type
     # - join_return_with_assignment # not yet tested
     - library_names
     - library_prefixes
+    # - lines_longer_than_80_chars # not yet tested
     - list_remove_unrelated_type
-    # - literal_only_boolean_expressions # https://github.com/flutter/flutter/issues/5791
+    # - literal_only_boolean_expressions # too many false positives: https://github.com/dart-lang/sdk/issues/34181
     - no_adjacent_strings_in_list
     - no_duplicate_case_values
     - non_constant_identifier_names
+    # - null_closures  # not yet tested
     # - omit_local_variable_types # opposite of always_specify_types
     # - one_member_abstracts # too many false positives
     # - only_throw_errors # https://github.com/flutter/flutter/issues/5792
@@ -99,7 +108,7 @@ linter:
     # - parameter_assignments # we do this commonly
     - prefer_adjacent_string_concatenation
     - prefer_asserts_in_initializer_lists
-    - prefer_bool_in_asserts
+    # - prefer_asserts_with_message # not yet tested
     - prefer_collection_literals
     - prefer_conditional_assignment
     - prefer_const_constructors
@@ -108,46 +117,63 @@ linter:
     - prefer_const_literals_to_create_immutables
     # - prefer_constructors_over_static_methods # not yet tested
     - prefer_contains
+    # - prefer_double_quotes # opposite of prefer_single_quotes
     - prefer_equal_for_default_values
     # - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#consider-using--for-short-functions-and-methods
     - prefer_final_fields
+    # - prefer_final_in_for_each # not yet tested
     - prefer_final_locals
+    # - prefer_for_elements_to_map_fromIterable # not yet tested
     - prefer_foreach
     # - prefer_function_declarations_over_variables # not yet tested
     - prefer_generic_function_type_aliases
+    # - prefer_if_elements_to_conditional_expressions # not yet tested
+    - prefer_if_null_operators
     - prefer_initializing_formals
+    - prefer_inlined_adds
+    # - prefer_int_literals # not yet tested
     # - prefer_interpolation_to_compose_strings # not yet tested
-    # - prefer_iterable_whereType # https://github.com/dart-lang/sdk/issues/32463
     - prefer_is_empty
     - prefer_is_not_empty
+    - prefer_iterable_whereType
+    # - prefer_mixin # https://github.com/dart-lang/language/issues/32
+    # - prefer_null_aware_operators # disable until NNBD, see https://github.com/flutter/flutter/pull/32711#issuecomment-492930932
     - prefer_single_quotes
+    - prefer_spread_collections
     - prefer_typing_uninitialized_variables
-    - public_member_api_docs
+    - prefer_void_to_null
+    # - provide_deprecation_message # not yet tested
+    # - public_member_api_docs # enabled on a case-by-case basis; see e.g. packages/analysis_options.yaml
     - recursive_getters
     - slash_for_doc_comments
+    # - sort_child_properties_last # not yet tested
     - sort_constructors_first
+    - sort_pub_dependencies
     - sort_unnamed_constructors_first
-    - super_goes_last
     - test_types_in_equals
     - throw_in_finally
     # - type_annotate_public_apis # subset of always_specify_types
     - type_init_formals
-    # - unawaited_futures # https://github.com/flutter/flutter/issues/5793
+    # - unawaited_futures # too many false positives
+    # - unnecessary_await_in_return # not yet tested
     - unnecessary_brace_in_string_interps
     - unnecessary_const
     - unnecessary_getters_setters
-    # - unnecessary_lambdas # https://github.com/dart-lang/linter/issues/498
+    # - unnecessary_lambdas # has false positives: https://github.com/dart-lang/linter/issues/498
     - unnecessary_new
     - unnecessary_null_aware_assignments
     - unnecessary_null_in_if_null_operators
     - unnecessary_overrides
     - unnecessary_parenthesis
-    # - unnecessary_statements # not yet tested
+    - unnecessary_statements
     - unnecessary_this
     - unrelated_type_equality_checks
+    # - unsafe_html # not yet tested
+    - use_full_hex_values_for_flutter_colors
+    # - use_function_type_syntax_for_parameters # not yet tested
     - use_rethrow_when_possible
     # - use_setters_to_change_properties # not yet tested
-    # - use_string_buffers # https://github.com/dart-lang/linter/pull/664
+    # - use_string_buffers # has false positives: https://github.com/dart-lang/sdk/issues/34182
     # - use_to_and_as_if_applicable # has false positives, so we prefer to catch this by code-review
     - valid_regexps
     # - void_checks # not yet tested

packages/multicast_dns/example/main.dart

@@ -7,7 +7,7 @@
 
 import 'package:multicast_dns/multicast_dns.dart';
 
-void main() async {
+Future<void> main() async {
   // Parse the command line arguments.
 
   const String name = '_dartobservatory._tcp.local';

packages/multicast_dns/example/mdns-resolve.dart

@@ -7,7 +7,7 @@
 
 import 'package:multicast_dns/multicast_dns.dart';
 
-void main(List<String> args) async {
+Future<void> main(List<String> args) async {
   if (args.length != 1) {
     print('''
 Please provide an address as argument.

packages/multicast_dns/example/mdns-sd.dart

@@ -7,7 +7,7 @@
 
 import 'package:multicast_dns/multicast_dns.dart';
 
-void main(List<String> args) async {
+Future<void> main(List<String> args) async {
   if (args.isEmpty) {
     print('''
 Please provide the name of a service as argument.

packages/multicast_dns/lib/src/packet.dart

@@ -274,7 +274,7 @@ List<ResourceRecord> decodeMDnsResponse(List<int> packet) {
         final int stop = offset + readDataLength;
         addr.write(packetBytes.getUint8(offset));
         offset++;
-        for (offset; offset < stop; offset++) {
+        for (; offset < stop; offset++) {
           addr.write('.');
           addr.write(packetBytes.getUint8(offset));
         }
@@ -286,7 +286,7 @@ List<ResourceRecord> decodeMDnsResponse(List<int> packet) {
         final int stop = offset + readDataLength;
         addr.write(packetBytes.getUint16(offset).toRadixString(16));
         offset += 2;
-        for (offset; offset < stop; offset += 2) {
+        for (; offset < stop; offset += 2) {
           addr.write(':');
           addr.write(packetBytes.getUint16(offset).toRadixString(16));
         }

packages/palette_generator/example/lib/main.dart

@@ -117,7 +117,7 @@ class _ImageColorsState extends State<ImageColors> {
   }
 
   // Called when the drag ends. Sets the region, and updates the colors.
-  void _onPanEnd(DragEndDetails details) async {
+  Future<void> _onPanEnd(DragEndDetails details) async {
     Rect newRegion =
         (Offset.zero & imageKey.currentContext.size).intersect(dragRegion);
     if (newRegion.size.width < 4 && newRegion.size.width < 4) {

packages/palette_generator/test/palette_generator_test.dart

@@ -51,7 +51,7 @@ Future<ImageProvider> loadImage(String name) async {
   return FakeImageProvider(frameInfo.image);
 }
 
-void main() async {
+Future<void> main() async {
   // Load the images outside of the test zone so that IO doesn't get
   // complicated.
   final List<String> imageNames = <String>[

third_party/packages/bsdiff/example/main.dart

@@ -8,9 +8,9 @@ import 'dart:typed_data';
 
 import 'package:bsdiff/bsdiff.dart';
 
-void main() async {
+void main() {
-  final Uint8List originalData = Uint8List.fromList(List.generate(1000, (index) => index));
+  final Uint8List originalData = Uint8List.fromList(List<int>.generate(1000, (int index) => index));
-  final Uint8List modifiedData = Uint8List.fromList(List.generate(2000, (index) => 2 * index));
+  final Uint8List modifiedData = Uint8List.fromList(List<int>.generate(2000, (int index) => 2 * index));
 
   print('Original data size ${originalData.length} bytes');
   print('Modified data size ${modifiedData.length} bytes');