From e480bbd55a671cc2a1102acf59220a162115fee0 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Thu, 13 May 2021 17:01:49 -0500 Subject: [PATCH] ci: fix firebase functions workflow (#612) --- .github/workflows/firebase_functions.yaml | 2 +- .../workflows/firebase_functions_deploy.yaml | 22 ------------------- .../firebase_functions_deploy_production.yaml | 16 -------------- functions/.eslintrc.js | 2 +- 4 files changed, 2 insertions(+), 40 deletions(-) delete mode 100644 .github/workflows/firebase_functions_deploy.yaml delete mode 100644 .github/workflows/firebase_functions_deploy_production.yaml diff --git a/.github/workflows/firebase_functions.yaml b/.github/workflows/firebase_functions.yaml index dbafbf30..ace38bb9 100644 --- a/.github/workflows/firebase_functions.yaml +++ b/.github/workflows/firebase_functions.yaml @@ -1,4 +1,4 @@ -me: firebase_functions +name: firebase_functions on: pull_request: diff --git a/.github/workflows/firebase_functions_deploy.yaml b/.github/workflows/firebase_functions_deploy.yaml deleted file mode 100644 index 6d6b4420..00000000 --- a/.github/workflows/firebase_functions_deploy.yaml +++ /dev/null @@ -1,22 +0,0 @@ -name: firebase_functions_deploy - -on: - push: - branches: - - main - paths: - - functions/** - - .github/workflows/firebase_functions_deploy.yaml - -jobs: - deploy: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - id: Deploy - uses: google-github-actions/deploy-cloud-functions@main - with: - credentials: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_PHOTOBOOTH_DEV }} - name: shareImage - runtime: nodejs14 - project_id: io-photobooth-dev \ No newline at end of file diff --git a/.github/workflows/firebase_functions_deploy_production.yaml b/.github/workflows/firebase_functions_deploy_production.yaml deleted file mode 100644 index 7780c40e..00000000 --- a/.github/workflows/firebase_functions_deploy_production.yaml +++ /dev/null @@ -1,16 +0,0 @@ -name: firebase_functions_deploy_production - -on: workflow_dispatch - -jobs: - deploy: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - id: Deploy - uses: google-github-actions/deploy-cloud-functions@main - with: - credentials: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_KEY }} - name: shareImage - runtime: nodejs14 - project_id: io-photobooth-20667 \ No newline at end of file diff --git a/functions/.eslintrc.js b/functions/.eslintrc.js index 8c1160ff..a9c7693e 100644 --- a/functions/.eslintrc.js +++ b/functions/.eslintrc.js @@ -30,7 +30,7 @@ module.exports = { 'quotes': [ 'error', 'single' ], 'array-bracket-spacing': [ 'error', 'always' ], 'object-curly-spacing': [ 'error', 'always' ], - 'max-len': [ 'error', { code: 100, tabWidth: 2 } ], + 'max-len': [ 'error', { code: 130, tabWidth: 2 } ], 'indent': [ 'error', 2 ], 'no-unused-vars': [ 'warn' ], 'new-cap': [ 'warn' ],