mirror of
https://github.com/flame-engine/flame.git
synced 2025-10-29 16:05:47 +08:00
refactor: Add new lint rules (#2477)
This PR adds the following lint rules to our list: ``` always_put_required_named_parameters_first avoid_multiple_declarations_per_line avoid_positional_boolean_parameters avoid_returning_null_for_void avoid_returning_this avoid_unnecessary_containers enable_null_safety library_private_types_in_public_api no_leading_underscores_for_library_prefixes no_leading_underscores_for_local_identifiers prefer_null_aware_method_calls tighten_type_of_initializing_formals unnecessary_late use_setters_to_change_properties ``` And these rules were considered, and some changes were made according to them as a clean-up, but in many places they didn't make sense (`prefer_asserts_with_message` I would have included, but there were too many places that needed to be changes): ``` collection_methods_unrelated_type prefer_asserts_with_message avoid_renaming_method_parameters ```
This commit is contained in:
@ -536,6 +536,7 @@ class TrafficLightComponent extends Component {
|
||||
Colors.orange,
|
||||
Colors.red,
|
||||
];
|
||||
final Paint _paint = Paint();
|
||||
|
||||
@override
|
||||
void onMount() {
|
||||
@ -543,8 +544,8 @@ class TrafficLightComponent extends Component {
|
||||
}
|
||||
|
||||
@override
|
||||
void render(Canvas c) {
|
||||
c.drawRect(rect, Paint()..color = currentColor);
|
||||
void render(Canvas canvas) {
|
||||
canvas.drawRect(rect, _paint..color = currentColor);
|
||||
}
|
||||
|
||||
@override
|
||||
|
||||
Reference in New Issue
Block a user