refactor: Add new lint rules (#2477)

This PR adds the following lint rules to our list:

```
always_put_required_named_parameters_first
avoid_multiple_declarations_per_line
avoid_positional_boolean_parameters
avoid_returning_null_for_void
avoid_returning_this
avoid_unnecessary_containers
enable_null_safety
library_private_types_in_public_api
no_leading_underscores_for_library_prefixes
no_leading_underscores_for_local_identifiers
prefer_null_aware_method_calls
tighten_type_of_initializing_formals
unnecessary_late
use_setters_to_change_properties
```

And these rules were considered, and some changes were made according to
them as a clean-up, but in many places they didn't make sense
(`prefer_asserts_with_message` I would have included, but there were too
many places that needed to be changes):

```
collection_methods_unrelated_type
prefer_asserts_with_message
avoid_renaming_method_parameters
```
This commit is contained in:
Lukas Klingsbo
2023-04-13 21:42:00 +02:00
committed by GitHub
parent 78b585fe8e
commit dbda37b81a
150 changed files with 573 additions and 506 deletions

View File

@ -17,13 +17,13 @@ class DoubleTapCallbacksExample extends FlameGame with DoubleTapCallbacks {
}
@override
void onGameResize(Vector2 canvasSize) {
void onGameResize(Vector2 size) {
children
.query<DoubleTappableEmber>()
.forEach((element) => element.removeFromParent());
add(DoubleTappableEmber(position: canvasSize / 2));
add(DoubleTappableEmber(position: size / 2));
super.onGameResize(canvasSize);
super.onGameResize(size);
}
@override