flutter/flame
1
0
Fork 0
mirror of https://github.com/flame-engine/flame.git synced 2025-10-29 16:05:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Add new lint rules (#2477)

Browse Source 
This PR adds the following lint rules to our list:

```
always_put_required_named_parameters_first
avoid_multiple_declarations_per_line
avoid_positional_boolean_parameters
avoid_returning_null_for_void
avoid_returning_this
avoid_unnecessary_containers
enable_null_safety
library_private_types_in_public_api
no_leading_underscores_for_library_prefixes
no_leading_underscores_for_local_identifiers
prefer_null_aware_method_calls
tighten_type_of_initializing_formals
unnecessary_late
use_setters_to_change_properties
```

And these rules were considered, and some changes were made according to
them as a clean-up, but in many places they didn't make sense
(`prefer_asserts_with_message` I would have included, but there were too
many places that needed to be changes):

```
collection_methods_unrelated_type
prefer_asserts_with_message
avoid_renaming_method_parameters
```
This commit is contained in:
Lukas Klingsbo
2023-04-13 21:42:00 +02:00
committed by GitHub
parent 78b585fe8e
commit dbda37b81a
150 changed files with 573 additions and 506 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
examples/lib/stories/collision_detection/multiple_shapes_example.dart
View File

@ -74,7 +74,7 @@ class MultipleShapesExample extends FlameGame with HasCollisionDetection {
collidableSize,
velocity,
screenHitbox,
rng: _rng,
random: _rng,
);
}
}
@ -273,11 +273,11 @@ MyCollidable randomCollidable(
Vector2 size,
Vector2 velocity,
ScreenHitbox screenHitbox, {
Random? rng,
Random? random,
}) {
final _rng = rng ?? Random();
final rotationSpeed = 0.5 - _rng.nextDouble();
final shapeType = Shapes.values[_rng.nextInt(Shapes.values.length)];
final rng = random ?? Random();
final rotationSpeed = 0.5 - rng.nextDouble();
final shapeType = Shapes.values[rng.nextInt(Shapes.values.length)];
switch (shapeType) {
case Shapes.circle:
return CollidableCircle(position, size, velocity, screenHitbox)