Add @mustCallSuper to component.render (#1011)

* Add @mustCallSuper to component.render

* fixing lint

* lint

* fixing
This commit is contained in:
Erick
2021-10-10 20:37:30 -03:00
committed by GitHub
parent 06a229f8d4
commit a1a0862121
8 changed files with 6 additions and 7 deletions

View File

@ -561,6 +561,7 @@ class TrafficLightComponent extends Component {
@override @override
void render(Canvas c) { void render(Canvas c) {
super.render(c);
c.drawRect(rect, Paint()..color = currentColor); c.drawRect(rect, Paint()..color = currentColor);
} }

View File

@ -14,6 +14,7 @@ class RenderedTimeComponent extends TimerComponent {
@override @override
void render(Canvas canvas) { void render(Canvas canvas) {
super.render(canvas);
textPaint.render( textPaint.render(
canvas, canvas,
'Elapsed time: ${timer.current}', 'Elapsed time: ${timer.current}',

View File

@ -4,6 +4,7 @@
- `changePriority` no longer breaks game loop iteration - `changePriority` no longer breaks game loop iteration
- Move component mixin checks to their own files - Move component mixin checks to their own files
- Fix exception when game was rebuilt - Fix exception when game was rebuilt
- Add `@mustCallSuper` on `Component.render`
## [1.0.0-releasecandidate.15] ## [1.0.0-releasecandidate.15]
- Fix issue with `Draggable`s not being removed from `draggables` list - Fix issue with `Draggable`s not being removed from `draggables` list

View File

@ -131,6 +131,7 @@ class Component with Loadable {
children.forEach((c) => c.update(dt)); children.forEach((c) => c.update(dt));
} }
@mustCallSuper
void render(Canvas canvas) { void render(Canvas canvas) {
preRender(canvas); preRender(canvas);
} }

View File

@ -64,6 +64,7 @@ class FlameGame extends Component with Game {
@override @override
@mustCallSuper @mustCallSuper
void render(Canvas canvas) { void render(Canvas canvas) {
super.render(canvas);
_cameraWrapper.render(canvas); _cameraWrapper.render(canvas);
} }

View File

@ -78,9 +78,6 @@ class TimerComponent extends Component {
timer.update(dt); timer.update(dt);
} }
@override
void render(Canvas canvas) {}
@override @override
bool get shouldRemove => timer.finished; bool get shouldRemove => timer.finished;
} }

View File

@ -1,5 +1,4 @@
import 'dart:math'; import 'dart:math';
import 'dart:ui';
import 'package:flame/components.dart'; import 'package:flame/components.dart';
import 'package:flame/timer.dart'; import 'package:flame/timer.dart';
@ -29,7 +28,4 @@ class EnemyCreator extends Component with HasGameRef<SpaceShooterGame> {
super.update(dt); super.update(dt);
enemyCreator.update(dt); enemyCreator.update(dt);
} }
@override
void render(Canvas canvas) {}
} }

View File

@ -15,6 +15,7 @@ class TiledComponent extends Component {
@override @override
void render(Canvas canvas) { void render(Canvas canvas) {
super.render(canvas);
tileMap.render(canvas); tileMap.render(canvas);
} }