flutter/flame
1
0
Fork 0
mirror of https://github.com/flame-engine/flame.git synced 2025-11-13 19:30:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Component.loaded future sometimes failed to complete (#1593)

Browse Source
This commit is contained in:
Pasha Stetsenko
2022-05-01 08:04:22 -07:00
committed by GitHub
parent 6dd0a970e6
commit 89ee9b984b
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flame/lib/src/components/component.dart
View File

@@ -501,6 +501,7 @@ class Component {
final onLoadFuture = onLoad(); final onLoadFuture = onLoad();
if (onLoadFuture == null) { if (onLoadFuture == null) {
_state = LifecycleState.loaded; _state = LifecycleState.loaded;
_loadCompleter?.complete();
} else { } else {
return onLoadFuture.then((_) { return onLoadFuture.then((_) {
_state = LifecycleState.loaded; _state = LifecycleState.loaded;

11
packages/flame/test/components/component_lifecycle_test.dart
View File

@@ -117,6 +117,17 @@ void main() {
}, },
); );
testWithFlameGame(
'.loaded completes even if accessed before the component added to game',
(game) async {
final component = Component();
final loadedFuture = component.loaded;
game.add(component);
await game.ready();
expectLater(loadedFuture, completes);
},
);
// Obsolete scenario, when we used to have a separate "prepare" stage // Obsolete scenario, when we used to have a separate "prepare" stage
flameGame.test('parent prepares the component', (game) async { flameGame.test('parent prepares the component', (game) async {
final parent = _MyComponent('parent'); final parent = _MyComponent('parent');