flutter/flame
1
0
Fork 0
mirror of https://github.com/flame-engine/flame.git synced 2025-11-03 12:28:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

🏷 Backport some code improvements from the null-safety branch (#603)

Browse Source
This commit is contained in:
Serge Matveenko
2021-01-09 05:25:29 +03:00
committed by GitHub
parent 5b1988ca36
commit 16eaef3bb1
28 changed files with 168 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/effects/move_effect.dart
View File

@ -50,8 +50,8 @@ class MoveEffect extends SimplePositionComponentEffect {
);
@override
void initialize(_comp) {
super.initialize(_comp);
void initialize(component) {
super.initialize(component);
List<Vector2> _movePath;
_startPosition = component.position.clone();
// With relative here we mean that any vector in the list is relative
@ -96,7 +96,11 @@ class MoveEffect extends SimplePositionComponentEffect {
}
final double totalPathLength = isAlternating ? pathLength * 2 : pathLength;
speed ??= totalPathLength / duration;
// `duration` is not null when speed is null
duration ??= totalPathLength / speed;
// `speed` is always not null here already
peakTime = isAlternating ? duration / 2 : duration;
}