refactor: Fix lint issues across the codebase - Part 2 (#2677)

Fix a handful of lint issues across the codebase, identified using DCM.
Nothing controversial, I expect; slowly getting these out of the way so
we can focus on discussing bigger things.

examples/games/padracing/lib/padracing_game.dart

@@ -44,8 +44,8 @@ class PadRacingGame extends Forge2DGame with KeyboardEvents {
   @override
   Color backgroundColor() => Colors.black;
 
-  static Vector2 trackSize = Vector2.all(500);
+  static final Vector2 trackSize = Vector2.all(500);
-  static double playZoom = 8.0;
+  static const double playZoom = 8.0;
   static const int numberOfLaps = 3;
   late final World cameraWorld;
   late CameraComponent startCamera;

examples/games/padracing/lib/tire.dart

@@ -69,9 +69,10 @@ class Tire extends BodyComponent<PadRacingGame> {
 
   @override
   Body createBody() {
-    final jointAnchor = isFrontTire
+    final jointAnchor = Vector2(
-        ? Vector2(isLeftTire ? -3.0 : 3.0, 3.5)
+      isLeftTire ? -3.0 : 3.0,
-        : Vector2(isLeftTire ? -3.0 : 3.0, -4.25);
+      isFrontTire ? 3.5 : -4.25,
+    );
 
     final def = BodyDef()
       ..type = BodyType.dynamic

examples/games/rogue_shooter/lib/components/enemy_component.dart

@@ -6,7 +6,7 @@ import 'package:rogue_shooter/rogue_shooter_game.dart';
 class EnemyComponent extends SpriteAnimationComponent
     with HasGameRef<RogueShooterGame>, CollisionCallbacks {
   static const speed = 150;
-  static Vector2 initialSize = Vector2.all(25);
+  static final Vector2 initialSize = Vector2.all(25);
 
   EnemyComponent({required super.position})
       : super(size: initialSize, anchor: Anchor.center);

examples/games/trex/lib/background/cloud.dart

@@ -15,7 +15,7 @@ class Cloud extends SpriteComponent
           size: initialSize,
         );
 
-  static Vector2 initialSize = Vector2(92.0, 28.0);
+  static final Vector2 initialSize = Vector2(92.0, 28.0);
 
   static const double maxCloudGap = 400.0;
   static const double minCloudGap = 100.0;

examples/games/trex/lib/random_extension.dart

@@ -1,6 +1,6 @@
 import 'dart:math';
 
-Random random = Random();
+final random = Random();
 
 extension RandomExtension on Random {
   double fromRange(double min, double max) =>

examples/lib/stories/bridge_libraries/audio/basic_audio_example.dart

@@ -17,9 +17,9 @@ class BasicAudioExample extends FlameGame with TapDetector {
     3. Uses the Bgm utility for background music.
   ''';
 
-  static Paint black = BasicPalette.black.paint();
+  static final Paint black = BasicPalette.black.paint();
-  static Paint gray = const PaletteEntry(Color(0xFFCCCCCC)).paint();
+  static final Paint gray = const PaletteEntry(Color(0xFFCCCCCC)).paint();
-  static TextPaint text = TextPaint(
+  static final TextPaint text = TextPaint(
     style: TextStyle(color: BasicPalette.white.color),
   );
 

examples/lib/stories/input/hardware_keyboard_example.dart

@@ -7,7 +7,7 @@ import 'package:flutter/rendering.dart';
 import 'package:flutter/services.dart';
 
 class HardwareKeyboardExample extends FlameGame {
-  static String description = '''
+  static const String description = '''
     This example uses the HardwareKeyboardDetector mixin in order to keep
     track of which keys on a keyboard are currently pressed.
 
@@ -67,7 +67,7 @@ class MyKeyboardDetector extends HardwareKeyboardDetector
   /// The names of keyboard keys (at least the most important ones). We can't
   /// rely on `key.debugName` because this property is not available in release
   /// builds.
-  static Map<PhysicalKeyboardKey, String> keyNames = {
+  static final Map<PhysicalKeyboardKey, String> keyNames = {
     PhysicalKeyboardKey.hyper: 'Hyper',
     PhysicalKeyboardKey.superKey: 'Super',
     PhysicalKeyboardKey.fn: 'Fn',
@@ -233,12 +233,12 @@ class KeyboardKey extends PositionComponent {
   /// they are waiting to be removed.
   bool visible = true;
 
-  static Vector2 padding = Vector2(24, 12);
+  static final Vector2 padding = Vector2(24, 12);
-  static Paint borderPaint = Paint()
+  static final Paint borderPaint = Paint()
     ..style = PaintingStyle.stroke
     ..strokeWidth = 3
     ..color = const Color(0xffb5ffd0);
-  static TextPaint textRenderer = TextPaint(
+  static final TextPaint textRenderer = TextPaint(
     style: const TextStyle(
       fontSize: 20,
       fontWeight: FontWeight.bold,

packages/flame/lib/src/components/input/sprite_button_component.dart

@@ -46,8 +46,10 @@ class SpriteButtonComponent extends SpriteGroupComponent<ButtonState>
       button != null,
       'The button sprite has to be set either in onLoad or in the constructor',
     );
-    sprites = {ButtonState.up: button!};
+    sprites = {
-    sprites![ButtonState.down] = buttonDown ?? button!;
+      ButtonState.up: button!,
+      ButtonState.down: buttonDown ?? button!,
+    };
     super.onMount();
   }
 

packages/flame_studio/lib/src/core/component_tree.dart

@@ -63,7 +63,7 @@ class ComponentTreeObserver extends StateNotifier<ComponentTreeState> {
     }
   }
 
-  static Duration refreshFrequency = const Duration(milliseconds: 300);
+  static const Duration refreshFrequency = Duration(milliseconds: 300);
 
   void _refresh() {
     if (!mounted) {

packages/flame_studio/lib/src/widgets/toolbar/toolbar_button.dart

@@ -68,6 +68,13 @@ class ToolbarButtonState extends ConsumerState<ToolbarButton> {
   }
 }
 
+enum _ToolbarButtonRenderState {
+  disabled,
+  active,
+  hovered,
+  normal,
+}
+
 class _ToolbarButtonPainter extends CustomPainter {
   _ToolbarButtonPainter(
     this.icon,
@@ -89,26 +96,26 @@ class _ToolbarButtonPainter extends CustomPainter {
     canvas.save();
     canvas.scale(size.height / 20.0);
 
+    final renderState = _renderState;
+
     final radius = Radius.circular(theme.buttonRadius);
-    final color = isDisabled
+    final color = switch (renderState) {
-        ? theme.buttonDisabledColor
+      _ToolbarButtonRenderState.disabled => theme.buttonDisabledColor,
-        : isActive
+      _ToolbarButtonRenderState.active => theme.buttonActiveColor,
-            ? theme.buttonActiveColor
+      _ToolbarButtonRenderState.hovered => theme.buttonHoverColor,
-            : isHovered
+      _ToolbarButtonRenderState.normal => theme.buttonColor,
-                ? theme.buttonHoverColor
+    };
-                : theme.buttonColor;
     canvas.drawRRect(
       RRect.fromLTRBR(0, 0, size.width / scale, 20.0, radius),
       Paint()..color = color,
     );
 
-    final textColor = isDisabled
+    final textColor = switch (renderState) {
-        ? theme.buttonDisabledTextColor
+      _ToolbarButtonRenderState.disabled => theme.buttonDisabledTextColor,
-        : isActive
+      _ToolbarButtonRenderState.active => theme.buttonActiveTextColor,
-            ? theme.buttonActiveTextColor
+      _ToolbarButtonRenderState.hovered => theme.buttonHoverTextColor,
-            : isHovered
+      _ToolbarButtonRenderState.normal => theme.buttonTextColor,
-                ? theme.buttonHoverTextColor
+    };
-                : theme.buttonTextColor;
     canvas.translate(size.width / scale / 2, 10);
     canvas.drawPath(icon, Paint()..color = textColor);
     canvas.restore();
@@ -121,4 +128,17 @@ class _ToolbarButtonPainter extends CustomPainter {
         isDisabled != old.isDisabled ||
         icon != old.icon;
   }
+
+  _ToolbarButtonRenderState get _renderState {
+    if (isDisabled) {
+      return _ToolbarButtonRenderState.disabled;
+    }
+    if (isActive) {
+      return _ToolbarButtonRenderState.active;
+    }
+    if (isHovered) {
+      return _ToolbarButtonRenderState.hovered;
+    }
+    return _ToolbarButtonRenderState.normal;
+  }
 }