flutter/flame
1
0
Fork 0
mirror of https://github.com/flame-engine/flame.git synced 2025-11-04 04:47:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix alternation bug of combined effect

Browse Source
This commit is contained in:
Lukas Klingsbo
2020-10-12 17:57:30 +02:00
parent cacab48108
commit 0135085184
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/examples/effects/sequence_effect/lib/main.dart
View File

@ -75,12 +75,14 @@ class MyGame extends BaseGame with TapDetector {
isAlternating: false, isAlternating: false,
isInfinite: false, isInfinite: false,
); );
combination.onComplete = () => print("combination complete");
final sequence = SequenceEffect( final sequence = SequenceEffect(
effects: [move1, scale, combination], effects: [move1, scale, combination],
isInfinite: false, isInfinite: false,
isAlternating: true, isAlternating: true,
); );
sequence.onComplete = () => print("sequence complete");
greenSquare.addEffect(sequence); greenSquare.addEffect(sequence);
} }
} }

9
lib/effects/combined_effect.dart
View File

@ -53,10 +53,6 @@ class CombinedEffect extends PositionComponentEffect {
if (effects.every((effect) => effect.hasFinished())) { if (effects.every((effect) => effect.hasFinished())) {
if (isAlternating && curveDirection.isNegative) { if (isAlternating && curveDirection.isNegative) {
effects.forEach((effect) => effect.isAlternating = true); effects.forEach((effect) => effect.isAlternating = true);
} else if (isInfinite) {
reset();
} else if (isAlternating && isMin()) {
dispose();
} }
} }
} }
@ -96,11 +92,6 @@ class CombinedEffect extends PositionComponentEffect {
} }
} }
@override
bool hasFinished() {
return super.hasFinished() && effects.every((e) => e.hasFinished());
}
void _maybeReverse(PositionComponentEffect effect) { void _maybeReverse(PositionComponentEffect effect) {
if (isAlternating && !effect.isAlternating && effect.isMax()) { if (isAlternating && !effect.isAlternating && effect.isMax()) {
// Make the effect go in reverse // Make the effect go in reverse