flutter/apidash
1
0
Fork 0
mirror of https://github.com/foss42/apidash.git synced 2025-05-29 21:06:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #477 from ClementBeal/feat-open-menu-with-right-click

Browse Source 
feat:  open ItemCardMenu with a right click
This commit is contained in:
Ashita Prasad
2024-10-21 06:56:44 +05:30
committed by GitHub
parent e2849b5cb0 576d543309
commit eca3bec3a4
8 changed files with 81 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/consts.dart
View File

@ -172,6 +172,7 @@ const kPb15 = EdgeInsets.only(
const kPb70 = EdgeInsets.only(
bottom: 70,
);
const kSizedBoxEmpty = SizedBox();
const kHSpacer2 = SizedBox(width: 2);
const kHSpacer4 = SizedBox(width: 4);
const kHSpacer5 = SizedBox(width: 5);

3
lib/screens/envvar/environments_pane.dart
View File

@ -193,6 +193,9 @@ class EnvironmentItem extends ConsumerWidget {
ref.read(selectedEnvironmentIdStateProvider.notifier).state = id;
kEnvScaffoldKey.currentState?.closeDrawer();
},
onSecondaryTap: () {
ref.read(selectedEnvironmentIdStateProvider.notifier).state = id;
},
focusNode: ref.watch(nameTextFieldFocusNodeProvider),
onChangedNameEditor: (value) {
value = value.trim();

3
lib/screens/home_page/collection_pane.dart
View File

@ -223,6 +223,9 @@ class RequestItem extends ConsumerWidget {
ref.read(selectedIdStateProvider.notifier).state = id;
kHomeScaffoldKey.currentState?.closeDrawer();
},
onSecondaryTap: () {
ref.read(selectedIdStateProvider.notifier).state = id;
},
// onDoubleTap: () {
// ref.read(selectedIdStateProvider.notifier).state = id;
// ref.read(selectedIdEditStateProvider.notifier).state = id;

9
lib/widgets/card_sidebar_environment.dart
View File

@ -69,7 +69,13 @@ class SidebarEnvironmentCard extends StatelessWidget {
hoverColor: colorVariant,
focusColor: colorVariant.withOpacity(0.5),
onTap: inEditMode ? null : onTap,
onSecondaryTap: onSecondaryTap,
// onSecondaryTap: onSecondaryTap,
onSecondaryTapUp: (isGlobal)
? null
: (details) {
onSecondaryTap?.call();
showItemCardMenu(context, details, onMenuSelected);
},
child: Padding(
padding: EdgeInsets.only(
left: 6,
@ -90,6 +96,7 @@ class SidebarEnvironmentCard extends StatelessWidget {
focusNode: focusNode,
style: Theme.of(context).textTheme.bodyMedium,
onTapOutside: (_) {
FocusScope.of(context).unfocus();
onTapOutsideNameEditor?.call();
},
onFieldSubmitted: (value) {

7
lib/widgets/card_sidebar_request.dart
View File

@ -71,7 +71,10 @@ class SidebarRequestCard extends StatelessWidget {
focusColor: colorVariant.withOpacity(0.5),
onTap: inEditMode ? null : onTap,
// onDoubleTap: inEditMode ? null : onDoubleTap,
onSecondaryTap: onSecondaryTap,
onSecondaryTapUp: (details) {
onSecondaryTap?.call();
showItemCardMenu(context, details, onMenuSelected);
},
child: Padding(
padding: EdgeInsets.only(
left: 6,
@ -95,8 +98,8 @@ class SidebarRequestCard extends StatelessWidget {
//autofocus: true,
style: Theme.of(context).textTheme.bodyMedium,
onTapOutside: (_) {
FocusScope.of(context).unfocus();
onTapOutsideNameEditor?.call();
//FocusScope.of(context).unfocus();
},
onFieldSubmitted: (value) {
onTapOutsideNameEditor?.call();

26
lib/widgets/menu_item_card.dart
View File

@ -41,3 +41,29 @@ class ItemCardMenu extends StatelessWidget {
);
}
}
/// Open the item card menu where the right click has been released
Future<void> showItemCardMenu(
BuildContext context,
TapUpDetails details,
Function(ItemMenuOption)? onSelected,
) async {
showMenu(
context: context,
position: RelativeRect.fromLTRB(
details.globalPosition.dx,
details.globalPosition.dy,
details.globalPosition.dx,
details.globalPosition.dy,
),
items: ItemMenuOption.values
.map<PopupMenuEntry<ItemMenuOption>>(
(e) => PopupMenuItem<ItemMenuOption>(
onTap: () => onSelected?.call(e),
value: e,
child: Text(e.label),
),
)
.toList(),
);
}

9
test/providers/ui_providers_test.dart
View File

@ -13,6 +13,7 @@ import 'package:apidash/screens/settings_page.dart';
import 'package:apidash/screens/history/history_page.dart';
import 'package:apidash/widgets/widgets.dart';
import 'package:extended_text_field/extended_text_field.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_portal/flutter_portal.dart';
@ -279,7 +280,7 @@ void main() {
});
testWidgets(
'selectedIdEditStateProvider should not be null after rename button has been tapped',
'selectedIdEditStateProvider should not be null after Duplicate button has been tapped',
(tester) async {
await tester.pumpWidget(
ProviderScope(
@ -304,7 +305,11 @@ void main() {
await tester.pump();
await tester.tap(find.byType(RequestItem));
await tester.pump();
await tester.tap(find.byIcon(Icons.more_vert).at(1));
//await tester.tap(find.byIcon(Icons.more_vert).at(1));
await tester.tap(
find.byType(RequestItem),
buttons: kSecondaryButton,
);
await tester.pumpAndSettle();
// Tap on the "Duplicate" option in the menu

28
test/widgets/menu_item_card_test.dart
View File

@ -49,4 +49,32 @@ void main() {
expect(changedValue, ItemMenuOption.duplicate);
});
testWidgets('showItemCardMenu shows the menu at the right position',
(WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Builder(
builder: (BuildContext context) {
return GestureDetector(
onTapUp: (details) {
showItemCardMenu(
context, details, (ItemMenuOption option) {});
},
child: const Text('Show Menu'),
);
},
),
),
),
);
await tester.tap(find.text('Show Menu'));
await tester.pumpAndSettle();
for (var option in ItemMenuOption.values) {
expect(find.text(option.label), findsOneWidget);
}
});
}