From 32855fd2f9214909bfa3bdf0b3e5ca06d4a6d72d Mon Sep 17 00:00:00 2001 From: Udhay-Adithya Date: Sun, 6 Jul 2025 12:28:35 +0530 Subject: [PATCH] refactor: update authentication handling to check authData instead of enableAuth flag --- packages/better_networking/lib/services/http_service.dart | 3 +-- packages/better_networking/lib/utils/auth/handle_auth.dart | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/better_networking/lib/services/http_service.dart b/packages/better_networking/lib/services/http_service.dart index 7c670f9d..844ef69b 100644 --- a/packages/better_networking/lib/services/http_service.dart +++ b/packages/better_networking/lib/services/http_service.dart @@ -20,7 +20,6 @@ Future<(HttpResponse?, Duration?, String?)> sendHttpRequest( HttpRequestModel requestModel, { SupportedUriSchemes defaultUriScheme = kDefaultUriScheme, bool noSSL = false, - bool enableAuth = true, }) async { if (httpClientManager.wasRequestCancelled(requestId)) { httpClientManager.removeCancelledRequest(requestId); @@ -30,7 +29,7 @@ Future<(HttpResponse?, Duration?, String?)> sendHttpRequest( HttpRequestModel authenticatedRequestModel = requestModel.copyWith(); try { - if (enableAuth) { + if (authData != null && authData.type != APIAuthType.none) { authenticatedRequestModel = await handleAuth(requestModel, authData); } } catch (e) { diff --git a/packages/better_networking/lib/utils/auth/handle_auth.dart b/packages/better_networking/lib/utils/auth/handle_auth.dart index 26663144..8228f87e 100644 --- a/packages/better_networking/lib/utils/auth/handle_auth.dart +++ b/packages/better_networking/lib/utils/auth/handle_auth.dart @@ -111,7 +111,6 @@ Future handleAuth( APIType.rest, authData, httpRequestModel, - enableAuth: false, ); final httpResponse = httpResult.$1;