flutter/apidash
1
0
Fork 0
mirror of https://github.com/foss42/apidash.git synced 2025-05-30 05:21:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #415

Browse Source
This commit is contained in:
Ashita Prasad
2024-09-17 02:30:58 +05:30
parent abdd397cb7
commit 28a22218fc
3 changed files with 42 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/utils/http_utils.dart
View File

@ -101,7 +101,9 @@ String stripUrlParams(String url) {
(List<ResponseBodyView>, String?) getResponseBodyViewOptions(
MediaType? mediaType) {
if (mediaType != null) {
if (mediaType == null) {
return (kRawBodyViewOptions, null);
}
var type = mediaType.type;
var subtype = mediaType.subtype;
if (kResponseBodyViewOptions.containsKey(type)) {
@ -128,7 +130,6 @@ String stripUrlParams(String url) {
subtype
);
}
}
return (kNoBodyViewOptions, null);
}

14
lib/widgets/response_widgets.dart
View File

@ -345,12 +345,14 @@ class ResponseBody extends StatelessWidget {
);
}
var mediaType = responseModel.mediaType;
if (mediaType == null) {
return ErrorMessage(
message:
'$kMsgUnknowContentType - ${responseModel.contentType}. $kUnexpectedRaiseIssue');
}
final mediaType =
responseModel.mediaType ?? MediaType(kTypeText, kSubTypePlain);
// Fix #415: Treat null Content-type as plain text instead of Error message
// if (mediaType == null) {
// return ErrorMessage(
// message:
// '$kMsgUnknowContentType - ${responseModel.contentType}. $kUnexpectedRaiseIssue');
// }
var responseBodyView = getResponseBodyViewOptions(mediaType);
var options = responseBodyView.$1;

15
test/widgets/response_widgets_test.dart
View File

@ -214,8 +214,13 @@ void main() {
findsOneWidget);
});
testWidgets('Testing Response Body, no mediaType', (tester) async {
var responseModelNoHeaders = responseModel.copyWith(headers: null);
testWidgets(
'Testing Response Body, no mediaType; shoud be default plaintext preview',
(tester) async {
var responseModelNoHeaders = responseModel.copyWith(
headers: null,
formattedBody: null,
);
var requestModelNoResponseHeaders =
testRequestModel.copyWith(httpResponseModel: responseModelNoHeaders);
@ -230,10 +235,8 @@ void main() {
),
);
expect(
find.text(
'Unknown Response Content-Type - ${responseModelNoHeaders.contentType}. $kUnexpectedRaiseIssue'),
findsOneWidget);
expect(find.text("Raw"), findsOneWidget);
expect(find.text('{"data":"world"}'), findsOneWidget);
});
testWidgets('Testing Response Body for No body view', (tester) async {