flutter/apidash
1
0
Fork 0
mirror of https://github.com/foss42/apidash.git synced 2025-12-02 10:49:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove unnecessary setState when the value changes, which causes the EnvAuthField widget to rebuild and the cursor position to reset

Browse Source
This commit is contained in:
Udhay-Adithya
2025-08-07 15:42:29 +05:30
parent 51244831e7
commit 18128114f6
2 changed files with 35 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lib/screens/common_widgets/auth/oauth1_fields.dart
View File

@@ -96,9 +96,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
hintText: kHintOAuth1ConsumerKey, hintText: kHintOAuth1ConsumerKey,
infoText: kInfoOAuth1ConsumerKey, infoText: kInfoOAuth1ConsumerKey,
onChanged: (value) { onChanged: (value) {
setState(() {
_consumerKey = value; _consumerKey = value;
});
_updateOAuth1(); _updateOAuth1();
}, },
), ),
@@ -110,9 +108,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
infoText: kInfoOAuth1ConsumerSecret, infoText: kInfoOAuth1ConsumerSecret,
isObscureText: true, isObscureText: true,
onChanged: (value) { onChanged: (value) {
setState(() {
_consumerSecret = value; _consumerSecret = value;
});
_updateOAuth1(); _updateOAuth1();
}, },
), ),
@@ -134,10 +130,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
? null ? null
: (OAuth1SignatureMethod? newAlgo) { : (OAuth1SignatureMethod? newAlgo) {
if (newAlgo != null) { if (newAlgo != null) {
setState(() {
_signatureMethodController = newAlgo; _signatureMethodController = newAlgo;
});
_updateOAuth1(); _updateOAuth1();
} }
}, },
@@ -149,9 +142,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
hintText: kHintOAuth1AccessToken, hintText: kHintOAuth1AccessToken,
infoText: kInfoOAuth1AccessToken, infoText: kInfoOAuth1AccessToken,
onChanged: (value) { onChanged: (value) {
setState(() {
_accessToken = value; _accessToken = value;
});
_updateOAuth1(); _updateOAuth1();
}, },
), ),
@@ -163,9 +154,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
infoText: kInfoOAuth1TokenSecret, infoText: kInfoOAuth1TokenSecret,
isObscureText: true, isObscureText: true,
onChanged: (value) { onChanged: (value) {
setState(() {
_tokenSecret = value; _tokenSecret = value;
});
_updateOAuth1(); _updateOAuth1();
}, },
), ),
@@ -176,9 +165,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
hintText: kHintOAuth1CallbackUrl, hintText: kHintOAuth1CallbackUrl,
infoText: kInfoOAuth1CallbackUrl, infoText: kInfoOAuth1CallbackUrl,
onChanged: (value) { onChanged: (value) {
setState(() {
_callbackUrl = value; _callbackUrl = value;
});
_updateOAuth1(); _updateOAuth1();
}, },
), ),
@@ -189,9 +176,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
hintText: kHintOAuth1Verifier, hintText: kHintOAuth1Verifier,
infoText: kInfoOAuth1Verifier, infoText: kInfoOAuth1Verifier,
onChanged: (value) { onChanged: (value) {
setState(() {
_verifier = value; _verifier = value;
});
_updateOAuth1(); _updateOAuth1();
}, },
), ),
@@ -202,9 +187,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
hintText: kHintOAuth1Timestamp, hintText: kHintOAuth1Timestamp,
infoText: kInfoOAuth1Timestamp, infoText: kInfoOAuth1Timestamp,
onChanged: (value) { onChanged: (value) {
setState(() {
_timestamp = value; _timestamp = value;
});
_updateOAuth1(); _updateOAuth1();
}, },
), ),
@@ -215,9 +198,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
hintText: kHintOAuth1Nonce, hintText: kHintOAuth1Nonce,
infoText: kInfoOAuth1Nonce, infoText: kInfoOAuth1Nonce,
onChanged: (value) { onChanged: (value) {
setState(() {
_nonce = value; _nonce = value;
});
_updateOAuth1(); _updateOAuth1();
}, },
), ),
@@ -228,9 +209,7 @@ class _OAuth1FieldsState extends ConsumerState<OAuth1Fields> {
hintText: kHintOAuth1Realm, hintText: kHintOAuth1Realm,
infoText: kInfoOAuth1Realm, infoText: kInfoOAuth1Realm,
onChanged: (value) { onChanged: (value) {
setState(() {
_realm = value; _realm = value;
});
_updateOAuth1(); _updateOAuth1();
}, },
), ),

39
lib/screens/common_widgets/auth/oauth2_field.dart
View File

@@ -145,9 +145,7 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
? null ? null
: (OAuth2GrantType? newGrantType) { : (OAuth2GrantType? newGrantType) {
if (newGrantType != null && newGrantType != _grantType) { if (newGrantType != null && newGrantType != _grantType) {
setState(() {
_grantType = newGrantType; _grantType = newGrantType;
});
_updateOAuth2(); _updateOAuth2();
} }
@@ -162,9 +160,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2AuthorizationUrl, hintText: kHintOAuth2AuthorizationUrl,
infoText: kInfoOAuth2AuthorizationUrl, infoText: kInfoOAuth2AuthorizationUrl,
onChanged: (value) { onChanged: (value) {
setState(() {
_authorizationUrl = value; _authorizationUrl = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -177,9 +174,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2Username, hintText: kHintOAuth2Username,
infoText: kInfoOAuth2Username, infoText: kInfoOAuth2Username,
onChanged: (value) { onChanged: (value) {
setState(() {
_username = value; _username = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -193,9 +189,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
infoText: kInfoOAuth2Password, infoText: kInfoOAuth2Password,
isObscureText: true, isObscureText: true,
onChanged: (value) { onChanged: (value) {
setState(() {
_password = value; _password = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -208,9 +203,7 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2AccessTokenUrl, hintText: kHintOAuth2AccessTokenUrl,
infoText: kInfoOAuth2AccessTokenUrl, infoText: kInfoOAuth2AccessTokenUrl,
onChanged: (value) { onChanged: (value) {
setState(() {
_accessTokenUrl = value; _accessTokenUrl = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -223,9 +216,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2ClientId, hintText: kHintOAuth2ClientId,
infoText: kInfoOAuth2ClientId, infoText: kInfoOAuth2ClientId,
onChanged: (value) { onChanged: (value) {
setState(() {
_clientId = value; _clientId = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -239,9 +231,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
infoText: kInfoOAuth2ClientSecret, infoText: kInfoOAuth2ClientSecret,
isObscureText: true, isObscureText: true,
onChanged: (value) { onChanged: (value) {
setState(() {
_clientSecret = value; _clientSecret = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -265,9 +256,7 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
: (String? newMethod) { : (String? newMethod) {
if (newMethod != null && if (newMethod != null &&
newMethod != _codeChallengeMethod) { newMethod != _codeChallengeMethod) {
setState(() {
_codeChallengeMethod = newMethod; _codeChallengeMethod = newMethod;
});
_updateOAuth2(); _updateOAuth2();
} }
@@ -283,9 +272,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2RedirectUrl, hintText: kHintOAuth2RedirectUrl,
infoText: kInfoOAuth2RedirectUrl, infoText: kInfoOAuth2RedirectUrl,
onChanged: (value) { onChanged: (value) {
setState(() {
_redirectUrl = value; _redirectUrl = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -298,9 +286,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2Scope, hintText: kHintOAuth2Scope,
infoText: kInfoOAuth2Scope, infoText: kInfoOAuth2Scope,
onChanged: (value) { onChanged: (value) {
setState(() {
_scope = value; _scope = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -313,9 +300,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2State, hintText: kHintOAuth2State,
infoText: kInfoOAuth2State, infoText: kInfoOAuth2State,
onChanged: (value) { onChanged: (value) {
setState(() {
_state = value; _state = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -338,9 +324,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2RefreshToken, hintText: kHintOAuth2RefreshToken,
infoText: kInfoOAuth2RefreshToken, infoText: kInfoOAuth2RefreshToken,
onChanged: (value) { onChanged: (value) {
setState(() {
_refreshToken = value; _refreshToken = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -352,9 +337,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2IdentityToken, hintText: kHintOAuth2IdentityToken,
infoText: kInfoOAuth2IdentityToken, infoText: kInfoOAuth2IdentityToken,
onChanged: (value) { onChanged: (value) {
setState(() {
_identityToken = value; _identityToken = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),
@@ -369,9 +353,8 @@ class _OAuth2FieldsState extends ConsumerState<OAuth2Fields> {
hintText: kHintOAuth2AccessToken, hintText: kHintOAuth2AccessToken,
infoText: kInfoOAuth2AccessToken, infoText: kInfoOAuth2AccessToken,
onChanged: (value) { onChanged: (value) {
setState(() {
_accessToken = value; _accessToken = value;
});
_updateOAuth2(); _updateOAuth2();
}, },
), ),