v0.2.18 (#49)

* allow plaintext http connections (#48)

via https://stackoverflow.com/a/56837613

I was unable to open an article just now, and a fww minutes later unable to open a comment (since the webview is still being forced on my not-yet-updated client, i have to find the artocle to open it.

* bumped version.

* improved link preview.

* added share button.

* added ability to launch third party app for url on Android.

* added support for siri suggestions.

* bumped version.

* added support for app links on Android.

Co-authored-by: Efreak <Efreak@users.noreply.github.com>

README.md

@@ -4,7 +4,6 @@
 A simple noiseless [Hacker News](https://news.ycombinator.com/) client made with Flutter that is just enough.
 
 [![App Store](https://img.shields.io/itunes/v/1602043763?label=App%20Store)](https://apps.apple.com/us/app/hacki/id1602043763?platform=iphone)
-[![Play Store](https://img.shields.io/badge/Play%20Store--yellow)](https://play.google.com/store/apps/details?id=com.jiaqifeng.hacki&hl=en_US&gl=US)
 [![Fdroid version](https://img.shields.io/f-droid/v/com.jiaqifeng.hacki)](https://f-droid.org/en/packages/com.jiaqifeng.hacki/)
 [![GH version](https://img.shields.io/github/release/livinglist/hacki.svg?logo=github)](https://github.com/Livinglist/Hacki/releases/latest)
 [![Visits Badge](https://badges.pufler.dev/visits/livinglist/Hacki)](https://badges.pufler.dev)

android/app/src/main/AndroidManifest.xml

@@ -17,7 +17,8 @@
 
    <application
         android:label="hacki"
-        android:icon="@mipmap/ic_launcher">
+        android:icon="@mipmap/ic_launcher"
+        android:usesCleartextTraffic="true">
         <activity
             android:name=".MainActivity"
             android:launchMode="singleTop"
@@ -52,6 +53,21 @@
                 <category android:name="android.intent.category.DEFAULT" />
                 <data android:mimeType="*/*" />
             </intent-filter>
+
+            <intent-filter android:autoVerify="true">
+                <action android:name="android.intent.action.VIEW" />
+                <category android:name="android.intent.category.DEFAULT" />
+                <category android:name="android.intent.category.BROWSABLE" />
+
+                <data
+                    android:scheme="http"
+                    android:host="news.ycombinator.com"
+                    android:pathPrefix="/item" />
+                <data
+                    android:scheme="https"
+                    android:host="news.ycombinator.com"
+                    android:pathPrefix="/item" />
+            </intent-filter>
         </activity>
         <!-- Don't delete the meta-data below.
              This is used by the Flutter tool to generate GeneratedPluginRegistrant.java -->

fastlane/metadata/android/en-US/changelogs/56.txt

@@ -0,0 +1,6 @@
+- You can now add filters for searching.
+- You can now participate in polls.
+- Pick up where you left off.
+- Swipe left on comment tile to view its parents without scrolling all the way up.
+- Huge performance boost.
+- Bugfixes.

fastlane/metadata/android/en-US/changelogs/57.txt

@@ -0,0 +1,7 @@
+- You can share links.
+- You can now add filters for searching.
+- You can now participate in polls.
+- Pick up where you left off.
+- Swipe left on comment tile to view its parents without scrolling all the way up.
+- Huge performance boost.
+- Bugfixes.

ios/Podfile.lock

@@ -14,6 +14,8 @@ PODS:
     - Flutter
   - flutter_secure_storage (3.3.1):
     - Flutter
+  - flutter_siri_suggestions (0.0.1):
+    - Flutter
   - FMDB (2.7.5):
     - FMDB/standard (= 2.7.5)
   - FMDB/standard (2.7.5)
@@ -23,6 +25,8 @@ PODS:
   - ReachabilitySwift (5.0.0)
   - receive_sharing_intent (0.0.1):
     - Flutter
+  - share_plus (0.0.1):
+    - Flutter
   - shared_preferences_ios (0.0.1):
     - Flutter
   - sqflite (0.0.2):
@@ -47,8 +51,10 @@ DEPENDENCIES:
   - flutter_inappwebview (from `.symlinks/plugins/flutter_inappwebview/ios`)
   - flutter_local_notifications (from `.symlinks/plugins/flutter_local_notifications/ios`)
   - flutter_secure_storage (from `.symlinks/plugins/flutter_secure_storage/ios`)
+  - flutter_siri_suggestions (from `.symlinks/plugins/flutter_siri_suggestions/ios`)
   - path_provider_ios (from `.symlinks/plugins/path_provider_ios/ios`)
   - receive_sharing_intent (from `.symlinks/plugins/receive_sharing_intent/ios`)
+  - share_plus (from `.symlinks/plugins/share_plus/ios`)
   - shared_preferences_ios (from `.symlinks/plugins/shared_preferences_ios/ios`)
   - sqflite (from `.symlinks/plugins/sqflite/ios`)
   - synced_shared_preferences (from `.symlinks/plugins/synced_shared_preferences/ios`)
@@ -75,10 +81,14 @@ EXTERNAL SOURCES:
     :path: ".symlinks/plugins/flutter_local_notifications/ios"
   flutter_secure_storage:
     :path: ".symlinks/plugins/flutter_secure_storage/ios"
+  flutter_siri_suggestions:
+    :path: ".symlinks/plugins/flutter_siri_suggestions/ios"
   path_provider_ios:
     :path: ".symlinks/plugins/path_provider_ios/ios"
   receive_sharing_intent:
     :path: ".symlinks/plugins/receive_sharing_intent/ios"
+  share_plus:
+    :path: ".symlinks/plugins/share_plus/ios"
   shared_preferences_ios:
     :path: ".symlinks/plugins/shared_preferences_ios/ios"
   sqflite:
@@ -102,11 +112,13 @@ SPEC CHECKSUMS:
   flutter_inappwebview: bfd58618f49dc62f2676de690fc6dcda1d6c3721
   flutter_local_notifications: 0c0b1ae97e741e1521e4c1629a459d04b9aec743
   flutter_secure_storage: 7953c38a04c3fdbb00571bcd87d8e3b5ceb9daec
+  flutter_siri_suggestions: 226fb7ef33d25d3fe0d4aa2a8bcf4b72730c466f
   FMDB: 2ce00b547f966261cd18927a3ddb07cb6f3db82a
   OrderedSet: aaeb196f7fef5a9edf55d89760da9176ad40b93c
   path_provider_ios: 14f3d2fd28c4fdb42f44e0f751d12861c43cee02
   ReachabilitySwift: 985039c6f7b23a1da463388634119492ff86c825
   receive_sharing_intent: c0d87310754e74c0f9542947e7cbdf3a0335a3b1
+  share_plus: 056a1e8ac890df3e33cb503afffaf1e9b4fbae68
   shared_preferences_ios: 548a61f8053b9b8a49ac19c1ffbc8b92c50d68ad
   sqflite: 6d358c025f5b867b29ed92fc697fd34924e11904
   synced_shared_preferences: f722742b06d65c7315b8e9f56b794c9fbd5597f7

ios/Runner.xcodeproj/project.pbxproj

@@ -577,7 +577,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 0.2.16;
+				MARKETING_VERSION = 0.2.18;
 				PRODUCT_BUNDLE_IDENTIFIER = com.jiaqi.hacki;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -714,7 +714,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 0.2.16;
+				MARKETING_VERSION = 0.2.18;
 				PRODUCT_BUNDLE_IDENTIFIER = com.jiaqi.hacki;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -745,7 +745,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 0.2.16;
+				MARKETING_VERSION = 0.2.18;
 				PRODUCT_BUNDLE_IDENTIFIER = com.jiaqi.hacki;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";

lib/cubits/comments/comments_cubit.dart

@@ -2,6 +2,7 @@ import 'dart:async';
 
 import 'package:bloc/bloc.dart';
 import 'package:equatable/equatable.dart';
+import 'package:flutter_linkify/flutter_linkify.dart';
 import 'package:hacki/config/locator.dart';
 import 'package:hacki/models/models.dart';
 import 'package:hacki/repositories/repositories.dart';
@@ -159,10 +160,19 @@ class CommentsCubit extends Cubit<CommentsState> {
         ..addKid(comment.id, to: comment.parent)
         ..cacheComment(comment);
       _sembastRepository.cacheComment(comment);
+
+      final List<LinkifyElement> elements = linkify(
+        comment.text,
+      );
+
+      final BuildableComment buildableComment =
+          BuildableComment.fromComment(comment, elements: elements);
+
       final List<Comment> updatedComments = <Comment>[
         ...state.comments,
-        comment
+        buildableComment
       ];
+
       emit(state.copyWith(comments: updatedComments));
 
       if (updatedComments.length >= _pageSize + _pageSize * state.currentPage &&
@@ -180,6 +190,31 @@ class CommentsCubit extends Cubit<CommentsState> {
     }
   }
 
+  List<LinkifyElement> linkify(
+    String text, {
+    LinkifyOptions options = const LinkifyOptions(),
+    List<Linkifier> linkifiers = const <Linkifier>[
+      UrlLinkifier(),
+      EmailLinkifier(),
+    ],
+  }) {
+    List<LinkifyElement> list = <LinkifyElement>[TextElement(text)];
+
+    if (text.isEmpty) {
+      return <LinkifyElement>[];
+    }
+
+    if (linkifiers.isEmpty) {
+      return list;
+    }
+
+    for (final Linkifier linkifier in linkifiers) {
+      list = linkifier.parse(list, options);
+    }
+
+    return list;
+  }
+
   @override
   Future<void> close() async {
     await _streamSubscription?.cancel();

lib/cubits/cubits.dart

@@ -14,4 +14,5 @@ export 'search/search_cubit.dart';
 export 'split_view/split_view_cubit.dart';
 export 'submit/submit_cubit.dart';
 export 'time_machine/time_machine_cubit.dart';
+export 'user/user_cubit.dart';
 export 'vote/vote_cubit.dart';

lib/cubits/user/user_cubit.dart

@@ -0,0 +1,26 @@
+import 'package:equatable/equatable.dart';
+import 'package:flutter_bloc/flutter_bloc.dart';
+import 'package:hacki/config/locator.dart';
+import 'package:hacki/models/models.dart';
+import 'package:hacki/repositories/repositories.dart';
+
+part 'user_state.dart';
+
+class UserCubit extends Cubit<UserState> {
+  UserCubit({StoriesRepository? storiesRepository})
+      : _storiesRepository =
+            storiesRepository ?? locator.get<StoriesRepository>(),
+        super(UserState.init());
+
+  final StoriesRepository _storiesRepository;
+
+  void init({required String userId}) {
+    emit(state.copyWith(status: UserStatus.loading));
+    _storiesRepository.fetchUserBy(userId: userId).then((User user) {
+      emit(state.copyWith(user: user, status: UserStatus.loaded));
+    }).onError((_, __) {
+      emit(state.copyWith(status: UserStatus.failure));
+      return;
+    });
+  }
+}

lib/cubits/user/user_state.dart

@@ -0,0 +1,38 @@
+part of 'user_cubit.dart';
+
+enum UserStatus {
+  initial,
+  loading,
+  loaded,
+  failure,
+}
+
+class UserState extends Equatable {
+  const UserState({
+    required this.user,
+    required this.status,
+  });
+
+  UserState.init()
+      : user = User.empty(),
+        status = UserStatus.initial;
+
+  final User user;
+  final UserStatus status;
+
+  UserState copyWith({
+    User? user,
+    UserStatus? status,
+  }) {
+    return UserState(
+      user: user ?? this.user,
+      status: status ?? this.status,
+    );
+  }
+
+  @override
+  List<Object?> get props => <Object?>[
+        user,
+        status,
+      ];
+}

lib/main.dart

@@ -7,6 +7,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter/scheduler.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:flutter_local_notifications/flutter_local_notifications.dart';
+import 'package:flutter_siri_suggestions/flutter_siri_suggestions.dart';
 import 'package:hacki/blocs/blocs.dart';
 import 'package:hacki/config/custom_router.dart';
 import 'package:hacki/config/locator.dart';
@@ -24,6 +25,10 @@ import 'package:workmanager/workmanager.dart';
 final BehaviorSubject<String?> selectNotificationSubject =
     BehaviorSubject<String?>();
 
+// For receiving payload event from siri suggestions.
+final BehaviorSubject<String?> siriSuggestionSubject =
+    BehaviorSubject<String?>();
+
 Future<void> main() async {
   WidgetsFlutterBinding.ensureInitialized();
 
@@ -57,6 +62,16 @@ Future<void> main() async {
           badge: true,
           sound: true,
         );
+
+    FlutterSiriSuggestions.instance.configure(
+      onLaunch: (Map<String, dynamic> message) async {
+        final String? storyId = message['key'] as String?;
+
+        if (storyId == null) return;
+
+        siriSuggestionSubject.add(storyId);
+      },
+    );
   }
 
   final Directory tempDir = await getTemporaryDirectory();

lib/models/buildable_comment.dart

@@ -0,0 +1,33 @@
+import 'package:flutter_linkify/flutter_linkify.dart';
+import 'package:hacki/models/comment.dart';
+import 'package:hacki/models/models.dart';
+
+class BuildableComment extends Comment {
+  BuildableComment({
+    required super.id,
+    required super.time,
+    required super.parent,
+    required super.score,
+    required super.by,
+    required super.text,
+    required super.kids,
+    required super.deleted,
+    required super.level,
+    required this.elements,
+  });
+
+  BuildableComment.fromComment(Comment comment, {required this.elements})
+      : super(
+          id: comment.id,
+          time: comment.time,
+          parent: comment.parent,
+          score: comment.score,
+          by: comment.by,
+          text: comment.text,
+          kids: comment.kids,
+          deleted: comment.deleted,
+          level: comment.level,
+        );
+
+  final List<LinkifyElement> elements;
+}

lib/models/models.dart

@@ -1,3 +1,4 @@
+export 'buildable_comment.dart';
 export 'comment.dart';
 export 'item.dart';
 export 'poll_option.dart';

lib/models/user.dart

@@ -1,5 +1,7 @@
 import 'dart:convert';
 
+import 'package:intl/intl.dart';
+
 class User {
   User({
     required this.about,
@@ -29,6 +31,12 @@ class User {
   final String id;
   final int karma;
 
+  static final DateFormat _dateTimeFormatter = DateFormat.yMMMd();
+
+  String get description {
+    return '''$karma karma, created on ${_dateTimeFormatter.format(DateTime.fromMillisecondsSinceEpoch(created * 1000))}''';
+  }
+
   @override
   String toString() {
     final String prettyString =

lib/screens/home_screen.dart

@@ -2,6 +2,7 @@
 
 import 'dart:async';
 import 'dart:convert';
+import 'dart:io';
 
 import 'package:badges/badges.dart';
 import 'package:feature_discovery/feature_discovery.dart';
@@ -10,6 +11,7 @@ import 'package:flutter/scheduler.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:flutter_fadein/flutter_fadein.dart';
+import 'package:flutter_siri_suggestions/flutter_siri_suggestions.dart';
 import 'package:flutter_slidable/flutter_slidable.dart';
 import 'package:hacki/blocs/blocs.dart';
 import 'package:hacki/config/constants.dart';
@@ -52,6 +54,7 @@ class _HomeScreenState extends State<HomeScreen>
   late final TabController tabController;
   late final StreamSubscription<String> intentDataStreamSubscription;
   late final StreamSubscription<String?> notificationStreamSubscription;
+  late final StreamSubscription<String?> siriSuggestionStreamSubscription;
 
   int currentIndex = 0;
 
@@ -88,6 +91,11 @@ class _HomeScreenState extends State<HomeScreen>
           selectNotificationSubject.stream.listen(onNotificationTapped);
     }
 
+    if (!siriSuggestionSubject.hasListener) {
+      siriSuggestionStreamSubscription =
+          siriSuggestionSubject.stream.listen(onSiriSuggestionTapped);
+    }
+
     SchedulerBinding.instance
       ..addPostFrameCallback((_) {
         FeatureDiscovery.discoverFeatures(
@@ -132,6 +140,7 @@ class _HomeScreenState extends State<HomeScreen>
     tabController.dispose();
     intentDataStreamSubscription.cancel();
     notificationStreamSubscription.cancel();
+    siriSuggestionStreamSubscription.cancel();
     super.dispose();
   }
 
@@ -171,7 +180,7 @@ class _HomeScreenState extends State<HomeScreen>
                       child: Container(
                         color: Colors.orangeAccent.withOpacity(0.2),
                         child: StoryTile(
-                          key: ObjectKey(story),
+                          key: ValueKey<String>('${story.id}-PinnedStoryTile'),
                           story: story,
                           onTap: () => onStoryTapped(story, isPin: true),
                           showWebPreview: preferenceState.showComplexStoryTile,
@@ -390,6 +399,18 @@ class _HomeScreenState extends State<HomeScreen>
             story: story,
           ),
         );
+
+    if (Platform.isIOS) {
+      FlutterSiriSuggestions.instance.registerActivity(
+        FlutterSiriActivity(
+          story.title,
+          story.id.toString(),
+          suggestedInvocationPhrase: '',
+          contentDescription: story.text,
+          persistentIdentifier: story.id.toString(),
+        ),
+      );
+    }
   }
 
   void showOnboarding() {
@@ -421,6 +442,24 @@ class _HomeScreenState extends State<HomeScreen>
     }
   }
 
+  Future<void> onSiriSuggestionTapped(String? id) async {
+    if (id == null) return;
+    final int? storyId = int.tryParse(id);
+    if (storyId == null) return;
+
+    await locator
+        .get<StoriesRepository>()
+        .fetchStoryBy(storyId)
+        .then((Story? story) {
+      if (story == null) {
+        showSnackBar(content: 'Something went wrong...');
+        return;
+      }
+      final StoryScreenArgs args = StoryScreenArgs(story: story);
+      goToStoryScreen(args: args);
+    });
+  }
+
   Future<void> onNotificationTapped(String? payload) async {
     if (payload == null) return;
 
@@ -543,7 +582,7 @@ class _TabletStoryView extends StatelessWidget {
           previous.storyScreenArgs != current.storyScreenArgs,
       builder: (BuildContext context, SplitViewState state) {
         if (state.storyScreenArgs != null) {
-          return StoryScreen.build(state.storyScreenArgs!);
+          return StoryScreen.build(context, state.storyScreenArgs!);
         }
 
         return Material(

lib/screens/profile/profile_screen.dart

@@ -407,7 +407,7 @@ class _ProfileScreenState extends State<ProfileScreen>
                                   showAboutDialog(
                                     context: context,
                                     applicationName: 'Hacki',
-                                    applicationVersion: 'v0.2.16',
+                                    applicationVersion: 'v0.2.18',
                                     applicationIcon: ClipRRect(
                                       borderRadius: const BorderRadius.all(
                                         Radius.circular(12),

lib/screens/story/story_screen.dart

@@ -22,10 +22,12 @@ import 'package:hacki/services/services.dart';
 import 'package:hacki/utils/utils.dart';
 import 'package:pull_to_refresh/pull_to_refresh.dart';
 import 'package:responsive_builder/responsive_builder.dart';
+import 'package:share_plus/share_plus.dart';
 
 enum _MenuAction {
   upvote,
   downvote,
+  share,
   block,
   flag,
   cancel,
@@ -88,8 +90,17 @@ class StoryScreen extends StatefulWidget {
     );
   }
 
-  static Widget build(StoryScreenArgs args) {
-    return MultiBlocProvider(
+  static Widget build(BuildContext context, StoryScreenArgs args) {
+    return WillPopScope(
+      onWillPop: () async {
+        if (context.read<SplitViewCubit>().state.expanded) {
+          context.read<SplitViewCubit>().zoom();
+          return false;
+        } else {
+          return true;
+        }
+      },
+      child: MultiBlocProvider(
         key: ValueKey<StoryScreenArgs>(args),
         providers: <BlocProvider<dynamic>>[
           BlocProvider<CommentsCubit>(
@@ -112,6 +123,7 @@ class StoryScreen extends StatefulWidget {
           parentComments: args.targetComments ?? <Comment>[],
           splitViewEnabled: true,
         ),
+      ),
     );
   }
 
@@ -140,7 +152,6 @@ class _StoryScreenState extends State<StoryScreen> {
     delay: _featureDiscoveryDismissThrottleDelay,
   );
 
-  static const int _extraItemsCount = 2;
   static const Duration _storyLinkTapThrottleDelay = Duration(seconds: 2);
   static const Duration _featureDiscoveryDismissThrottleDelay =
       Duration(seconds: 1);
@@ -270,12 +281,8 @@ class _StoryScreenState extends State<StoryScreen> {
                 onLoading: () {
                   context.read<CommentsCubit>().loadMore();
                 },
-                child: ListView.builder(
+                child: ListView(
                   primary: false,
-                  itemCount: state.comments.length + _extraItemsCount,
-                  itemBuilder: (BuildContext context, int index) {
-                    if (index == 0) {
-                      return Column(
                   children: <Widget>[
                     SizedBox(
                       height: topPadding,
@@ -294,10 +301,7 @@ class _StoryScreenState extends State<StoryScreen> {
                               HapticFeedback.lightImpact();
 
                               if (widget.story !=
-                                        context
-                                            .read<EditCubit>()
-                                            .state
-                                            .replyingTo) {
+                                  context.read<EditCubit>().state.replyingTo) {
                                 commentEditingController.clear();
                               }
                               context
@@ -377,13 +381,13 @@ class _StoryScreenState extends State<StoryScreen> {
                               child: SelectableLinkify(
                                 text: widget.story.text,
                                 style: TextStyle(
-                                        fontSize: MediaQuery.of(context)
-                                                .textScaleFactor *
+                                  fontSize:
+                                      MediaQuery.of(context).textScaleFactor *
                                           15,
                                 ),
                                 linkStyle: TextStyle(
-                                        fontSize: MediaQuery.of(context)
-                                                .textScaleFactor *
+                                  fontSize:
+                                      MediaQuery.of(context).textScaleFactor *
                                           15,
                                   color: Colors.orange,
                                 ),
@@ -414,9 +418,8 @@ class _StoryScreenState extends State<StoryScreen> {
                     ),
                     if (state.onlyShowTargetComment) ...<Widget>[
                       TextButton(
-                              onPressed: () => context
-                                  .read<CommentsCubit>()
-                                  .loadAll(widget.story),
+                        onPressed: () =>
+                            context.read<CommentsCubit>().loadAll(widget.story),
                         child: const Text('View all comments'),
                       ),
                       const Divider(
@@ -424,8 +427,7 @@ class _StoryScreenState extends State<StoryScreen> {
                       ),
                     ],
                     if (state.comments.isEmpty &&
-                              state.status ==
-                                  CommentsStatus.allLoaded) ...<Widget>[
+                        state.status == CommentsStatus.allLoaded) ...<Widget>[
                       const SizedBox(
                         height: 240,
                       ),
@@ -436,28 +438,9 @@ class _StoryScreenState extends State<StoryScreen> {
                         ),
                       ),
                     ],
-                        ],
-                      );
-                    } else if (index ==
-                        state.comments.length + _extraItemsCount - 1) {
-                      if ((state.status == CommentsStatus.allLoaded &&
-                              state.comments.isNotEmpty) ||
-                          state.onlyShowTargetComment) {
-                        return SizedBox(
-                          height: 240,
-                          child: Center(
-                            child: Text(happyFace),
-                          ),
-                        );
-                      }
-
-                      return const SizedBox.shrink();
-                    }
-
-                    final Comment comment = state.comments.elementAt(index - 1);
-
-                    return FadeIn(
-                      key: ValueKey<int>(comment.id),
+                    for (final Comment comment in state.comments)
+                      FadeIn(
+                        key: ValueKey<String>('${comment.id}-FadeIn'),
                         child: CommentTile(
                           comment: comment,
                           level: comment.level,
@@ -491,8 +474,17 @@ class _StoryScreenState extends State<StoryScreen> {
                           onStoryLinkTapped: onStoryLinkTapped,
                           onTimeMachineActivated: onTimeMachineActivated,
                         ),
-                    );
-                  },
+                      ),
+                    if ((state.status == CommentsStatus.allLoaded &&
+                            state.comments.isNotEmpty) ||
+                        state.onlyShowTargetComment)
+                      SizedBox(
+                        height: 240,
+                        child: Center(
+                          child: Text(happyFace),
+                        ),
+                      )
+                  ],
                 ),
               );
 
@@ -766,12 +758,82 @@ class _StoryScreenState extends State<StoryScreen> {
               final bool upvoted = voteState.vote == Vote.up;
               final bool downvoted = voteState.vote == Vote.down;
               return Container(
-                height: 300,
+                height: item is Comment ? 430 : 450,
                 color: Theme.of(context).canvasColor,
                 child: Material(
                   color: Colors.transparent,
                   child: Column(
                     children: <Widget>[
+                      BlocProvider<UserCubit>(
+                        create: (BuildContext context) =>
+                            UserCubit()..init(userId: item.by),
+                        child: BlocBuilder<UserCubit, UserState>(
+                          builder: (BuildContext context, UserState state) {
+                            return ListTile(
+                              leading: const Icon(
+                                Icons.account_circle,
+                              ),
+                              title: Text(item.by),
+                              subtitle: Text(
+                                state.user.description,
+                              ),
+                              onTap: () {
+                                showDialog<void>(
+                                  context: context,
+                                  builder: (BuildContext context) =>
+                                      SimpleDialog(
+                                    title: Text('About ${state.user.id}'),
+                                    contentPadding: const EdgeInsets.symmetric(
+                                      horizontal: 24,
+                                      vertical: 12,
+                                    ),
+                                    children: <Widget>[
+                                      SelectableLinkify(
+                                        text: HtmlUtil.parseHtml(
+                                          state.user.about,
+                                        ),
+                                        linkStyle: const TextStyle(
+                                          color: Colors.orange,
+                                        ),
+                                        onOpen: (LinkableElement link) {
+                                          if (link.url.contains(
+                                            'news.ycombinator.com/item',
+                                          )) {
+                                            onStoryLinkTapped.call(link.url);
+                                          } else {
+                                            LinkUtil.launch(link.url);
+                                          }
+                                        },
+                                      ),
+                                      ButtonBar(
+                                        children: <Widget>[
+                                          ElevatedButton(
+                                            onPressed: () =>
+                                                Navigator.pop(context),
+                                            style: ButtonStyle(
+                                              backgroundColor:
+                                                  MaterialStateProperty.all(
+                                                Colors.deepOrange,
+                                              ),
+                                            ),
+                                            child: const Text(
+                                              'Okay',
+                                              style: TextStyle(
+                                                fontWeight: FontWeight.bold,
+                                                color: Colors.white,
+                                              ),
+                                            ),
+                                          ),
+                                        ],
+                                      ),
+                                    ],
+                                  ),
+                                );
+                              },
+                            );
+                          },
+                        ),
+                      ),
                       ListTile(
                         leading: Icon(
                           FeatherIcons.chevronUp,
@@ -800,6 +862,16 @@ class _StoryScreenState extends State<StoryScreen> {
                         ),
                         onTap: context.read<VoteCubit>().downvote,
                       ),
+                      ListTile(
+                        leading: const Icon(FeatherIcons.share),
+                        title: const Text(
+                          'Share',
+                        ),
+                        onTap: () => Navigator.pop(
+                          context,
+                          _MenuAction.share,
+                        ),
+                      ),
                       ListTile(
                         leading: const Icon(Icons.local_police),
                         title: const Text(
@@ -847,6 +919,9 @@ class _StoryScreenState extends State<StoryScreen> {
             break;
           case _MenuAction.downvote:
             break;
+          case _MenuAction.share:
+            onShareTapped(item);
+            break;
           case _MenuAction.flag:
             onFlagTapped(item);
             break;
@@ -860,6 +935,9 @@ class _StoryScreenState extends State<StoryScreen> {
     });
   }
 
+  void onShareTapped(Item item) =>
+      Share.share('https://news.ycombinator.com/item?id=${item.id}');
+
   void onFlagTapped(Item item) {
     showDialog<bool>(
       context: context,

lib/screens/story/widgets/fav_icon_button.dart

@@ -25,6 +25,7 @@ class FavIconButton extends StatelessWidget {
       builder: (BuildContext context, FavState favState) {
         final bool isFav = favState.favIds.contains(storyId);
         return IconButton(
+          tooltip: 'Add to favorites',
           icon: DescribedFeatureOverlay(
             onBackgroundTap: onBackgroundTap,
             onDismiss: onDismiss,

lib/screens/story/widgets/link_icon_button.dart

@@ -21,6 +21,7 @@ class LinkIconButton extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return IconButton(
+      tooltip: 'Open this story in browser',
       icon: DescribedFeatureOverlay(
         onBackgroundTap: onBackgroundTap,
         onDismiss: onDismiss,

lib/screens/story/widgets/pin_icon_button.dart

@@ -31,6 +31,7 @@ class PinIconButton extends StatelessWidget {
           child: Transform.translate(
             offset: const Offset(2, 0),
             child: IconButton(
+              tooltip: 'Pin to home screen',
               icon: DescribedFeatureOverlay(
                 onBackgroundTap: onBackgroundTap,
                 onDismiss: onDismiss,

lib/screens/widgets/comment_tile.dart

@@ -38,6 +38,7 @@ class CommentTile extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return BlocProvider<CollapseCubit>(
+      key: ValueKey<String>('${comment.id}-BlocProvider'),
       lazy: false,
       create: (_) => CollapseCubit(
         commentId: comment.id,
@@ -209,8 +210,39 @@ class CommentTile extends StatelessWidget {
                                       top: 6,
                                       bottom: 12,
                                     ),
-                                    child: SelectableLinkify(
-                                      key: ObjectKey(comment),
+                                    child: comment is BuildableComment
+                                        ? SelectableText.rich(
+                                            key: ValueKey<int>(comment.id),
+                                            buildTextSpan(
+                                              (comment as BuildableComment)
+                                                  .elements,
+                                              style: TextStyle(
+                                                fontSize: MediaQuery.of(context)
+                                                        .textScaleFactor *
+                                                    15,
+                                              ),
+                                              linkStyle: TextStyle(
+                                                fontSize: MediaQuery.of(context)
+                                                        .textScaleFactor *
+                                                    15,
+                                                decoration:
+                                                    TextDecoration.underline,
+                                                color: Colors.orange,
+                                              ),
+                                              onOpen: (LinkableElement link) {
+                                                if (link.url.contains(
+                                                  'news.ycombinator.com/item',
+                                                )) {
+                                                  onStoryLinkTapped
+                                                      .call(link.url);
+                                                } else {
+                                                  LinkUtil.launch(link.url);
+                                                }
+                                              },
+                                            ),
+                                          )
+                                        : SelectableLinkify(
+                                            key: ValueKey<int>(comment.id),
                                             text: comment.text,
                                             style: TextStyle(
                                               fontSize: MediaQuery.of(context)
@@ -227,7 +259,8 @@ class CommentTile extends StatelessWidget {
                                               if (link.url.contains(
                                                 'news.ycombinator.com/item',
                                               )) {
-                                          onStoryLinkTapped.call(link.url);
+                                                onStoryLinkTapped
+                                                    .call(link.url);
                                               } else {
                                                 LinkUtil.launch(link.url);
                                               }

lib/screens/widgets/items_list_view.dart

@@ -87,7 +87,7 @@ class ItemsListView<T extends Item> extends StatelessWidget {
                         )
                       : null,
                   child: StoryTile(
-                    key: ObjectKey(e),
+                    key: ValueKey<int>(e.id),
                     story: e,
                     onTap: () => onTap(e),
                     showWebPreview: showWebPreview,

lib/screens/widgets/link_preview/link_preview.dart

@@ -141,7 +141,7 @@ class _LinkPreviewState extends State<LinkPreview> {
       );
     } else {
       _info = await WebAnalyzer.getInfo(
-        widget.story.id.toString(),
+        null,
         story: widget.story,
         cache: widget.cache,
       );
@@ -188,8 +188,8 @@ class _LinkPreviewState extends State<LinkPreview> {
         key: widget.key ?? Key(widget.link),
         metadata: widget.story.simpleMetadata,
         url: widget.link,
-        title: title!,
-        description: desc!,
+        title: widget.story.title,
+        description: desc ?? title ?? 'no comments yet.',
         imageUri: imageUri,
         imagePath: Constants.hackerNewsLogoPath,
         onTap: _launchURL,
@@ -228,16 +228,6 @@ class _LinkPreviewState extends State<LinkPreview> {
 
     Widget loadedWidget;
 
-    if (_info is WebImageInfo) {
-      final String img = (_info as WebImageInfo?)?.image ?? '';
-      loadedWidget = _buildLinkContainer(
-        _height,
-        title: _errorTitle,
-        desc: _errorBody,
-        imageUri:
-            widget.showMultimedia ? (img.trim() == '' ? null : img) : null,
-      );
-    } else {
     final WebInfo? info = _info as WebInfo?;
     loadedWidget = _info == null
         ? _buildLinkContainer(
@@ -261,7 +251,6 @@ class _LinkPreviewState extends State<LinkPreview> {
                 : null,
             isIcon: !WebAnalyzer.isNotEmpty(info.image),
           );
-    }
 
     return AnimatedCrossFade(
       firstChild: loadingWidget,

lib/screens/widgets/link_preview/web_analyzer.dart

@@ -5,7 +5,6 @@ import 'dart:io';
 import 'package:collection/collection.dart' show IterableExtension;
 import 'package:fast_gbk/fast_gbk.dart';
 import 'package:flutter/foundation.dart';
-import 'package:hacki/config/locator.dart';
 import 'package:hacki/extensions/extensions.dart';
 import 'package:hacki/models/models.dart';
 import 'package:hacki/repositories/repositories.dart';
@@ -16,6 +15,7 @@ import 'package:http/io_client.dart';
 
 abstract class InfoBase {
   late DateTime _timeout;
+  late bool _shouldRetry;
 
   Map<String, dynamic> toJson();
 }
@@ -114,22 +114,29 @@ class WebAnalyzer {
     bool multimedia = true,
   }) async {
     InfoBase? info = getInfoFromCache(url);
+
     if (info != null) return info;
 
     if (story.url.isEmpty && story.text.isNotEmpty) {
       info = WebInfo(
         title: story.title,
         description: story.text,
-      ).._timeout = DateTime.now().add(cache);
+      )
+        .._timeout = DateTime.now().add(cache)
+        .._shouldRetry = false;
       cacheMap[story.id.toString()] = info;
 
       return info;
     }
 
     try {
-      info = await _getInfoByIsolate(url, multimedia);
+      info = await _getInfoByIsolate(
+        url: url,
+        multimedia: multimedia,
+        story: story,
+      );
 
-      if (info != null) {
+      if (info != null && !info._shouldRetry) {
         info._timeout = DateTime.now().add(cache);
         cacheMap[url] = info;
       }
@@ -137,42 +144,6 @@ class WebAnalyzer {
       //locator.get<Logger>().log(Level.error, e);
     }
 
-    if ((info == null ||
-            info is WebImageInfo ||
-            (info is WebInfo && (info.description?.isEmpty ?? true))) &&
-        story.kids.isNotEmpty) {
-      bool shouldRetry = false;
-      final Comment? comment = await locator
-          .get<StoriesRepository>()
-          .fetchCommentBy(id: story.kids.first)
-          .catchError((Object err) async {
-        int index = 0;
-        Comment? comment;
-
-        while (comment == null && index < story.kids.length) {
-          comment = await locator
-              .get<CacheRepository>()
-              .getCachedComment(id: story.kids.elementAt(index));
-          index++;
-        }
-
-        shouldRetry = true;
-        return comment;
-      });
-
-      info = WebInfo(
-        description:
-            comment != null ? '${comment.by}: ${comment.text}' : 'no comments',
-        image: info is WebInfo ? info.image : (info as WebImageInfo?)?.image,
-        icon: info is WebInfo ? info.icon : null,
-      );
-
-      if (!shouldRetry) {
-        info._timeout = DateTime.now().add(cache);
-        cacheMap[url] = info;
-      }
-    }
-
     return info;
   }
 
@@ -195,36 +166,66 @@ class WebAnalyzer {
     return _getWebInfo(response, url, multimedia);
   }
 
-  static Future<InfoBase?> _getInfoByIsolate(
+  static Future<InfoBase?> _getInfoByIsolate({
     String? url,
-    bool multimedia,
-  ) async {
-    final List<dynamic>? res = await compute(
-      _isolate,
+    required bool multimedia,
+    required Story story,
+  }) async {
+    List<dynamic>? res;
+
+    if (url != null) {
+      res = await compute(
+        _fetchInfoFromUrl,
         <dynamic>[url, multimedia],
       );
+    }
 
+    late final bool shouldRetry;
     InfoBase? info;
+    String? fallbackDescription;
+
+    if (res == null || isEmpty(res[2] as String?)) {
+      final String? commentText = await compute(
+        _fetchInfoFromStoryId,
+        story.kids,
+      );
+
+      shouldRetry = commentText == null;
+      fallbackDescription = commentText ?? 'no comments yet';
+    } else {
+      shouldRetry = false;
+    }
+
     if (res != null) {
       if (res[0] == '0') {
         info = WebInfo(
-          title: res[1] as String?,
-          description:
-              res[2] == null ? null : (res[2] as String).removeAllEmojis(),
+          title: story.title,
+          description: isEmpty(res[2] as String?)
+              ? (fallbackDescription ??
+                  (story.text.isEmpty ? res[1] as String? : story.text))
+              : (res[2] as String).removeAllEmojis(),
           icon: res[3] as String?,
           image: res[4] as String?,
-        );
-      } else if (res[0] == '1') {
-        info = WebVideoInfo(image: res[1] as String);
-      } else if (res[0] == '2') {
-        info = WebImageInfo(image: res[1] as String);
+        ).._shouldRetry = shouldRetry;
+      } else {
+        info = WebInfo(
+          image: res[1] as String,
+          title: story.title,
+          description: story.text.isEmpty ? fallbackDescription : story.text,
+        ).._shouldRetry = shouldRetry;
       }
+    } else {
+      return WebInfo(
+        title: story.title,
+        description: fallbackDescription,
+      ).._shouldRetry = shouldRetry;
     }
 
     return info;
   }
 
-  static Future<List<dynamic>?> _isolate(dynamic message) async {
+  static Future<List<dynamic>?> _fetchInfoFromUrl(dynamic message) async {
+    try {
       // ignore: avoid_dynamic_calls
       final String url = message[0] as String;
       // ignore: avoid_dynamic_calls
@@ -247,6 +248,30 @@ class WebAnalyzer {
       } else {
         return null;
       }
+    } catch (_) {
+      return null;
+    }
+  }
+
+  static Future<String?> _fetchInfoFromStoryId(List<int> kids) async {
+    if (kids.isEmpty) return null;
+
+    final Comment? comment = await StoriesRepository()
+        .fetchCommentBy(id: kids.first)
+        .catchError((Object err) async {
+      int index = 0;
+      Comment? comment;
+
+      while (comment == null && index < kids.length) {
+        comment =
+            await CacheRepository().getCachedComment(id: kids.elementAt(index));
+        index++;
+      }
+
+      return comment;
+    });
+
+    return comment != null ? '${comment.by}: ${comment.text}' : null;
   }
 
   static bool _certificateCheck(X509Certificate cert, String host, int port) =>
@@ -275,13 +300,9 @@ class WebAnalyzer {
       ..headers['accept'] =
           'text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9';
 
+    try {
       final IOStreamedResponse stream =
-        await client.send(request).catchError((dynamic err) {
-      // locator.get<Logger>().log(
-      //       Level.error,
-      //       'Error in getting the link => ${request.url}\n$err',
-      //     );
-    });
+          await client.send(request).timeout(const Duration(seconds: 10));
 
       if (stream.statusCode == HttpStatus.movedTemporarily ||
           stream.statusCode == HttpStatus.movedPermanently) {
@@ -315,6 +336,9 @@ class WebAnalyzer {
       }
       client.close();
       return res;
+    } catch (_) {
+      return null;
+    }
   }
 
   static Future<InfoBase?> _getWebInfo(

lib/utils/link_util.dart

@@ -1,3 +1,5 @@
+import 'dart:io';
+
 import 'package:flutter/material.dart';
 import 'package:flutter_inappwebview/flutter_inappwebview.dart';
 import 'package:url_launcher/url_launcher.dart';
@@ -20,6 +22,9 @@ abstract class LinkUtil {
     canLaunchUrl(uri).then((bool val) {
       if (val) {
         if (link.contains('http')) {
+          if (Platform.isAndroid) {
+            launchUrl(uri, mode: LaunchMode.externalApplication);
+          } else {
             _browser
                 .open(
                   url: uri,
@@ -31,6 +36,7 @@ abstract class LinkUtil {
                   ),
                 )
                 .onError((_, __) => launchUrl(uri));
+          }
         } else {
           launchUrl(uri);
         }

pubspec.lock

@@ -414,6 +414,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.1.2"
+  flutter_siri_suggestions:
+    dependency: "direct main"
+    description:
+      name: flutter_siri_suggestions
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "2.1.0"
   flutter_slidable:
     dependency: "direct main"
     description:
@@ -804,6 +811,48 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "3.2.0"
+  share_plus:
+    dependency: "direct main"
+    description:
+      name: share_plus
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "4.0.8"
+  share_plus_linux:
+    dependency: transitive
+    description:
+      name: share_plus_linux
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "3.0.0"
+  share_plus_macos:
+    dependency: transitive
+    description:
+      name: share_plus_macos
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "3.0.1"
+  share_plus_platform_interface:
+    dependency: transitive
+    description:
+      name: share_plus_platform_interface
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "3.0.3"
+  share_plus_web:
+    dependency: transitive
+    description:
+      name: share_plus_web
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "3.0.1"
+  share_plus_windows:
+    dependency: transitive
+    description:
+      name: share_plus_windows
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "3.0.1"
   shared_preferences:
     dependency: "direct main"
     description:
@@ -1032,7 +1081,7 @@ packages:
       name: url_launcher
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "6.1.2"
+    version: "6.1.3"
   url_launcher_android:
     dependency: transitive
     description:

pubspec.yaml

@@ -1,6 +1,6 @@
 name: hacki
 description: A Hacker News reader.
-version: 0.2.16+55
+version: 0.2.18+57
 publish_to: none
 
 environment:
@@ -33,6 +33,7 @@ dependencies:
   flutter_linkify: ^5.0.2
   flutter_local_notifications: ^9.5.0
   flutter_secure_storage: ^5.0.2
+  flutter_siri_suggestions: ^2.1.0
   flutter_slidable: ^1.2.1
   font_awesome_flutter: ^9.2.0
   gbk_codec: ^0.4.0
@@ -56,6 +57,7 @@ dependencies:
   responsive_builder: ^0.4.2
   rxdart: ^0.27.3
   sembast: ^3.1.1+1
+  share_plus: ^4.0.8
   shared_preferences: ^2.0.11
   shared_preferences_android: ^2.0.11
   shared_preferences_ios: ^2.0.11
@@ -64,7 +66,7 @@ dependencies:
     path: components/synced_shared_preferences
   tuple: ^2.0.0
   universal_platform: ^1.0.0+1
-  url_launcher: ^6.0.10
+  url_launcher: ^6.1.3
   wakelock: ^0.6.1+2
   workmanager: ^0.5.0