flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-28 09:47:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Split AppBar Menu button into its own widget

Browse Source 
Saves us the need to the GlobalKey as well.
This commit is contained in:
Vishesh Handa
2019-12-03 22:35:23 +01:00
parent 04fa042f37
commit f86a878a9c
2 changed files with 27 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/screens/journal_listing.dart
View File

@ -1,4 +1,3 @@
import 'package:badges/badges.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:gitjournal/note.dart'; import 'package:gitjournal/note.dart';
import 'package:gitjournal/utils.dart'; import 'package:gitjournal/utils.dart';
@ -7,11 +6,11 @@ import 'package:gitjournal/screens/journal_editor.dart';
import 'package:gitjournal/screens/journal_browsing.dart'; import 'package:gitjournal/screens/journal_browsing.dart';
import 'package:gitjournal/state_container.dart'; import 'package:gitjournal/state_container.dart';
import 'package:gitjournal/widgets/app_drawer.dart'; import 'package:gitjournal/widgets/app_drawer.dart';
import 'package:gitjournal/widgets/app_bar_menu_button.dart';
import 'package:gitjournal/widgets/journal_list.dart'; import 'package:gitjournal/widgets/journal_list.dart';
import 'package:gitjournal/themes.dart'; import 'package:gitjournal/themes.dart';
class JournalListingScreen extends StatelessWidget { class JournalListingScreen extends StatelessWidget {
final GlobalKey<ScaffoldState> _scaffoldKey = GlobalKey<ScaffoldState>();
final List<Note> allNotes; final List<Note> allNotes;
JournalListingScreen(this.allNotes); JournalListingScreen(this.allNotes);
@ -19,7 +18,6 @@ class JournalListingScreen extends StatelessWidget {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
final container = StateContainer.of(context); final container = StateContainer.of(context);
final appState = container.appState;
var createButton = FloatingActionButton( var createButton = FloatingActionButton(
key: const ValueKey("FAB"), key: const ValueKey("FAB"),
@ -41,22 +39,10 @@ class JournalListingScreen extends StatelessWidget {
emptyText: "Why not add your first\n Journal Entry?", emptyText: "Why not add your first\n Journal Entry?",
); );
bool shouldShowBadge =
!appState.remoteGitRepoConfigured && appState.hasJournalEntries;
var appBarMenuButton = BadgeIconButton(
key: const ValueKey("DrawerButton"),
icon: const Icon(Icons.menu),
itemCount: shouldShowBadge ? 1 : 0,
onPressed: () {
_scaffoldKey.currentState.openDrawer();
},
);
return Scaffold( return Scaffold(
key: _scaffoldKey,
appBar: AppBar( appBar: AppBar(
title: const Text('GitJournal'), title: const Text('GitJournal'),
leading: appBarMenuButton, leading: GJAppBarMenuButton(),
actions: <Widget>[ actions: <Widget>[
IconButton( IconButton(
icon: Icon(Icons.search), icon: Icon(Icons.search),

25
lib/widgets/app_bar_menu_button.dart Normal file
View File

@ -0,0 +1,25 @@
import 'package:flutter/material.dart';
import 'package:badges/badges.dart';
import 'package:gitjournal/state_container.dart';
class GJAppBarMenuButton extends StatelessWidget {
@override
Widget build(BuildContext context) {
final container = StateContainer.of(context);
final appState = container.appState;
bool shouldShowBadge =
!appState.remoteGitRepoConfigured && appState.hasJournalEntries;
var appBarMenuButton = BadgeIconButton(
key: const ValueKey("DrawerButton"),
icon: const Icon(Icons.menu),
itemCount: shouldShowBadge ? 1 : 0,
onPressed: () {
Scaffold.of(context).openDrawer();
},
);
return appBarMenuButton;
}
}