From eb617eafa084584274720494cd76bfbd60257df8 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Sat, 16 Feb 2019 19:37:08 +0100 Subject: [PATCH] GitHostSetup: Remove unnecessary GlobalKey It's not required as we can get the Scaffold from the BuildContext. --- lib/screens/githostsetup_screens.dart | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/screens/githostsetup_screens.dart b/lib/screens/githostsetup_screens.dart index 4a7d6d57..a0dad6f4 100644 --- a/lib/screens/githostsetup_screens.dart +++ b/lib/screens/githostsetup_screens.dart @@ -48,8 +48,6 @@ class GitHostSetupScreenState extends State { var pageController = PageController(); int _currentPageIndex = 0; - final _scaffoldKey = GlobalKey(); - Widget _buildPage(BuildContext context, int pos) { print("_buildPage " + pos.toString()); assert(_pageCount >= 1); @@ -85,7 +83,7 @@ class GitHostSetupScreenState extends State { _pageCount = pos + 2; _nextPage(); - _generateSshKey(); + _generateSshKey(context); }); }, initialValue: _gitCloneUrl, @@ -136,7 +134,7 @@ class GitHostSetupScreenState extends State { _gitCloneUrl = sshUrl; _nextPage(); - _generateSshKey(); + _generateSshKey(context); }); }, launchCreateUrlPage: _launchCreateRepoPage, @@ -265,7 +263,6 @@ class GitHostSetupScreenState extends State { ); var scaffold = Scaffold( - key: _scaffoldKey, body: Container( width: double.infinity, height: double.infinity, @@ -306,19 +303,19 @@ class GitHostSetupScreenState extends State { ); } - void _generateSshKey() { + void _generateSshKey(BuildContext context) { generateSSHKeys(comment: "GitJournal").then((String publicKey) { setState(() { this.publicKey = publicKey; - _copyKeyToClipboard(); + _copyKeyToClipboard(context); }); }); } - void _copyKeyToClipboard() { + void _copyKeyToClipboard(BuildContext context) { Clipboard.setData(ClipboardData(text: publicKey)); var text = "Public Key copied to Clipboard"; - this._scaffoldKey.currentState + Scaffold.of(context) ..removeCurrentSnackBar() ..showSnackBar(SnackBar(content: Text(text))); }