flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-09-19 21:31:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove duplication of NoteTitleEditor

Browse Source
This commit is contained in:
Vishesh Handa
2020-03-30 12:00:50 +02:00
parent 5c44905772
commit e98b3c3e41
3 changed files with 29 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
lib/editors/checklist_editor.dart
View File

@ -6,6 +6,7 @@ import 'package:gitjournal/core/checklist.dart';
import 'package:gitjournal/core/note.dart'; import 'package:gitjournal/core/note.dart';
import 'package:gitjournal/editors/common.dart'; import 'package:gitjournal/editors/common.dart';
import 'package:gitjournal/editors/note_title_editor.dart';
class ChecklistEditor extends StatefulWidget implements Editor { class ChecklistEditor extends StatefulWidget implements Editor {
final Note note; final Note note;
@ -116,7 +117,7 @@ class ChecklistEditorState extends State<ChecklistEditor>
var titleEditor = Padding( var titleEditor = Padding(
padding: const EdgeInsets.fromLTRB(16.0, 16.0, 16.0, 0.0), padding: const EdgeInsets.fromLTRB(16.0, 16.0, 16.0, 0.0),
child: _NoteTitleEditor(_titleTextController), child: NoteTitleEditor(_titleTextController),
); );
return Scaffold( return Scaffold(
@ -197,30 +198,6 @@ class ChecklistEditorState extends State<ChecklistEditor>
} }
} }
class _NoteTitleEditor extends StatelessWidget {
final TextEditingController textController;
_NoteTitleEditor(this.textController);
@override
Widget build(BuildContext context) {
var style = Theme.of(context).textTheme.title;
return TextField(
keyboardType: TextInputType.text,
maxLines: 1,
style: style,
decoration: const InputDecoration(
hintText: 'Title',
border: InputBorder.none,
isDense: true,
),
controller: textController,
textCapitalization: TextCapitalization.sentences,
);
}
}
typedef TextChangedFunction = void Function(String); typedef TextChangedFunction = void Function(String);
typedef StatusChangedFunction = void Function(bool); typedef StatusChangedFunction = void Function(bool);

27
lib/editors/markdown_editor.dart
View File

@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
import 'package:gitjournal/core/note.dart'; import 'package:gitjournal/core/note.dart';
import 'package:gitjournal/editors/common.dart'; import 'package:gitjournal/editors/common.dart';
import 'package:gitjournal/editors/note_title_editor.dart';
import 'package:gitjournal/widgets/note_viewer.dart'; import 'package:gitjournal/widgets/note_viewer.dart';
class MarkdownEditor extends StatefulWidget implements Editor { class MarkdownEditor extends StatefulWidget implements Editor {
@ -66,7 +67,7 @@ class MarkdownEditorState extends State<MarkdownEditor> implements EditorState {
child: SingleChildScrollView( child: SingleChildScrollView(
child: Column( child: Column(
children: <Widget>[ children: <Widget>[
if (note.canHaveMetadata) _NoteTitleEditor(_titleTextController), if (note.canHaveMetadata) NoteTitleEditor(_titleTextController),
_NoteBodyEditor( _NoteBodyEditor(
_textController, _textController,
autofocus: widget.autofocusOnEditor, autofocus: widget.autofocusOnEditor,
@ -137,27 +138,3 @@ class _NoteBodyEditor extends StatelessWidget {
); );
} }
} }
class _NoteTitleEditor extends StatelessWidget {
final TextEditingController textController;
_NoteTitleEditor(this.textController);
@override
Widget build(BuildContext context) {
var style = Theme.of(context).textTheme.title;
return TextField(
keyboardType: TextInputType.text,
maxLines: 1,
style: style,
decoration: const InputDecoration(
hintText: 'Title',
border: InputBorder.none,
isDense: true,
),
controller: textController,
textCapitalization: TextCapitalization.sentences,
);
}
}

25
lib/editors/note_title_editor.dart Normal file
View File

@ -0,0 +1,25 @@
import 'package:flutter/material.dart';
class NoteTitleEditor extends StatelessWidget {
final TextEditingController textController;
NoteTitleEditor(this.textController);
@override
Widget build(BuildContext context) {
var style = Theme.of(context).textTheme.title;
return TextField(
keyboardType: TextInputType.text,
maxLines: 1,
style: style,
decoration: const InputDecoration(
hintText: 'Title',
border: InputBorder.none,
isDense: true,
),
controller: textController,
textCapitalization: TextCapitalization.sentences,
);
}
}