From dbf038f801ea48669bd1a2529a23c1ed0df19229 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Wed, 20 Jan 2021 20:08:30 +0100 Subject: [PATCH] Hopefully fix the strange error of _startGitClone being called In some debug reports I see logs of _startGitClone being called again and again and again. I'm not sure what is causing it. Maybe this will fix it? --- lib/setup/screens.dart | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/lib/setup/screens.dart b/lib/setup/screens.dart index 460c22fe..95257c47 100644 --- a/lib/setup/screens.dart +++ b/lib/setup/screens.dart @@ -199,6 +199,8 @@ class GitHostSetupScreenState extends State { setState(() { _pageCount = pos + 2; _nextPage(); + + gitCloneErrorMessage = ""; _startGitClone(context); }); }, @@ -225,6 +227,8 @@ class GitHostSetupScreenState extends State { this.publicKey = publicKey; _pageCount = pos + 2; _nextPage(); + + gitCloneErrorMessage = ""; _startGitClone(context); }); }, @@ -286,6 +290,8 @@ class GitHostSetupScreenState extends State { _pageCount = 6; _nextPage(); + + gitCloneErrorMessage = ""; _startGitClone(context); }); }, @@ -312,6 +318,8 @@ class GitHostSetupScreenState extends State { this.publicKey = publicKey; _pageCount = pos + 2; _nextPage(); + + gitCloneErrorMessage = ""; _startGitClone(context); }); }, @@ -512,9 +520,9 @@ class GitHostSetupScreenState extends State { } void _startGitClone(BuildContext context) async { - setState(() { - gitCloneErrorMessage = ""; - }); + if (gitCloneErrorMessage.isNotEmpty) { + return; + } var repo = Provider.of(context, listen: false); var basePath = repo.gitBaseDirectory; @@ -590,6 +598,8 @@ class GitHostSetupScreenState extends State { _pageCount += 1; _nextPage(); + + gitCloneErrorMessage = ""; _startGitClone(context); }); }