From d4463d8b6068fc1566271aea300085bc54672250 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Thu, 3 Sep 2020 08:46:59 +0200 Subject: [PATCH] TagListing: Show text when empty --- assets/langs/en.yaml | 4 ++++ lib/screens/folder_view.dart | 4 ++-- lib/screens/tag_listing.dart | 27 +++++++++++++++++++++------ 3 files changed, 27 insertions(+), 8 deletions(-) diff --git a/assets/langs/en.yaml b/assets/langs/en.yaml index 2092e107..37a18634 100644 --- a/assets/langs/en.yaml +++ b/assets/langs/en.yaml @@ -144,6 +144,7 @@ screens: empty: Please enter a name tags: title: Tags + empty: No Tags Found filesystem: ignoredFile: title: File Ignored @@ -152,6 +153,9 @@ screens: rename: decoration: File Name title: Rename + folder_view: + empty: Let's add some notes? + widgets: rename: yes: Rename diff --git a/lib/screens/folder_view.dart b/lib/screens/folder_view.dart index d6adc420..b35f12ec 100644 --- a/lib/screens/folder_view.dart +++ b/lib/screens/folder_view.dart @@ -1,5 +1,6 @@ import 'package:flutter/material.dart'; +import 'package:easy_localization/easy_localization.dart'; import 'package:git_bindings/git_bindings.dart'; import 'package:provider/provider.dart'; @@ -81,11 +82,10 @@ class _FolderViewState extends State { Widget folderView = Builder( builder: (BuildContext context) { - const emptyText = "Let's add some notes?"; return buildFolderView( viewType: _viewType, folder: sortedNotesFolder, - emptyText: emptyText, + emptyText: tr('screens.folder_view.empty'), header: _headerType, showSummary: _showSummary, noteTapped: (Note note) { diff --git a/lib/screens/tag_listing.dart b/lib/screens/tag_listing.dart index a0d4cc65..932ec757 100644 --- a/lib/screens/tag_listing.dart +++ b/lib/screens/tag_listing.dart @@ -23,11 +23,26 @@ class TagListingScreen extends StatelessWidget { var allTags = rootFolder.getNoteTagsRecursively(); var allTagsSorted = SplayTreeSet.from(allTags); - var listView = ListView( - children: [ - for (var tag in allTagsSorted) _buildTagTile(context, tag), - ], - ); + Widget body; + if (allTagsSorted.isNotEmpty) { + body = ListView( + children: [ + for (var tag in allTagsSorted) _buildTagTile(context, tag), + ], + ); + } else { + body = Center( + child: Text( + tr("screens.tags.empty"), + textAlign: TextAlign.center, + style: TextStyle( + fontSize: 28.0, + fontWeight: FontWeight.w300, + color: Colors.grey[350], + ), + ), + ); + } return Scaffold( appBar: AppBar( @@ -37,7 +52,7 @@ class TagListingScreen extends StatelessWidget { body: Scrollbar( child: ProOverlay( feature: Feature.tags, - child: listView, + child: body, ), ), drawer: AppDrawer(),