flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-28 18:03:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid saving hasJournalEntries

Browse Source 
It can be a simple getter
This commit is contained in:
Vishesh Handa
2019-10-04 04:37:41 +02:00
parent 3d8aa2ad70
commit c144f14816
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/appstate.dart
View File

@ -22,7 +22,10 @@ class AppState {
// //
/// This is the directory where all the git repos are stored /// This is the directory where all the git repos are stored
String gitBaseDirectory = ""; String gitBaseDirectory = "";
bool hasJournalEntries = false;
bool get hasJournalEntries {
return notes.isNotEmpty;
}
bool isLoadingFromDisk = false; bool isLoadingFromDisk = false;
List<Note> notes = []; List<Note> notes = [];

3
lib/state_container.dart
View File

@ -86,7 +86,6 @@ class StateContainerState extends State<StateContainer> {
setState(() { setState(() {
appState.isLoadingFromDisk = false; appState.isLoadingFromDisk = false;
appState.notes = loadedNotes; appState.notes = loadedNotes;
appState.hasJournalEntries = loadedNotes.isNotEmpty;
getAnalytics().logEvent( getAnalytics().logEvent(
name: "notes_loaded", name: "notes_loaded",
@ -125,7 +124,6 @@ class StateContainerState extends State<StateContainer> {
setState(() { setState(() {
appState.isLoadingFromDisk = false; appState.isLoadingFromDisk = false;
appState.notes = loadedNotes; appState.notes = loadedNotes;
appState.hasJournalEntries = loadedNotes.isNotEmpty;
}); });
} catch (err, stack) { } catch (err, stack) {
setState(() { setState(() {
@ -198,7 +196,6 @@ class StateContainerState extends State<StateContainer> {
note.filePath = p.join(noteRepo.notesBasePath, getFileName(note)); note.filePath = p.join(noteRepo.notesBasePath, getFileName(note));
} }
appState.notes.insert(index, note); appState.notes.insert(index, note);
appState.hasJournalEntries = true;
noteRepo.addNote(note).then((NoteRepoResult _) { noteRepo.addNote(note).then((NoteRepoResult _) {
_syncNotes(); _syncNotes();
}); });