flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-07-24 02:37:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Analytics: Allow calls to logEvent even if we haven't been initialzed

Browse Source
This commit is contained in:
Vishesh Handa
2021-08-02 16:10:23 +02:00
parent 0b7195960c
commit badd4ef1e5
4 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/analytics/analytics.dart
View File

@ -136,7 +136,7 @@ class Analytics {
return _global!; return _global!;
} }
static Analytics get instance => _global!; static Analytics? get instance => _global!;
Future<void> log({ Future<void> log({
required Event e, required Event e,
@ -168,6 +168,6 @@ class Analytics {
} }
void logEvent(Event event, {Map<String, String> parameters = const {}}) { void logEvent(Event event, {Map<String, String> parameters = const {}}) {
Analytics.instance.log(e: event, parameters: parameters); Analytics.instance?.log(e: event, parameters: parameters);
Log.d("$event", props: parameters); Log.d("$event", props: parameters);
} }

2
lib/analytics/route_observer.dart
View File

@ -16,7 +16,7 @@ class AnalyticsRouteObserver extends RouteObserver<PageRoute<dynamic>> {
} }
try { try {
await Analytics.instance.setCurrentScreen(screenName: screenName); await Analytics.instance?.setCurrentScreen(screenName: screenName);
} catch (e, stackTrace) { } catch (e, stackTrace) {
Log.e("AnalyticsRouteObserver", ex: e, stacktrace: stackTrace); Log.e("AnalyticsRouteObserver", ex: e, stacktrace: stackTrace);
} }

3
lib/app.dart
View File

@ -97,7 +97,8 @@ class JournalApp extends StatefulWidget {
)); ));
} }
static void _enableAnalyticsIfPossible(AppSettings appSettings) async { static Future<void> _enableAnalyticsIfPossible(
AppSettings appSettings) async {
JournalApp.isInDebugMode = foundation.kDebugMode; JournalApp.isInDebugMode = foundation.kDebugMode;
var isPhysicalDevice = true; var isPhysicalDevice = true;

2
lib/repository.dart
View File

@ -152,7 +152,7 @@ class GitJournalRepo with ChangeNotifier {
Log.i("Branch $_currentBranch"); Log.i("Branch $_currentBranch");
// Makes it easier to filter the analytics // Makes it easier to filter the analytics
Analytics.instance.setUserProperty( Analytics.instance?.setUserProperty(
name: 'onboarded', name: 'onboarded',
value: remoteGitRepoConfigured.toString(), value: remoteGitRepoConfigured.toString(),
); );