From b9b53f28c48427d53b585159488eb7b96d572115 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Sun, 31 May 2020 02:00:00 +0200 Subject: [PATCH] Log some exceptions are warnings These aren't really a problem, but it's still interesting to know if they are happening. --- lib/core/notes_cache.dart | 2 +- lib/error_reporting.dart | 15 +++++++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/lib/core/notes_cache.dart b/lib/core/notes_cache.dart index 83d0f5db..49dd4805 100644 --- a/lib/core/notes_cache.dart +++ b/lib/core/notes_cache.dart @@ -117,7 +117,7 @@ class NotesCache { return json.decode(contents).cast(); } catch (ex, st) { Log.e("Exception - $ex for contents: $contents"); - await logException(ex, st); + await logExceptionWarning(ex, st); return []; } } diff --git a/lib/error_reporting.dart b/lib/error_reporting.dart index bcfa3e34..7c9d2d74 100644 --- a/lib/error_reporting.dart +++ b/lib/error_reporting.dart @@ -109,6 +109,15 @@ Future logException(Exception e, StackTrace stackTrace) async { return FlutterCrashlytics().logException(e, stackTrace); } +Future logExceptionWarning(Exception e, StackTrace stackTrace) async { + if (!reportCrashes) { + return; + } + + await captureSentryException(e, stackTrace, level: SeverityLevel.warning); + return FlutterCrashlytics().logException(e, stackTrace); +} + List breadcrumbs = []; void captureErrorBreadcrumb({ @@ -121,14 +130,16 @@ void captureErrorBreadcrumb({ Future captureSentryException( Object exception, - StackTrace stackTrace, -) async { + StackTrace stackTrace, { + SeverityLevel level = SeverityLevel.error, +}) async { try { final sentry = await getSentryClient(); final Event event = Event( exception: exception, stackTrace: stackTrace, breadcrumbs: breadcrumbs, + level: level, ); return sentry.capture(event: event);