From ad2e4ac9b135f98aaddc5cca9b4074eeb4836002 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Mon, 13 May 2019 22:57:49 +0200 Subject: [PATCH] Rename markdownToPlainText -> stripMarkdownFormatting It better reflects what the function actually does --- lib/utils/markdown.dart | 2 +- lib/widgets/journal_list.dart | 2 +- ...text_test.dart => strip_markdown_formatting_test.dart} | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) rename test/{markdown_text_test.dart => strip_markdown_formatting_test.dart} (67%) diff --git a/lib/utils/markdown.dart b/lib/utils/markdown.dart index 9a525e27..124e9d3b 100644 --- a/lib/utils/markdown.dart +++ b/lib/utils/markdown.dart @@ -44,7 +44,7 @@ class MarkdownBuilder implements md.NodeVisitor { } } -String markdownToPlainText(String markdown) { +String stripMarkdownFormatting(String markdown) { final List lines = markdown.replaceAll('\r\n', '\n').split('\n'); var doc = md.Document(encodeHtml: false); diff --git a/lib/widgets/journal_list.dart b/lib/widgets/journal_list.dart index 5d501417..f9aae047 100644 --- a/lib/widgets/journal_list.dart +++ b/lib/widgets/journal_list.dart @@ -77,7 +77,7 @@ class JournalList extends StatelessWidget { title = basename(journal.filePath); } - var body = markdownToPlainText(journal.body); + var body = stripMarkdownFormatting(journal.body); var textTheme = Theme.of(context).textTheme; var children = []; diff --git a/test/markdown_text_test.dart b/test/strip_markdown_formatting_test.dart similarity index 67% rename from test/markdown_text_test.dart rename to test/strip_markdown_formatting_test.dart index d0c17852..371d2647 100644 --- a/test/markdown_text_test.dart +++ b/test/strip_markdown_formatting_test.dart @@ -2,10 +2,10 @@ import 'package:journal/utils/markdown.dart'; import 'package:test/test.dart'; void main() { - group('Markdown To Text', () { + group('Markdown Remove Formatting', () { test('Test Headers', () { var input = '# Hello\nHow are you?'; - expect(markdownToPlainText(input), 'Hello How are you?'); + expect(stripMarkdownFormatting(input), 'Hello How are you?'); }); test('Test Header2', () { @@ -15,7 +15,7 @@ void main() { Hello """; - expect(markdownToPlainText(input), 'Test Header Hello'); + expect(stripMarkdownFormatting(input), 'Test Header Hello'); }); test('Itemized LIsts', () { @@ -26,7 +26,7 @@ look like: * that one """; - expect(markdownToPlainText(input), + expect(stripMarkdownFormatting(input), 'Itemized lists look like: this one that one'); }); });