DartLinter: Add prefer_collection_literals

analysis_options.yaml

@@ -81,7 +81,7 @@ linter:
     - package_prefixed_library_names
     # - parameter_assignments # we do this commonly
     - prefer_adjacent_string_concatenation
-    # - prefer_collection_literals
+    - prefer_collection_literals
     # - prefer_conditional_assignment # not yet tested
     # - prefer_const_constructors
     # - prefer_constructors_over_static_methods # not yet tested

lib/apis/github.dart

@@ -93,7 +93,7 @@ class GitHub implements GitHost {
     }
 
     List<dynamic> list = jsonDecode(response.body);
-    var repos = List<GitRepo>();
+    var repos = <GitRepo>[];
     list.forEach((dynamic d) {
       var map = Map<String, dynamic>.from(d);
       var repo = _repoFromJson(map);

lib/apis/gitlab.dart

@@ -82,7 +82,7 @@ class GitLab implements GitHost {
     }
 
     List<dynamic> list = jsonDecode(response.body);
-    var repos = List<GitRepo>();
+    var repos = <GitRepo>[];
     list.forEach((dynamic d) {
       var map = Map<String, dynamic>.from(d);
       var repo = _repoFromJson(map);

lib/note.dart

@@ -5,14 +5,14 @@ class Note implements Comparable<Note> {
   DateTime created;
   String body;
 
-  Map<String, dynamic> extraProperties = Map<String, dynamic>();
+  Map<String, dynamic> extraProperties = <String, dynamic>{};
 
   Note({this.created, this.body, this.filePath, this.extraProperties}) {
     if (created == null) {
       created = DateTime(0, 0, 0, 0, 0, 0, 0, 0);
     }
     if (extraProperties == null) {
-      extraProperties = Map<String, dynamic>();
+      extraProperties = <String, dynamic>{};
     }
   }
 

lib/storage/file_storage.dart

@@ -28,7 +28,7 @@ class FileStorage implements NoteRepository {
   Future<List<Note>> listNotes() async {
     final dir = Directory(baseDirectory);
 
-    var notes = List<Note>();
+    var notes = <Note>[];
     var lister = dir.list(recursive: false);
     await for (var fileEntity in lister) {
       Note note = await _loadNote(fileEntity);

lib/storage/serializers.dart

@@ -28,7 +28,7 @@ class MarkdownYAMLSerializer implements NoteSerializer {
       var parts = str.split("---\n");
 
       var yamlMap = loadYaml(parts[1]);
-      var map = Map<String, dynamic>();
+      var map = <String, dynamic>{};
       yamlMap.forEach((key, value) {
         map[key] = value;
       });
@@ -37,7 +37,7 @@ class MarkdownYAMLSerializer implements NoteSerializer {
       return Note.fromJson(map);
     }
 
-    var map = Map<String, dynamic>();
+    var map = <String, dynamic>{};
     map['body'] = str;
     return Note.fromJson(map);
   }