flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-30 11:33:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Catch possible exceptions when creating the fileName

Browse Source 
This can apparently happen, and we should have a fallback. Additionally
Dart has both an 'Error' and an 'Exception' which are two different
things. This makes no sense.
This commit is contained in:
Vishesh Handa
2020-06-09 18:09:17 +02:00
parent 9cb810f41d
commit 9ba0bc831c
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/core/note.dart
View File

@ -75,7 +75,13 @@ class Note with NotesNotifier {
String get filePath { String get filePath {
if (_filePath == null) { if (_filePath == null) {
_filePath = p.join(parent.folderPath, _buildFileName()); try {
_filePath = p.join(parent.folderPath, _buildFileName());
} catch (e, stackTrace) {
Log.e("_buildFileName: $e");
logExceptionWarning(e, stackTrace);
_filePath = p.join(parent.folderPath, Uuid().v4());
}
switch (_fileFormat) { switch (_fileFormat) {
case NoteFileFormat.Txt: case NoteFileFormat.Txt:
if (!_filePath.toLowerCase().endsWith('.txt')) { if (!_filePath.toLowerCase().endsWith('.txt')) {

8
lib/error_reporting.dart
View File

@ -100,7 +100,10 @@ Future<void> reportError(Object error, StackTrace stackTrace) async {
print(stackTrace); print(stackTrace);
} }
Future<void> logException(Exception e, StackTrace stackTrace) async { // Dart makes a distiction between Errors and Exceptions
// so we need to use dynamic
Future<void> logException(Object e, StackTrace stackTrace) async {
assert(e is Exception || e is Error);
if (!reportCrashes) { if (!reportCrashes) {
return; return;
} }
@ -109,7 +112,8 @@ Future<void> logException(Exception e, StackTrace stackTrace) async {
return FlutterCrashlytics().logException(e, stackTrace); return FlutterCrashlytics().logException(e, stackTrace);
} }
Future<void> logExceptionWarning(Exception e, StackTrace stackTrace) async { Future<void> logExceptionWarning(Object e, StackTrace stackTrace) async {
assert(e is Exception || e is Error);
if (!reportCrashes) { if (!reportCrashes) {
return; return;
} }