flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-30 03:19:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

GitHostSetup: Reduce code duplication

Browse Source 
Make the ErrorPage into its own widget, instead of duplicating the code.
This commit is contained in:
Vishesh Handa
2019-02-14 10:13:46 +01:00
parent c819f49afe
commit 994b6f2ccd
3 changed files with 39 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
lib/screens/githostsetup_autoconfigure.dart
View File

@ -3,6 +3,7 @@ import 'package:journal/apis/git.dart';
import 'package:journal/apis/githost_factory.dart'; import 'package:journal/apis/githost_factory.dart';
import 'package:journal/settings.dart'; import 'package:journal/settings.dart';
import 'githostsetup_error.dart';
import 'githostsetup_loading.dart'; import 'githostsetup_loading.dart';
class GitHostSetupAutoConfigure extends StatefulWidget { class GitHostSetupAutoConfigure extends StatefulWidget {
@ -76,29 +77,6 @@ class GitHostSetupAutoConfigureState extends State<GitHostSetupAutoConfigure> {
return GitHostSetupLoadingPage("Configuring ..."); return GitHostSetupLoadingPage("Configuring ...");
} }
var children = <Widget>[ return GitHostSetupErrorPage(errorMessage);
Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
'Failed',
textAlign: TextAlign.center,
style: Theme.of(context).textTheme.display1,
),
),
Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
this.errorMessage,
textAlign: TextAlign.center,
style: Theme.of(context).textTheme.display1,
),
),
];
return Column(
mainAxisAlignment: MainAxisAlignment.center,
crossAxisAlignment: CrossAxisAlignment.center,
children: children,
);
} }
} }

26
lib/screens/githostsetup_clone.dart
View File

@ -1,5 +1,6 @@
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'githostsetup_error.dart';
import 'githostsetup_loading.dart'; import 'githostsetup_loading.dart';
class GitHostSetupGitClone extends StatelessWidget { class GitHostSetupGitClone extends StatelessWidget {
@ -15,29 +16,6 @@ class GitHostSetupGitClone extends StatelessWidget {
return GitHostSetupLoadingPage("Cloning ..."); return GitHostSetupLoadingPage("Cloning ...");
} }
var children = <Widget>[ return GitHostSetupErrorPage(errorMessage);
Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
'Failed',
textAlign: TextAlign.center,
style: Theme.of(context).textTheme.display1,
),
),
Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
this.errorMessage,
textAlign: TextAlign.center,
style: Theme.of(context).textTheme.display1,
),
),
];
return Column(
mainAxisAlignment: MainAxisAlignment.center,
crossAxisAlignment: CrossAxisAlignment.center,
children: children,
);
} }
} }

35
lib/screens/githostsetup_error.dart Normal file
View File

@ -0,0 +1,35 @@
import 'package:flutter/material.dart';
class GitHostSetupErrorPage extends StatelessWidget {
final String errorMessage;
GitHostSetupErrorPage(this.errorMessage);
@override
Widget build(BuildContext context) {
var children = <Widget>[
Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
'Failed',
textAlign: TextAlign.center,
style: Theme.of(context).textTheme.display1,
),
),
Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
errorMessage,
textAlign: TextAlign.center,
style: Theme.of(context).textTheme.display1,
),
),
];
return Column(
mainAxisAlignment: MainAxisAlignment.center,
crossAxisAlignment: CrossAxisAlignment.center,
children: children,
);
}
}