flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-29 10:17:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[Feat] add date to trailing widget in journal listing"

Browse Source 
This reverts commit 8f76b4d96089c4a9313a7bf15d40278afee9a6e0.

I want to make another release and this substantially changes the
existing behaviour - I thought it would be fine, but it's proving to be
challenging.

Problems -
* Many notes do not have a title and the fileName is just too ugly to
show to the user when it is an ISO8601 timestamp.
This commit is contained in:
Vishesh Handa
2020-02-09 19:13:46 +01:00
parent 7fd2546334
commit 9290d9421e
1 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
lib/widgets/journal_list.dart
View File

@ -143,16 +143,30 @@ class _JournalListState extends State<JournalList> {
Widget _buildRow(BuildContext context, Note note) { Widget _buildRow(BuildContext context, Note note) {
var textTheme = Theme.of(context).textTheme; var textTheme = Theme.of(context).textTheme;
var title = note.title;
var title = note.title ?? note.fileName;
Widget titleWidget = Text(title, style: textTheme.title); Widget titleWidget = Text(title, style: textTheme.title);
Widget trailing; if (title.isEmpty) {
var date = note.modified ?? note.created; var date = note.modified ?? note.created;
if (date != null) { if (date != null) {
var formatter = DateFormat('dd MMM, yyyy'); var formatter = DateFormat('dd MMM, yyyy ');
var dateStr = formatter.format(date); var dateStr = formatter.format(date);
trailing = Text(dateStr, style: textTheme.caption);
var timeFormatter = DateFormat('Hm');
var time = timeFormatter.format(date);
var timeColor = textTheme.body1.color.withAlpha(100);
titleWidget = Row(
children: <Widget>[
Text(dateStr, style: textTheme.title),
Text(time, style: textTheme.body1.copyWith(color: timeColor)),
],
crossAxisAlignment: CrossAxisAlignment.baseline,
textBaseline: TextBaseline.alphabetic,
);
} else {
titleWidget = Text(note.fileName, style: textTheme.title);
}
} }
var body = stripMarkdownFormatting(note.body); var body = stripMarkdownFormatting(note.body);
@ -170,7 +184,6 @@ class _JournalListState extends State<JournalList> {
var tile = ListTile( var tile = ListTile(
isThreeLine: true, isThreeLine: true,
title: titleWidget, title: titleWidget,
trailing: trailing,
subtitle: Column( subtitle: Column(
children: children, children: children,
crossAxisAlignment: CrossAxisAlignment.start, crossAxisAlignment: CrossAxisAlignment.start,