From 8b8bcc70a309f78ec54a2d09abbba0f0828c296b Mon Sep 17 00:00:00 2001
From: Vishesh Handa <me@vhanda.in>
Date: Sun, 2 Jun 2019 15:23:01 +0200
Subject: [PATCH] Android Bridge: Never send a response twice

Sometimes after responding with an error we would not stop, and also
return with a sucess after.
---
 .../src/main/java/io/gitjournal/gitjournal/MainActivity.java  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/android/app/src/main/java/io/gitjournal/gitjournal/MainActivity.java b/android/app/src/main/java/io/gitjournal/gitjournal/MainActivity.java
index 93570427..f5adac94 100644
--- a/android/app/src/main/java/io/gitjournal/gitjournal/MainActivity.java
+++ b/android/app/src/main/java/io/gitjournal/gitjournal/MainActivity.java
@@ -199,6 +199,7 @@ public class MainActivity extends FlutterActivity implements MethodCallHandler {
             } catch (IOException ex) {
                 Log.d("getSSHPublicKey", ex.toString());
                 result.error("FAILED", "Failed to read the public key", null);
+                return;
             }
 
             result.success(publicKey);
@@ -223,6 +224,7 @@ public class MainActivity extends FlutterActivity implements MethodCallHandler {
             } catch (IOException ex) {
                 Log.d("setSshKeys", ex.toString());
                 result.error("FAILED", "Failed to write the ssh keys", null);
+                return;
             }
 
             result.success(publicKey);
@@ -235,9 +237,11 @@ public class MainActivity extends FlutterActivity implements MethodCallHandler {
             } catch (Exception e) {
                 e.printStackTrace();
                 result.error("FAILED", e.toString(), null);
+                return;
             }
 
             result.success(filePath);
+            return;
         }
 
         result.notImplemented();