From 8a00fd1df634d4702d5f6072ffe4bf01f6a47e31 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Wed, 10 Jun 2020 13:18:12 +0200 Subject: [PATCH] ErrorReporting: Log the exceptions Not only to Sentry, also to the log, so it appears when we look at the logs. --- lib/error_reporting.dart | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/error_reporting.dart b/lib/error_reporting.dart index 48e6ebc5..c8101c76 100644 --- a/lib/error_reporting.dart +++ b/lib/error_reporting.dart @@ -6,6 +6,7 @@ import 'package:flutter/foundation.dart'; import 'package:flutter_crashlytics/flutter_crashlytics.dart'; import 'package:gitjournal/app.dart'; import 'package:gitjournal/settings.dart'; +import 'package:gitjournal/utils/logger.dart'; import 'package:package_info/package_info.dart'; import 'package:sentry/sentry.dart'; @@ -104,6 +105,8 @@ Future reportError(Object error, StackTrace stackTrace) async { // so we need to use dynamic Future logException(Object e, StackTrace stackTrace) async { assert(e is Exception || e is Error); + Log.e("Got Exception", ex: e, stacktrace: stackTrace); + if (!reportCrashes) { return; } @@ -114,6 +117,8 @@ Future logException(Object e, StackTrace stackTrace) async { Future logExceptionWarning(Object e, StackTrace stackTrace) async { assert(e is Exception || e is Error); + Log.e("Got Exception", ex: e, stacktrace: stackTrace); + if (!reportCrashes) { return; }