Revert "Workaround intl bug by harding 'en' locale"

This reverts commit 303192d9d575b26a77a00f7a62212f310ec1e329.
This reverts commit cd9d128b47ed523036f7ae1232ec7adcf04ed8a9.

GitJournal is used by non-English speakers (a lot in China and Russia)
and while we don't support those languages completely, we do support
them a little bit. I don't want to loose this functionality. It would be
better for us to fix the bug in intl.

lib/folder_views/journal_view.dart

@@ -13,8 +13,8 @@ class JournalView extends StatelessWidget {
   final NotesFolder folder;
   final String emptyText;
 
-  static final _dateFormat = DateFormat('dd MMM, yyyy  ', 'en');
+  static final _dateFormat = DateFormat('dd MMM, yyyy  ');
-  static final _timeFormat = DateFormat('Hm', 'en');
+  static final _timeFormat = DateFormat('Hm');
 
   JournalView({
     @required this.folder,

lib/folder_views/standard_view.dart

@@ -22,7 +22,7 @@ class StandardView extends StatelessWidget {
   final StandardViewHeader headerType;
   final bool showSummary;
 
-  static final _dateFormat = DateFormat('dd MMM, yyyy', 'en');
+  static final _dateFormat = DateFormat('dd MMM, yyyy');
 
   StandardView({
     @required this.folder,

lib/setup/repo_selector.dart

@@ -189,7 +189,7 @@ class GitHostSetupRepoSelectorState extends State<GitHostSetupRepoSelector> {
   }
 
   Widget _buildRepoTile(GitHostRepo repo) {
-    final _dateFormat = DateFormat('dd MMM, yyyy', 'en');
+    final _dateFormat = DateFormat('dd MMM, yyyy');
 
     Widget trailing = Container();
     if (repo.updatedAt != null) {

lib/utils/datetime.dart

@@ -2,8 +2,8 @@ import 'dart:core';
 import 'package:gitjournal/utils/logger.dart';
 import 'package:intl/intl.dart';
 
-final _simpleDateFormat = DateFormat("yyyy-MM-dd-HH-mm-ss", 'en');
+final _simpleDateFormat = DateFormat("yyyy-MM-dd-HH-mm-ss");
-final _iso8601DateFormat = DateFormat("yyyy-MM-ddTHH:mm:ss", 'en');
+final _iso8601DateFormat = DateFormat("yyyy-MM-ddTHH:mm:ss");
 
 String toSimpleDateTime(DateTime dt) {
   return _simpleDateFormat.format(dt);

lib/widgets/journal_editor_header.dart

@@ -12,8 +12,8 @@ class JournalEditorHeader extends StatelessWidget {
     if (note.created == null) {
       return Container();
     }
-    var dateStr = DateFormat('MMMM, yyyy', 'en').format(note.created);
+    var dateStr = DateFormat('MMMM, yyyy').format(note.created);
-    var timeStr = DateFormat('EEEE HH:mm', 'en').format(note.created);
+    var timeStr = DateFormat('EEEE HH:mm').format(note.created);
 
     var bigNum = Text(
       note.created.day.toString(),

test/datetime_utils_test.dart

@@ -1,11 +1,8 @@
 import 'package:gitjournal/utils/datetime.dart';
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
   group('DateTime Utils', () {
-    initializeDateFormatting('en');
-
     test('Test random date', () {
       var dateTime = DateTime.utc(2011, 12, 23, 10, 15, 30);
       var str = toIso8601WithTimezone(dateTime);

test/flattened_notes_folder_large_test.dart

@@ -6,12 +6,9 @@ import 'package:gitjournal/core/notes_folder_fs.dart';
 import 'package:gitjournal/core/note.dart';
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
   group('Flattened Notes Folder Large Test', () {
-    initializeDateFormatting('en');
-
     Directory tempDir;
     NotesFolderFS rootFolder;
 

test/flattened_notes_folder_test.dart

@@ -6,12 +6,9 @@ import 'package:gitjournal/core/notes_folder_fs.dart';
 import 'package:gitjournal/core/note.dart';
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
   group('Flattened Notes Folder Test', () {
-    initializeDateFormatting('en');
-
     Directory tempDir;
     NotesFolderFS rootFolder;
 

test/md_yaml_codec_test.dart

@@ -4,7 +4,6 @@ import 'package:gitjournal/core/md_yaml_doc.dart';
 import 'package:gitjournal/core/md_yaml_doc_codec.dart';
 import 'package:gitjournal/utils/datetime.dart';
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 DateTime nowWithoutMicro() {
   var dt = DateTime.now();
@@ -13,8 +12,6 @@ DateTime nowWithoutMicro() {
 
 void main() {
   group('Serializers', () {
-    initializeDateFormatting('en');
-
     test('Markdown Serializer', () {
       var created = toIso8601WithTimezone(nowWithoutMicro());
       var note = MdYamlDoc(

test/md_yaml_doc_loader_test.dart

@@ -3,12 +3,9 @@ import 'dart:io';
 import 'package:gitjournal/core/md_yaml_doc_loader.dart';
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
   group('MdYamlDocLoader', () {
-    initializeDateFormatting('en');
-
     Directory tempDir;
     String filePath;
     var contents = """---

test/md_yaml_doc_test.dart

@@ -2,11 +2,8 @@ import 'dart:collection';
 
 import 'package:gitjournal/core/md_yaml_doc.dart';
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
-  initializeDateFormatting('en');
-
   test('Equality', () {
     // ignore: prefer_collection_literals
     var aProps = LinkedHashMap<String, dynamic>();

test/note_storage_test.dart

@@ -6,12 +6,9 @@ import 'package:gitjournal/core/note.dart';
 import 'package:gitjournal/core/md_yaml_doc.dart';
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
   group('NoteStorage', () {
-    initializeDateFormatting('en');
-
     var notes = <Note>[];
     String n1Path;
     String n2Path;

test/note_test.dart

@@ -4,12 +4,9 @@ import 'package:gitjournal/core/note.dart';
 import 'package:gitjournal/core/notes_folder_fs.dart';
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
   group('Note', () {
-    initializeDateFormatting('en');
-
     Directory tempDir;
 
     setUpAll(() async {

test/sorted_notes_folder_test.dart

@@ -7,12 +7,9 @@ import 'package:gitjournal/core/sorting_mode.dart';
 import 'package:gitjournal/core/note.dart';
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
   group('Sorted Notes Folder Test', () {
-    initializeDateFormatting('en');
-
     Directory tempDir;
     NotesFolderFS folder;
 

test/sorting_mode_test.dart

@@ -2,12 +2,9 @@ import 'package:gitjournal/core/note.dart';
 import 'package:gitjournal/core/notes_folder_fs.dart';
 import 'package:gitjournal/core/sorting_mode.dart';
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
   group('Sorting Mode', () {
-    initializeDateFormatting('en');
-
     test('Created', () async {
       var folder = NotesFolderFS(null, '/tmp/');
       var n1 = Note(folder, '/tmp/1.md');

test/strip_markdown_formatting_test.dart

@@ -1,11 +1,8 @@
 import 'package:gitjournal/utils/markdown.dart';
 import 'package:test/test.dart';
-import 'package:intl/date_symbol_data_local.dart';
 
 void main() {
   group('Markdown Remove Formatting', () {
-    initializeDateFormatting('en');
-
     test('Test Headers', () {
       var input = '# Hello\nHow are you?';
       expect(stripMarkdownFormatting(input), 'Hello How are you? ');