From 83a0da908282a6254c2ad8e6b8cc2e412ccf1bd1 Mon Sep 17 00:00:00 2001
From: Vishesh Handa <me@vhanda.in>
Date: Thu, 10 Oct 2019 13:37:36 +0200
Subject: [PATCH] gj_common: Use cppcheck to catch potential errors

---
 gj_common/Dockerfile | 1 +
 gj_common/Makefile   | 3 +++
 gj_common/keygen.c   | 2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gj_common/Dockerfile b/gj_common/Dockerfile
index 416e63ff..742c8f5a 100644
--- a/gj_common/Dockerfile
+++ b/gj_common/Dockerfile
@@ -4,3 +4,4 @@ RUN apk update
 RUN apk add clang libgit2-dev
 RUN apk add bash make libc-dev g++ vim gdb
 RUN apk add musl-dbg git
+RUN apk add curl cppcheck
diff --git a/gj_common/Makefile b/gj_common/Makefile
index b9e82d90..2a58f1b1 100644
--- a/gj_common/Makefile
+++ b/gj_common/Makefile
@@ -8,3 +8,6 @@ build-env: Dockerfile
 
 shell:
 	docker run --rm -it -v `pwd`:/code -w /code gitjournal_lib bash
+
+cppcheck:
+	cppcheck --enable=all --suppress=unusedFunction common.c gitjournal.c keygen.c
diff --git a/gj_common/keygen.c b/gj_common/keygen.c
index a86703f7..09fc4aeb 100644
--- a/gj_common/keygen.c
+++ b/gj_common/keygen.c
@@ -79,7 +79,7 @@ int write_rsa_public_key(RSA *pRsa, const char *file_path, const char *comment)
    memcpy(pEncoding, pSshHeader, 11);
 
    index = SshEncodeBuffer(&pEncoding[11], eLen, eBytes);
-   index = SshEncodeBuffer(&pEncoding[11 + index], nLen, nBytes);
+   SshEncodeBuffer(&pEncoding[11 + index], nLen, nBytes);
 
    b64 = BIO_new(BIO_f_base64());
    BIO_set_flags(b64, BIO_FLAGS_BASE64_NO_NL);