flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-09-14 15:33:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

JournalList: Replace ListView.seperated with ListView.builder

Browse Source 
I wanted to stop using .seperated as it shows some ugly artifacts when
used with IconDismissable when removing an item, and it makes it more
difficult to replace it with an AnimatedListView
This commit is contained in:
Vishesh Handa
2020-01-31 23:07:17 +01:00
parent 8761f96bbe
commit 82aeb01ba9
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lib/widgets/journal_list.dart
View File

@ -36,10 +36,7 @@ class JournalList extends StatelessWidget {
); );
} }
return ListView.separated( return ListView.builder(
separatorBuilder: (context, index) {
return const Divider();
},
itemBuilder: (context, i) { itemBuilder: (context, i) {
if (i >= notes.length) { if (i >= notes.length) {
return null; return null;
@ -123,9 +120,21 @@ class JournalList extends StatelessWidget {
onTap: () => noteSelectedFunction(noteIndex), onTap: () => noteSelectedFunction(noteIndex),
); );
return Padding( var dc = Theme.of(context).dividerColor;
padding: const EdgeInsets.only(top: 8.0, bottom: 8.0), var divider = Container(
height: 1.0,
child: Divider(color: dc.withOpacity(dc.opacity / 3)),
);
return Column(
children: <Widget>[
divider,
Padding(
padding: const EdgeInsets.only(top: 16.0, bottom: 16.0),
child: tile, child: tile,
),
divider,
],
); );
} }