From 81eb605e98c65648bec298b507ac85a145abf028 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Wed, 6 May 2020 14:27:49 +0200 Subject: [PATCH] MarkdownViewer: Use EditorScrollView This way we don't show that annoying animation, and we now occupy the entire available width. Otheriwse if you had text which was required scrolling, but only had 1 word in each line, then you couldn't scroll by dragging on the empty area as the widget didn't occupy that space. --- lib/widgets/editor_scroll_view.dart | 1 + lib/widgets/note_viewer.dart | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/widgets/editor_scroll_view.dart b/lib/widgets/editor_scroll_view.dart index ddb2a9d4..6d9668e0 100644 --- a/lib/widgets/editor_scroll_view.dart +++ b/lib/widgets/editor_scroll_view.dart @@ -27,6 +27,7 @@ class EditorScrollView extends StatelessWidget { child: ConstrainedBox( constraints: BoxConstraints( minHeight: constraints.maxHeight, + minWidth: constraints.maxWidth, ), child: child, ), diff --git a/lib/widgets/note_viewer.dart b/lib/widgets/note_viewer.dart index 77ce79ae..2c06a651 100644 --- a/lib/widgets/note_viewer.dart +++ b/lib/widgets/note_viewer.dart @@ -6,6 +6,7 @@ import 'package:flutter/material.dart'; import 'package:flutter_markdown/flutter_markdown.dart'; import 'package:gitjournal/folder_views/common.dart'; import 'package:gitjournal/utils.dart'; +import 'package:gitjournal/widgets/editor_scroll_view.dart'; import 'package:provider/provider.dart'; import 'package:url_launcher/url_launcher.dart'; import 'package:path/path.dart' as p; @@ -46,7 +47,7 @@ class NoteViewer extends StatelessWidget { ), ); - var view = SingleChildScrollView( + var view = EditorScrollView( child: Column( children: [ if (note.canHaveMetadata) NoteTitleHeader(note.title), @@ -78,7 +79,6 @@ class NoteViewer extends StatelessWidget { ], crossAxisAlignment: CrossAxisAlignment.start, ), - padding: const EdgeInsets.all(16.0), ); return view;