From 7ff61d2f414c7ccddd04b08ca46d79fa24e479bd Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Wed, 25 Aug 2021 11:17:21 +0200 Subject: [PATCH] Disable dart-code-metrics for now Even though I'm not using v4.2, the return-value rule is still being applied with `flutter analyze` though not consistently. For now, lets disable this, as there are 300+ warnings to fix. --- analysis_options.yaml | 5 ++--- lib/analytics/analytics.dart | 2 +- lib/analytics/config.dart | 2 +- lib/analytics/network.dart | 2 +- lib/analytics/storage.dart | 5 ++++- lib/core/worker_queue.dart | 2 +- lib/editors/bottom_bar.dart | 4 ++-- lib/error_reporting.dart | 3 ++- lib/folder_views/common.dart | 3 ++- lib/folder_views/folder_view.dart | 2 +- lib/iap/purchase_manager.dart | 2 +- 11 files changed, 18 insertions(+), 14 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index da9a44db..b2606db2 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -17,8 +17,8 @@ analyzer: - "lib/generated_plugin_registrant.dart" enable-experiment: - nonfunction-type-aliases - plugins: - - dart_code_metrics + # plugins: + # - dart_code_metrics linter: rules: @@ -149,4 +149,3 @@ dart_code_metrics: # - no-magic-number # - no-object-declaration # - prefer-conditional-expressions - diff --git a/lib/analytics/analytics.dart b/lib/analytics/analytics.dart index ef87f273..3d73ad98 100644 --- a/lib/analytics/analytics.dart +++ b/lib/analytics/analytics.dart @@ -49,7 +49,7 @@ class Analytics { var pseudoId = pref.getString("pseudoId"); if (pseudoId == null) { pseudoId = const Uuid().v4(); - pref.setString("pseudoId", pseudoId); + var _ = pref.setString("pseudoId", pseudoId); } var config = AnalyticsConfig("", pref); diff --git a/lib/analytics/config.dart b/lib/analytics/config.dart index e80b850c..82bb36b0 100644 --- a/lib/analytics/config.dart +++ b/lib/analytics/config.dart @@ -26,6 +26,6 @@ class AnalyticsConfig extends ChangeNotifier with SettingsSharedPref { var def = AnalyticsConfig(id, pref); await setBool("collectUsageStatistics", enabled, def.enabled); - await pref.setString("appVersion", appVersion); + var _ = await pref.setString("appVersion", appVersion); } } diff --git a/lib/analytics/network.dart b/lib/analytics/network.dart index 3d982b4e..b9900d05 100644 --- a/lib/analytics/network.dart +++ b/lib/analytics/network.dart @@ -28,7 +28,7 @@ Future> sendAnalytics(pb.AnalyticsMessage msg) async { msg, options: CallOptions(timeout: _timeout), ); - await call; + var _ = await call; } on Exception catch (e, st) { await channel.shutdown(); return Result.fail(e, st); diff --git a/lib/analytics/storage.dart b/lib/analytics/storage.dart index 59c2b2e2..d1e9d784 100644 --- a/lib/analytics/storage.dart +++ b/lib/analytics/storage.dart @@ -46,7 +46,10 @@ class AnalyticsStorage { builder.add(intData.buffer.asUint8List()); builder.add(eventData); - await File(filePath).writeAsBytes(builder.toBytes(), mode: FileMode.append); + var _ = await File(filePath).writeAsBytes( + builder.toBytes(), + mode: FileMode.append, + ); numEventsThisSession++; } diff --git a/lib/core/worker_queue.dart b/lib/core/worker_queue.dart index 724a6a96..311c3605 100644 --- a/lib/core/worker_queue.dart +++ b/lib/core/worker_queue.dart @@ -70,7 +70,7 @@ void _isolateMain(SendPort toMainSender) { ReceivePort fromMainRec = ReceivePort(); toMainSender.send(fromMainRec.sendPort); - fromMainRec.listen((data) async { + var _ = fromMainRec.listen((data) async { assert(data is _LoadingMessage); var msg = data as _LoadingMessage; diff --git a/lib/editors/bottom_bar.dart b/lib/editors/bottom_bar.dart index 1b1f71f1..8eec5e6a 100644 --- a/lib/editors/bottom_bar.dart +++ b/lib/editors/bottom_bar.dart @@ -47,7 +47,7 @@ class EditorBottomBar extends StatelessWidget { var addIcon = IconButton( icon: const Icon(Icons.attach_file), onPressed: () { - showModalBottomSheet( + var _ = showModalBottomSheet( context: context, builder: (c) => AddBottomSheet(editor, editorState), elevation: 0, @@ -58,7 +58,7 @@ class EditorBottomBar extends StatelessWidget { var menuIcon = IconButton( icon: const Icon(Icons.more_vert), onPressed: () { - showModalBottomSheet( + var _ = showModalBottomSheet( context: context, builder: (c) => BottomMenuSheet( editor: editor, diff --git a/lib/error_reporting.dart b/lib/error_reporting.dart index b756f5bb..6b55eb1d 100644 --- a/lib/error_reporting.dart +++ b/lib/error_reporting.dart @@ -145,7 +145,8 @@ Future captureSentryException( level: level, ); - await Sentry.captureEvent(event, stackTrace: Trace.from(stackTrace).terse); + var _ = await Sentry.captureEvent(event, + stackTrace: Trace.from(stackTrace).terse); return; } catch (e) { print("Failed to report with Sentry: $e"); diff --git a/lib/folder_views/common.dart b/lib/folder_views/common.dart index c5c0ac72..b382277a 100644 --- a/lib/folder_views/common.dart +++ b/lib/folder_views/common.dart @@ -123,6 +123,7 @@ bool openNewNoteEditor(BuildContext context, String term) { ), settings: const RouteSettings(name: '/newNote/'), ); - Navigator.of(context).push(route); + + var _ = Navigator.of(context).push(route); return true; } diff --git a/lib/folder_views/folder_view.dart b/lib/folder_views/folder_view.dart index 09918637..b0d0cb22 100644 --- a/lib/folder_views/folder_view.dart +++ b/lib/folder_views/folder_view.dart @@ -239,7 +239,7 @@ class _FolderViewState extends State { ), settings: RouteSettings(name: '/newNote/$routeType'), ); - await Navigator.of(context).push(route); + var _ = await Navigator.of(context).push(route); ScaffoldMessenger.of(context).removeCurrentSnackBar(); } diff --git a/lib/iap/purchase_manager.dart b/lib/iap/purchase_manager.dart index 7d0a45f4..706b1b73 100644 --- a/lib/iap/purchase_manager.dart +++ b/lib/iap/purchase_manager.dart @@ -86,7 +86,7 @@ class PurchaseManager { Log.i("Pending Complete Purchase - ${purchaseDetails.productID}"); try { - await InAppPurchaseConnection.instance + var _ = await InAppPurchaseConnection.instance .completePurchase(purchaseDetails); } catch (e, stackTrace) { logException(e, stackTrace);