Analytics: Make all events into enums

No more random strings

lib/analytics.dart

@@ -33,6 +33,15 @@ enum Event {
   DrawerSettings,
 
   PurchaseScreenOpen,
+  PurchaseScreenClose,
+  PurchaseScreenThankYou,
+
+  GitHostSetupError,
+  GitHostSetupComplete,
+  GitHostSetupGitCloneError,
+  GitHostSetupButtonClick,
+
+  Settings,
 }
 
 String _eventToString(Event e) {
@@ -80,6 +89,22 @@ String _eventToString(Event e) {
 
     case Event.PurchaseScreenOpen:
       return "purchase_screen_open";
+    case Event.PurchaseScreenClose:
+      return "purchase_screen_close";
+    case Event.PurchaseScreenThankYou:
+      return "purchase_screen_thank_you";
+
+    case Event.GitHostSetupError:
+      return "githostsetup_error";
+    case Event.GitHostSetupComplete:
+      return "onboarding_complete";
+    case Event.GitHostSetupGitCloneError:
+      return "onboarding_gitClone_error";
+    case Event.GitHostSetupButtonClick:
+      return "githostsetup_button_click";
+
+    case Event.Settings:
+      return "settings";
   }
 
   return "unknown_event";
@@ -89,14 +114,6 @@ class Analytics {
   var firebase = FirebaseAnalytics();
   bool enabled = false;
 
-  Future<void> logEvent({
-    @required String name,
-    Map<String, String> parameters,
-  }) async {
-    await firebase.logEvent(name: name, parameters: parameters);
-    captureErrorBreadcrumb(name: name, parameters: parameters);
-  }
-
   Future<void> log({
     @required Event e,
     Map<String, String> parameters,

lib/app.dart

@@ -138,10 +138,7 @@ class JournalApp extends StatefulWidget {
     JournalApp.analytics.setAnalyticsCollectionEnabled(enabled);
 
     if (enabled) {
-      JournalApp.analytics.logEvent(
+      logEvent(Event.Settings, parameters: settings.toLoggableMap());
-        name: "settings",
-        parameters: settings.toLoggableMap(),
-      );
     }
   }
 

lib/screens/purchase_screen.dart

@@ -60,9 +60,7 @@ class PurchaseScreen extends StatelessWidget {
   }
 
   Future<bool> _onWillPop() async {
-    getAnalytics().logEvent(
+    logEvent(Event.PurchaseScreenClose);
-      name: "purchase_screen_close",
-    );
     return true;
   }
 }

lib/setup/autoconfigure.dart

@@ -87,8 +87,8 @@ class GitHostSetupAutoConfigureState extends State<GitHostSetupAutoConfigure> {
     Log.d("GitHostSetupAutoConfigure: " + e.toString());
     setState(() {
       errorMessage = widget.gitHostType.toString() + ": " + e.toString();
-      getAnalytics().logEvent(
+      logEvent(
-        name: "githostsetup_error",
+        Event.GitHostSetupError,
         parameters: <String, String>{
           'errorMessage': errorMessage,
         },

lib/setup/button.dart

@@ -50,13 +50,10 @@ class GitHostSetupButton extends StatelessWidget {
 
   void _onPressedWithAnalytics() {
     Log.d("githostsetup_button_click " + text);
-    getAnalytics().logEvent(
+    logEvent(Event.GitHostSetupButtonClick, parameters: {
-      name: "githostsetup_button_click",
+      'text': text,
-      parameters: <String, String>{
+      'icon_url': iconUrl == null ? "" : iconUrl,
-        'text': text,
+    });
-        'icon_url': iconUrl == null ? "" : iconUrl,
-      },
-    );
     onPressed();
   }
 }

lib/setup/repo_selector.dart

@@ -97,12 +97,9 @@ class GitHostSetupRepoSelectorState extends State<GitHostSetupRepoSelector> {
     Log.d("GitHostSetupAutoConfigure: " + e.toString());
     setState(() {
       errorMessage = e.toString();
-      getAnalytics().logEvent(
+      logEvent(Event.GitHostSetupError, parameters: {
-        name: "githostsetup_error",
+        'errorMessage': errorMessage,
-        parameters: <String, String>{
+      });
-          'errorMessage': errorMessage,
-        },
-      );
 
       logException(e, stacktrace);
     });

lib/setup/screens.dart

@@ -486,12 +486,9 @@ class GitHostSetupScreenState extends State<GitHostSetupScreen> {
 
     if (error != null && error.isNotEmpty) {
       setState(() {
-        getAnalytics().logEvent(
+        logEvent(Event.GitHostSetupGitCloneError, parameters: {
-          name: "onboarding_gitClone_error",
+          'error': error,
-          parameters: <String, String>{
+        });
-            'error': error,
-          },
-        );
         gitCloneErrorMessage = error;
       });
       return;
@@ -523,8 +520,8 @@ class GitHostSetupScreenState extends State<GitHostSetupScreen> {
       );
     }
 
-    getAnalytics().logEvent(
+    logEvent(
-      name: "onboarding_complete",
+      Event.GitHostSetupComplete,
       parameters: _buildOnboardingAnalytics(),
     );
     Navigator.pop(context);
@@ -563,9 +560,9 @@ class GitHostSetupScreenState extends State<GitHostSetupScreen> {
     Log.d("GitHostSetupAutoConfigureComplete: " + e.toString());
     setState(() {
       _autoConfigureErrorMessage = e.toString();
-      getAnalytics().logEvent(
+      logEvent(
-        name: "githostsetup_error",
+        Event.GitHostSetupError,
-        parameters: <String, String>{
+        parameters: {
           'errorMessage': _autoConfigureErrorMessage,
         },
       );

lib/widgets/purchase_widget.dart

@@ -178,10 +178,7 @@ class _PurchaseWidgetState extends State<PurchaseWidget> {
     settings.proExpirationDate = status.expiryDate.toIso8601String();
     settings.save();
 
-    getAnalytics().logEvent(
+    logEvent(Event.PurchaseScreenThankYou);
-      name: "purchase_screen_thank_you",
-    );
-
     Navigator.of(context).popAndPushNamed('/purchase_thank_you');
   }