flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-29 02:07:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

TodoEditor: Only show remove buttons when that item has focus

Browse Source 
Looks less cluttered.
This commit is contained in:
Vishesh Handa
2020-01-30 19:26:58 +01:00
parent a11d535078
commit 698e741851
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
lib/editors/todo_editor.dart
View File

@ -170,11 +170,15 @@ class TodoItemTile extends StatefulWidget {
class _TodoItemTileState extends State<TodoItemTile> { class _TodoItemTileState extends State<TodoItemTile> {
TextEditingController _textController; TextEditingController _textController;
FocusNode _focusNode = FocusNode();
@override @override
void initState() { void initState() {
super.initState(); super.initState();
_textController = TextEditingController(text: widget.todo.body); _textController = TextEditingController(text: widget.todo.body);
_focusNode.addListener(() {
setState(() {});
});
} }
@override @override
@ -182,6 +186,7 @@ class _TodoItemTileState extends State<TodoItemTile> {
var style = Theme.of(context).textTheme.subhead; var style = Theme.of(context).textTheme.subhead;
var editor = TextField( var editor = TextField(
focusNode: _focusNode,
keyboardType: TextInputType.text, keyboardType: TextInputType.text,
maxLines: 1, maxLines: 1,
style: style, style: style,
@ -194,6 +199,7 @@ class _TodoItemTileState extends State<TodoItemTile> {
); );
return ListTile( return ListTile(
dense: true,
leading: Row( leading: Row(
children: <Widget>[ children: <Widget>[
Container(height: 24.0, width: 24.0, child: Icon(Icons.reorder)), Container(height: 24.0, width: 24.0, child: Icon(Icons.reorder)),
@ -205,11 +211,12 @@ class _TodoItemTileState extends State<TodoItemTile> {
mainAxisSize: MainAxisSize.min, mainAxisSize: MainAxisSize.min,
), ),
title: editor, title: editor,
trailing: IconButton( trailing: _focusNode.hasFocus
icon: Icon(Icons.cancel), ? IconButton(
onPressed: widget.todoRemoved, icon: Icon(Icons.cancel),
), onPressed: widget.todoRemoved,
dense: true, )
: null,
); );
} }
} }
@ -217,4 +224,4 @@ class _TodoItemTileState extends State<TodoItemTile> {
// FIXME: The body needs to be scrollable // FIXME: The body needs to be scrollable
// FIXME: Add a new todo button // FIXME: Add a new todo button
// FIXME: Fix padding issue with todo items // FIXME: Fix padding issue with todo items
// FIXME: Only show 'x' when active // FIXME: When removing an item the focus should jump to the next/prev in line