From 62ecd016f7754c422c93dcfc0e6577045e573ee4 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Thu, 10 Jan 2019 18:18:14 +0100 Subject: [PATCH] Move the PageController into a state widget Doesn't it have some state since it's fundamentally storing which page we are one? Or where is that stored otherwise? --- lib/screens/onboarding_screens.dart | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lib/screens/onboarding_screens.dart b/lib/screens/onboarding_screens.dart index 7757b9d5..0a74a7b7 100644 --- a/lib/screens/onboarding_screens.dart +++ b/lib/screens/onboarding_screens.dart @@ -3,14 +3,22 @@ import 'package:shared_preferences/shared_preferences.dart'; import 'package:journal/storage/git.dart'; -class OnBoardingScreen extends StatelessWidget { +class OnBoardingScreen extends StatefulWidget { final Function onBoardingCompletedFunction; OnBoardingScreen(this.onBoardingCompletedFunction); + @override + OnBoardingScreenState createState() { + return new OnBoardingScreenState(); + } +} + +class OnBoardingScreenState extends State { + var pageController = PageController(); + @override Widget build(BuildContext context) { - var pageController = PageController(); var pageView = PageView( controller: pageController, children: [ @@ -31,7 +39,7 @@ class OnBoardingScreen extends StatelessWidget { ); }), OnBoardingGitClone( - doneFunction: this.onBoardingCompletedFunction, + doneFunction: this.widget.onBoardingCompletedFunction, ), ], );