From 5a79fa26ca07fef431be25f28401dfd80561a6dc Mon Sep 17 00:00:00 2001
From: Vishesh Handa <me@vhanda.in>
Date: Fri, 27 Dec 2019 11:10:22 +0100
Subject: [PATCH] Add a Fade transition when jumping from Viewing to Editing
It looks much better than the normal page transition.
---
lib/screens/journal_browsing.dart | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/lib/screens/journal_browsing.dart b/lib/screens/journal_browsing.dart
index dd054788..723cff68 100644
--- a/lib/screens/journal_browsing.dart
+++ b/lib/screens/journal_browsing.dart
@@ -2,12 +2,14 @@ import 'package:fimber/fimber.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_markdown/flutter_markdown.dart';
+import 'package:page_transition/page_transition.dart';
+import 'package:share/share.dart';
+
import 'package:gitjournal/core/note.dart';
import 'package:gitjournal/state_container.dart';
import 'package:gitjournal/utils.dart';
import 'package:gitjournal/settings.dart';
import 'package:gitjournal/widgets/journal_editor_header.dart';
-import 'package:share/share.dart';
import 'journal_editor.dart';
@@ -70,11 +72,14 @@ class JournalBrowsingScreenState extends State<JournalBrowsingScreen> {
floatingActionButton: FloatingActionButton(
child: Icon(Icons.edit),
onPressed: () {
- var route = MaterialPageRoute(builder: (context) {
- Note note = widget.notes[_currentIndex()];
- return JournalEditor.fromNote(note);
- });
- Navigator.of(context).push(route);
+ Note note = widget.notes[_currentIndex()];
+ Navigator.push(
+ context,
+ PageTransition(
+ type: PageTransitionType.fade,
+ child: JournalEditor.fromNote(note),
+ ),
+ );
},
),
);