flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-29 18:38:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

logEvent: Parameters must be <String, String>{}

Browse Source 
Not string, dynamic. Sentry wants strings.
This commit is contained in:
Vishesh Handa
2020-05-01 10:50:09 +02:00
parent 9ee16ebe50
commit 49bf02bf15
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/analytics.dart
View File

@ -59,7 +59,7 @@ class Analytics {
Future<void> logEvent({ Future<void> logEvent({
@required String name, @required String name,
Map<String, dynamic> parameters, Map<String, String> parameters,
}) async { }) async {
await firebase.logEvent(name: name, parameters: parameters); await firebase.logEvent(name: name, parameters: parameters);
captureErrorBreadcrumb(name: name, parameters: parameters); captureErrorBreadcrumb(name: name, parameters: parameters);
@ -67,7 +67,7 @@ class Analytics {
Future<void> log({ Future<void> log({
@required Event e, @required Event e,
Map<String, dynamic> parameters, Map<String, String> parameters,
}) async { }) async {
String name = _eventToString(e); String name = _eventToString(e);
await firebase.logEvent(name: name, parameters: parameters); await firebase.logEvent(name: name, parameters: parameters);
@ -80,6 +80,6 @@ class Analytics {
} }
} }
void logEvent(Event event, {Map<String, dynamic> parameters}) { void logEvent(Event event, {Map<String, String> parameters}) {
getAnalytics().log(e: event, parameters: parameters); getAnalytics().log(e: event, parameters: parameters);
} }

2
lib/error_reporting.dart
View File

@ -113,7 +113,7 @@ List<Breadcrumb> breadcrumbs = [];
void captureErrorBreadcrumb({ void captureErrorBreadcrumb({
@required String name, @required String name,
Map<String, dynamic> parameters, Map<String, String> parameters,
}) { }) {
var b = Breadcrumb(name, DateTime.now(), data: parameters); var b = Breadcrumb(name, DateTime.now(), data: parameters);
breadcrumbs.add(b); breadcrumbs.add(b);

2
lib/setup/autoconfigure.dart
View File

@ -117,7 +117,7 @@ class GitHostSetupAutoConfigureState extends State<GitHostSetupAutoConfigure> {
errorMessage = widget.gitHostType.toString() + ": " + e.toString(); errorMessage = widget.gitHostType.toString() + ": " + e.toString();
getAnalytics().logEvent( getAnalytics().logEvent(
name: "githostsetup_error", name: "githostsetup_error",
parameters: <String, dynamic>{ parameters: <String, String>{
'errorMessage': errorMessage, 'errorMessage': errorMessage,
}, },
); );

2
lib/setup/button.dart
View File

@ -50,7 +50,7 @@ class GitHostSetupButton extends StatelessWidget {
Log.d("githostsetup_button_click " + text); Log.d("githostsetup_button_click " + text);
getAnalytics().logEvent( getAnalytics().logEvent(
name: "githostsetup_button_click", name: "githostsetup_button_click",
parameters: <String, dynamic>{ parameters: <String, String>{
'text': text, 'text': text,
'icon_url': iconUrl == null ? "" : iconUrl, 'icon_url': iconUrl == null ? "" : iconUrl,
}, },

6
lib/setup/screens.dart
View File

@ -457,7 +457,7 @@ class GitHostSetupScreenState extends State<GitHostSetupScreen> {
setState(() { setState(() {
getAnalytics().logEvent( getAnalytics().logEvent(
name: "onboarding_gitClone_error", name: "onboarding_gitClone_error",
parameters: <String, dynamic>{ parameters: <String, String>{
'error': error, 'error': error,
}, },
); );
@ -492,8 +492,8 @@ class GitHostSetupScreenState extends State<GitHostSetupScreen> {
widget.onCompletedFunction(); widget.onCompletedFunction();
} }
Map<String, dynamic> _buildOnboardingAnalytics() { Map<String, String> _buildOnboardingAnalytics() {
var map = <String, dynamic>{}; var map = <String, String>{};
if (_gitCloneUrl.contains("github.com")) { if (_gitCloneUrl.contains("github.com")) {
map["host_type"] = "GitHub"; map["host_type"] = "GitHub";