flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-30 19:36:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use context.read instead of Provider.of with listen false

Browse Source 
Shorter
This commit is contained in:
Vishesh Handa
2021-02-15 22:31:45 +01:00
parent 130f2fe9a0
commit 406a72088b
8 changed files with 21 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/folder_views/common.dart
View File

@ -94,7 +94,7 @@ void openNoteEditor(
if (showUndoSnackBar != null) { if (showUndoSnackBar != null) {
Log.d("Showing an undo snackbar"); Log.d("Showing an undo snackbar");
var stateContainer = Provider.of<GitJournalRepo>(context, listen: false); var stateContainer = context.read<GitJournalRepo>();
var snackBar = buildUndoDeleteSnackbar(stateContainer, note); var snackBar = buildUndoDeleteSnackbar(stateContainer, note);
Scaffold.of(context) Scaffold.of(context)
..removeCurrentSnackBar() ..removeCurrentSnackBar()

3
lib/folder_views/list_view.dart
View File

@ -155,8 +155,7 @@ class _FolderListViewState extends State<FolderListView> {
onDismissed: (direction) { onDismissed: (direction) {
deletedViaDismissed.add(note.filePath); deletedViaDismissed.add(note.filePath);
var stateContainer = var stateContainer = context.read<GitJournalRepo>();
Provider.of<GitJournalRepo>(context, listen: false);
stateContainer.removeNote(note); stateContainer.removeNote(note);
var snackBar = buildUndoDeleteSnackbar(stateContainer, note); var snackBar = buildUndoDeleteSnackbar(stateContainer, note);

2
lib/screens/filesystem_screen.dart
View File

@ -74,7 +74,7 @@ class _FileSystemScreenState extends State<FileSystemScreen> {
), ),
); );
if (newFileName is String) { if (newFileName is String) {
var container = Provider.of<GitJournalRepo>(context, listen: false); var container = context.read<GitJournalRepo>();
container.renameFile(oldPath, newFileName); container.renameFile(oldPath, newFileName);
} }
} }

11
lib/screens/folder_listing.dart
View File

@ -86,8 +86,7 @@ class _FolderListingScreenState extends State<FolderListingScreen> {
), ),
); );
if (folderName is String) { if (folderName is String) {
var container = var container = context.read<GitJournalRepo>();
Provider.of<GitJournalRepo>(context, listen: false);
container.renameFolder(selectedFolder, folderName); container.renameFolder(selectedFolder, folderName);
} }
} else if (value == "Create") { } else if (value == "Create") {
@ -96,8 +95,7 @@ class _FolderListingScreenState extends State<FolderListingScreen> {
builder: (_) => CreateFolderAlertDialog(), builder: (_) => CreateFolderAlertDialog(),
); );
if (folderName is String) { if (folderName is String) {
var container = var container = context.read<GitJournalRepo>();
Provider.of<GitJournalRepo>(context, listen: false);
container.createFolder(selectedFolder, folderName); container.createFolder(selectedFolder, folderName);
} }
} else if (value == "Delete") { } else if (value == "Delete") {
@ -107,8 +105,7 @@ class _FolderListingScreenState extends State<FolderListingScreen> {
builder: (_) => DeleteFolderErrorDialog(), builder: (_) => DeleteFolderErrorDialog(),
); );
} else { } else {
var container = var container = context.read<GitJournalRepo>();
Provider.of<GitJournalRepo>(context, listen: false);
container.removeFolder(selectedFolder); container.removeFolder(selectedFolder);
} }
} }
@ -156,7 +153,7 @@ class CreateFolderButton extends StatelessWidget {
builder: (_) => CreateFolderAlertDialog(), builder: (_) => CreateFolderAlertDialog(),
); );
if (folderName is String) { if (folderName is String) {
var container = Provider.of<GitJournalRepo>(context, listen: false); var container = context.read<GitJournalRepo>();
final notesFolder = final notesFolder =
Provider.of<NotesFolderFS>(context, listen: false); Provider.of<NotesFolderFS>(context, listen: false);

12
lib/screens/folder_view.dart
View File

@ -160,7 +160,7 @@ class _FolderViewState extends State<FolderView> {
void _syncRepo(BuildContext context) async { void _syncRepo(BuildContext context) async {
try { try {
var container = Provider.of<GitJournalRepo>(context, listen: false); var container = context.read<GitJournalRepo>();
await container.syncNotes(); await container.syncNotes();
} on GitException catch (e) { } on GitException catch (e) {
showSnackbar( showSnackbar(
@ -234,7 +234,7 @@ class _FolderViewState extends State<FolderView> {
var settings = Provider.of<Settings>(context, listen: false); var settings = Provider.of<Settings>(context, listen: false);
config.saveToSettings(settings); config.saveToSettings(settings);
var container = Provider.of<GitJournalRepo>(context, listen: false); var container = context.read<GitJournalRepo>();
container.saveFolderConfig(sortedNotesFolder.config); container.saveFolderConfig(sortedNotesFolder.config);
setState(() { setState(() {
@ -259,7 +259,7 @@ class _FolderViewState extends State<FolderView> {
var settings = Provider.of<Settings>(context, listen: false); var settings = Provider.of<Settings>(context, listen: false);
config.saveToSettings(settings); config.saveToSettings(settings);
var container = Provider.of<GitJournalRepo>(context, listen: false); var container = context.read<GitJournalRepo>();
container.saveFolderConfig(sortedNotesFolder.config); container.saveFolderConfig(sortedNotesFolder.config);
}; };
@ -275,7 +275,7 @@ class _FolderViewState extends State<FolderView> {
var settings = Provider.of<Settings>(context, listen: false); var settings = Provider.of<Settings>(context, listen: false);
config.saveToSettings(settings); config.saveToSettings(settings);
var container = Provider.of<GitJournalRepo>(context, listen: false); var container = context.read<GitJournalRepo>();
container.saveFolderConfig(sortedNotesFolder.config); container.saveFolderConfig(sortedNotesFolder.config);
}; };
@ -407,7 +407,7 @@ class _FolderViewState extends State<FolderView> {
var settings = Provider.of<Settings>(context, listen: false); var settings = Provider.of<Settings>(context, listen: false);
config.saveToSettings(settings); config.saveToSettings(settings);
var container = Provider.of<GitJournalRepo>(context, listen: false); var container = context.read<GitJournalRepo>();
container.saveFolderConfig(widget.notesFolder.config); container.saveFolderConfig(widget.notesFolder.config);
} }
} }
@ -494,7 +494,7 @@ class _FolderViewState extends State<FolderView> {
); );
} }
if (shouldDelete == true) { if (shouldDelete == true) {
var stateContainer = Provider.of<GitJournalRepo>(context, listen: false); var stateContainer = context.read<GitJournalRepo>();
stateContainer.removeNote(note); stateContainer.removeNote(note);
} }

11
lib/screens/note_editor.dart
View File

@ -283,7 +283,7 @@ class NoteEditorState extends State<NoteEditor> with WidgetsBindingObserver {
}); });
return; return;
} }
var container = Provider.of<GitJournalRepo>(context, listen: false); var container = context.read<GitJournalRepo>();
container.renameNote(note, fileName); container.renameNote(note, fileName);
} }
} }
@ -318,7 +318,7 @@ class NoteEditorState extends State<NoteEditor> with WidgetsBindingObserver {
return; return;
} }
var stateContainer = Provider.of<GitJournalRepo>(context, listen: false); var stateContainer = context.read<GitJournalRepo>();
stateContainer.removeNote(note); stateContainer.removeNote(note);
} }
@ -353,7 +353,7 @@ class NoteEditorState extends State<NoteEditor> with WidgetsBindingObserver {
Log.d("Note modified - saving"); Log.d("Note modified - saving");
try { try {
var stateContainer = Provider.of<GitJournalRepo>(context, listen: false); var stateContainer = context.read<GitJournalRepo>();
_isNewNote _isNewNote
? await stateContainer.addNote(note) ? await stateContainer.addNote(note)
: await stateContainer.updateNote(note); : await stateContainer.updateNote(note);
@ -396,15 +396,14 @@ class NoteEditorState extends State<NoteEditor> with WidgetsBindingObserver {
note.parent = destFolder; note.parent = destFolder;
setState(() {}); setState(() {});
} else { } else {
var stateContainer = var stateContainer = context.read<GitJournalRepo>();
Provider.of<GitJournalRepo>(context, listen: false);
stateContainer.moveNote(note, destFolder); stateContainer.moveNote(note, destFolder);
} }
} }
} }
void _discardChangesSelected(Note note) async { void _discardChangesSelected(Note note) async {
var stateContainer = Provider.of<GitJournalRepo>(context, listen: false); var stateContainer = context.read<GitJournalRepo>();
stateContainer.discardChanges(note); stateContainer.discardChanges(note);
Navigator.pop(context); Navigator.pop(context);

2
lib/screens/settings_git_remote.dart
View File

@ -186,7 +186,7 @@ class _GitRemoteSettingsScreenState extends State<GitRemoteSettingsScreen> {
return; return;
} }
var repo = Provider.of<GitJournalRepo>(context, listen: false); var repo = context.read<GitJournalRepo>();
var gitDir = repo.gitBaseDirectory; var gitDir = repo.gitBaseDirectory;
// Figure out the next available folder // Figure out the next available folder

4
lib/setup/screens.dart
View File

@ -421,7 +421,7 @@ class GitHostSetupScreenState extends State<GitHostSetupScreen> {
} }
Future<void> _removeRemote() async { Future<void> _removeRemote() async {
var repo = Provider.of<GitJournalRepo>(context, listen: false); var repo = context.read<GitJournalRepo>();
var basePath = repo.gitBaseDirectory; var basePath = repo.gitBaseDirectory;
var repoPath = p.join(basePath, widget.repoFolderName); var repoPath = p.join(basePath, widget.repoFolderName);
@ -527,7 +527,7 @@ class GitHostSetupScreenState extends State<GitHostSetupScreen> {
return; return;
} }
var repo = Provider.of<GitJournalRepo>(context, listen: false); var repo = context.read<GitJournalRepo>();
var basePath = repo.gitBaseDirectory; var basePath = repo.gitBaseDirectory;
var settings = Provider.of<Settings>(context, listen: false); var settings = Provider.of<Settings>(context, listen: false);