flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-25 16:19:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

BottomBar: Use widgets instead of functions

Browse Source 
Improves performance
This commit is contained in:
Vishesh Handa
2021-07-07 16:55:35 +02:00
parent 770b37430f
commit 3e2e31d3bb
1 changed files with 145 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
lib/editors/bottom_bar.dart
View File

@ -49,7 +49,7 @@ class EditorBottomBar extends StatelessWidget {
onPressed: () {
showModalBottomSheet(
context: context,
builder: (c) => _buildAddBottomSheet(c, editor, editorState),
builder: (c) => AddBottomSheet(editor, editorState),
elevation: 0,
);
},
@ -60,13 +60,12 @@ class EditorBottomBar extends StatelessWidget {
onPressed: () {
showModalBottomSheet(
context: context,
builder: (c) => _buildBottomMenuSheet(
c,
editor,
editorState,
zenMode,
onZenModeChanged,
metaDataEditable,
builder: (c) => BottomMenuSheet(
editor: editor,
editorState: editorState,
zenModeEnabled: zenMode,
zenModeChanged: onZenModeChanged,
metaDataEditable: metaDataEditable,
),
elevation: 0,
);
@ -121,11 +120,15 @@ class EditorBottomBar extends StatelessWidget {
}
}
Widget _buildAddBottomSheet(
BuildContext context,
Editor editor,
EditorState editorState,
) {
class AddBottomSheet extends StatelessWidget {
final Editor editor;
final EditorState editorState;
const AddBottomSheet(this.editor, this.editorState, {Key? key})
: super(key: key);
@override
Widget build(BuildContext context) {
return Container(
child: Column(
mainAxisSize: MainAxisSize.min,
@ -173,16 +176,27 @@ Widget _buildAddBottomSheet(
],
),
);
}
}
Widget _buildBottomMenuSheet(
BuildContext context,
Editor editor,
EditorState editorState,
bool zenModeEnabled,
Func0<void> zenModeChanged,
bool metaDataEditable,
) {
class BottomMenuSheet extends StatelessWidget {
final Editor editor;
final EditorState editorState;
final bool zenModeEnabled;
final Func0<void> zenModeChanged;
final bool metaDataEditable;
const BottomMenuSheet({
Key? key,
required this.editor,
required this.editorState,
required this.zenModeEnabled,
required this.zenModeChanged,
required this.metaDataEditable,
}) : super(key: key);
@override
Widget build(BuildContext context) {
return Container(
child: Column(
mainAxisSize: MainAxisSize.min,
@ -248,4 +262,5 @@ Widget _buildBottomMenuSheet(
],
),
);
}
}