flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-28 18:03:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Log errors if public/private key is empty

Browse Source 
This shouldn't ever happen. It means a migration has gone wrong.
This commit is contained in:
Vishesh Handa
2020-11-07 10:05:20 +01:00
parent f72f317cee
commit 2bb0646f48
3 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/repository.dart
View File

@ -4,6 +4,7 @@ import 'dart:io';
import 'package:flutter/foundation.dart'; import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:dart_git/config.dart';
import 'package:dart_git/dart_git.dart'; import 'package:dart_git/dart_git.dart';
import 'package:path/path.dart' as p; import 'package:path/path.dart' as p;
import 'package:shared_preferences/shared_preferences.dart'; import 'package:shared_preferences/shared_preferences.dart';
@ -88,6 +89,7 @@ class Repository with ChangeNotifier {
var remoteConfigured = false; var remoteConfigured = false;
List<GitRemoteConfig> remotes;
if (repoDirStat.type != FileSystemEntityType.directory) { if (repoDirStat.type != FileSystemEntityType.directory) {
Log.i("Calling GitInit for ${settings.folderName} at: $repoPath"); Log.i("Calling GitInit for ${settings.folderName} at: $repoPath");
await GitRepository.init(repoPath); await GitRepository.init(repoPath);
@ -95,10 +97,23 @@ class Repository with ChangeNotifier {
settings.save(); settings.save();
} else { } else {
var gitRepo = await GitRepository.load(repoPath); var gitRepo = await GitRepository.load(repoPath);
var remotes = gitRepo.config.remotes; remotes = gitRepo.config.remotes;
remoteConfigured = remotes.isNotEmpty; remoteConfigured = remotes.isNotEmpty;
} }
if (remoteConfigured) {
if (settings.sshPublicKey == null || settings.sshPublicKey.isEmpty) {
var remoteNames = remotes.map((e) => e.name + ' ' + e.url).toList();
Log.e("Public Key Empty for $remoteNames");
logExceptionWarning(Exception("Public Key Empty"), StackTrace.current);
}
if (settings.sshPrivateKey == null || settings.sshPrivateKey.isEmpty) {
var remoteNames = remotes.map((e) => e.name + ' ' + e.url).toList();
Log.e("Private Key Empty for $remoteNames");
logExceptionWarning(Exception("Private Key Empty"), StackTrace.current);
}
}
return Repository._internal( return Repository._internal(
repoPath: repoPath, repoPath: repoPath,
gitBaseDirectory: gitBaseDir, gitBaseDirectory: gitBaseDir,

2
lib/settings.dart
View File

@ -4,11 +4,11 @@ import 'package:collection/collection.dart';
import 'package:easy_localization/easy_localization.dart'; import 'package:easy_localization/easy_localization.dart';
import 'package:path/path.dart' as p; import 'package:path/path.dart' as p;
import 'package:shared_preferences/shared_preferences.dart'; import 'package:shared_preferences/shared_preferences.dart';
import 'package:uuid/uuid.dart';
import 'package:gitjournal/core/sorting_mode.dart'; import 'package:gitjournal/core/sorting_mode.dart';
import 'package:gitjournal/folder_views/common.dart'; import 'package:gitjournal/folder_views/common.dart';
import 'package:gitjournal/screens/note_editor.dart'; import 'package:gitjournal/screens/note_editor.dart';
import 'package:uuid/uuid.dart';
const DEFAULT_ID = "0"; const DEFAULT_ID = "0";

2
lib/settings_migrations.dart
View File

@ -1,9 +1,9 @@
import 'dart:io'; import 'dart:io';
import 'package:gitjournal/settings.dart';
import 'package:path/path.dart' as p; import 'package:path/path.dart' as p;
import 'package:shared_preferences/shared_preferences.dart'; import 'package:shared_preferences/shared_preferences.dart';
import 'package:gitjournal/settings.dart';
import 'package:gitjournal/utils/logger.dart'; import 'package:gitjournal/utils/logger.dart';
Future<void> migrateSettings( Future<void> migrateSettings(