From 2238e8343fe201dff85e23836fb84a63a4728fd5 Mon Sep 17 00:00:00 2001
From: Vishesh Handa <me@vhanda.in>
Date: Tue, 8 Oct 2019 14:52:09 +0200
Subject: [PATCH] Remove preferences dependency

It doesn't follow the Material Design spec, and usually required a
PreferencesService to be running. It is easier to just create our own
widgets.
---
 lib/screens/settings_screen.dart | 3 +--
 pubspec.lock                     | 7 -------
 pubspec.yaml                     | 1 -
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/lib/screens/settings_screen.dart b/lib/screens/settings_screen.dart
index 510af0d3..1857bd6e 100644
--- a/lib/screens/settings_screen.dart
+++ b/lib/screens/settings_screen.dart
@@ -2,7 +2,6 @@ import 'package:flutter/material.dart';
 import 'package:gitjournal/settings.dart';
 import 'package:gitjournal/utils.dart';
 
-import 'package:preferences/preferences.dart';
 import 'package:dynamic_theme/dynamic_theme.dart';
 
 class SettingsScreen extends StatelessWidget {
@@ -112,7 +111,7 @@ class SettingsListState extends State<SettingsList> {
 
     var brightness = DynamicTheme.of(context).brightness;
 
-    return PreferencePage([
+    return ListView(children: [
       SettingsHeader('Display Settings'),
       ListPreference(
         title: "Theme",
diff --git a/pubspec.lock b/pubspec.lock
index c3699285..cf9f6f18 100644
--- a/pubspec.lock
+++ b/pubspec.lock
@@ -371,13 +371,6 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.4.0"
-  preferences:
-    dependency: "direct main"
-    description:
-      name: preferences
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "4.0.0"
   process:
     dependency: transitive
     description:
diff --git a/pubspec.yaml b/pubspec.yaml
index 78c1f99a..52d50063 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -25,7 +25,6 @@ dependencies:
   function_types: ^0.0.2
   auto_size_text: ^2.0.1
   fimber: ^0.3.0
-  preferences: ^4.0.0
   dynamic_theme: ^1.0.0
 
 dev_dependencies: