From 1fcc4bc102aa9c5ebe4e7bda763617d494417289 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Wed, 29 Jul 2020 16:31:49 +0200 Subject: [PATCH] MetaData Setting: Set these strings as translatable --- assets/langs/en.yaml | 2 ++ lib/screens/settings_note_metadata.dart | 10 ++-------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/assets/langs/en.yaml b/assets/langs/en.yaml index 74d63a64..e5501757 100644 --- a/assets/langs/en.yaml +++ b/assets/langs/en.yaml @@ -49,6 +49,8 @@ settings: title: Title fromH1: Text Header 1 fromYaml: From YAML 'title' + exampleTitle: Pigeons + exampleBody: I think they might be evil. Even more evil than penguins. privacy: Privacy Policy terms: Terms and Conditions experimental: diff --git a/lib/screens/settings_note_metadata.dart b/lib/screens/settings_note_metadata.dart index 4f3f8ec7..db1bdb74 100644 --- a/lib/screens/settings_note_metadata.dart +++ b/lib/screens/settings_note_metadata.dart @@ -24,10 +24,9 @@ class _NoteMetadataSettingsScreenState Widget build(BuildContext context) { var textTheme = Theme.of(context).textTheme; - // FIXME: Translate these var note = Note(null, "fileName.md"); - note.title = "Pigeons"; - note.body = _buildBody(); + note.title = tr("settings.noteMetaData.exampleTitle"); + note.body = tr("settings.noteMetaData.exampleBody"); note.created = DateTime.now().add(const Duration(days: -1)); note.modified = DateTime.now(); @@ -114,11 +113,6 @@ class _NoteMetadataSettingsScreenState body: SingleChildScrollView(child: body), ); } - - // FIXME: Add some random text - String _buildBody() { - return "I think they might be evil. Even more evil than penguins."; - } } class NoteOutputExample extends StatelessWidget {