From 1d767f1f4d3f30333b704a32f8581080f4c54244 Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Fri, 19 Jun 2020 14:09:03 +0200 Subject: [PATCH] Remove flutter_runtime_env env flutter_sentry provides the same feature. I prefer having the minimum amount of external dependencies. --- lib/app.dart | 8 +++++--- pubspec.lock | 7 ------- pubspec.yaml | 1 - 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/lib/app.dart b/lib/app.dart index 753cf391..d62b45da 100644 --- a/lib/app.dart +++ b/lib/app.dart @@ -4,6 +4,8 @@ import 'dart:io'; import 'package:device_info/device_info.dart'; import 'package:firebase_analytics/observer.dart'; import 'package:flutter/material.dart'; +import 'package:flutter/foundation.dart' as foundation; + import 'package:gitjournal/analytics.dart'; import 'package:gitjournal/screens/filesystem_screen.dart'; import 'package:gitjournal/screens/folder_listing.dart'; @@ -15,7 +17,7 @@ import 'package:gitjournal/utils.dart'; import 'package:gitjournal/utils/logger.dart'; import 'package:provider/provider.dart'; import 'package:path/path.dart' as p; -import 'package:flutter_runtime_env/flutter_runtime_env.dart' as runtime_env; +import 'package:flutter_sentry/flutter_sentry.dart'; import 'package:easy_localization/easy_localization.dart'; import 'package:easy_localization_loader/easy_localization_loader.dart'; @@ -106,7 +108,7 @@ class JournalApp extends StatefulWidget { } static void _enableAnalyticsIfPossible() async { - JournalApp.isInDebugMode = runtime_env.isInDebugMode(); + JournalApp.isInDebugMode = foundation.kDebugMode; var isPhysicalDevice = true; try { @@ -127,7 +129,7 @@ class JournalApp extends StatefulWidget { JournalApp.isInDebugMode = true; } - bool inFireBaseTestLab = await runtime_env.inFirebaseTestLab(); + bool inFireBaseTestLab = await FlutterSentry.isFirebaseTestLab(); bool enabled = !JournalApp.isInDebugMode && !inFireBaseTestLab; Log.d("Analytics Collection: $enabled"); diff --git a/pubspec.lock b/pubspec.lock index 8f1dac3d..66f426f4 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -284,13 +284,6 @@ packages: url: "https://pub.dartlang.org" source: hosted version: "1.0.8" - flutter_runtime_env: - dependency: "direct main" - description: - name: flutter_runtime_env - url: "https://pub.dartlang.org" - source: hosted - version: "0.0.3" flutter_sentry: dependency: "direct main" description: diff --git a/pubspec.yaml b/pubspec.yaml index 60401be2..353345e7 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -35,7 +35,6 @@ dependencies: dart_git: git: https://github.com/GitJournal/dart_git.git #path: /Users/vishesh/src/gitjournal/dart_git - flutter_runtime_env: ^0.0.3 yaml_serializer: ^0.0.6 connectivity: ^0.4.6+1 flutter_emoji: ">= 2.0.0"