flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-27 17:29:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid loading all the Notes in one go

Browse Source 
This can sometimes lead to too many files being opened in parallel and
then failing because there aren't any file descriptors left. This patch
isn't perfect as given the directory structure we could still be loading
too many in one go, but it's a quick workaround for now.

The proper solution is to only load the Notes which need to be displayed
instead of loading all of them at startup.
This commit is contained in:
Vishesh Handa
2020-01-31 23:25:28 +01:00
parent 82aeb01ba9
commit 0fd7892e40
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/core/notes_folder.dart
View File

@ -96,18 +96,28 @@ class NotesFolder with ChangeNotifier implements Comparable<NotesFolder> {
// FIXME: This asynchronously loads everything. Maybe it should just list them, and the individual _entities
// should be loaded as required?
// FIXME: This loads everything in one go. In some cases there can be too many files open and we hit the limit.
Future<void> loadRecursively() async {
const maxParallel = 10;
var futures = <Future>[];
await load();
_entities.forEach((e) {
for (var i = 0; i < _entities.length; i++) {
var e = _entities[i];
if (e.isFolder) {
e.folder.loadRecursively();
var f = e.folder.loadRecursively();
futures.add(f);
} else {
// FIXME: Collected all the Errors, and report them back, along with "WHY", and the contents of the Note
// Each of these needs to be reported to crashlytics, as Note loading should never fail
e.note.load();
var f = e.note.load();
futures.add(f);
}
});
if (futures.length >= maxParallel) {
await Future.wait(futures);
futures = <Future>[];
}
}
}
// FIXME: This should not reconstruct the Notes or NotesFolders once constructed.