Files
binutils-gdb/gdb/process-stratum-target.c
Simon Marchi 71a2349005 gdb: optimize selection of resumed thread with pending event
Consider a case where many threads (thousands) keep hitting a breakpoint
whose condition evaluates to false.  random_pending_event_thread is
responsible for selecting a thread from an inferior among all that are
resumed with a pending wait status.  It is currently implemented by
walking the inferior's thread list twice: once to count the number of
candidates and once to select a random one.

Since we now maintain a per target list of resumed threads with pending
event, we can implement this more efficiently by walking that list and
selecting the first thread that matches the criteria
(random_pending_event_thread looks for an thread from a specific
inferior, and possibly a filter ptid).  It will be faster especially in
the common case where there isn't any resumed thread with pending
event.  Currently, we have to iterate the thread list to figure this
out.  With this patch, the list of resumed threads with pending event
will be empty, so it's quick to figure out.

The random selection is kept, but is moved to
process_stratum_target::random_resumed_with_pending_wait_status.  The
same technique is used: do a first pass to count the number of
candidates, and do a second pass to select a random one.  But given that
the list of resumed threads with pending wait statuses will generally be
short, or at least shorter than the full thread list, it should be
quicker.

Note that this isn't completely true, in case there are multiple
inferiors on the same target.  Imagine that inferior A has 10k resumed
threads with pending wait statuses, and random_pending_event_thread is
called with inferior B.  We'll need to go through the list that contains
inferior A's threads to realize that inferior B has no resumed threads
with pending wait status.  But I think that this is a corner /
pathological case.  And a possible fix for this situation would be to
make random_pending_event_thread work per-process-target, rather than
per-inferior.

Change-Id: I1b71d01beaa500a148b5b9797745103e13917325
2021-07-12 20:46:53 -04:00

208 lines
5.7 KiB
C

/* Abstract base class inherited by all process_stratum targets
Copyright (C) 2018-2021 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "process-stratum-target.h"
#include "inferior.h"
#include <algorithm>
process_stratum_target::~process_stratum_target ()
{
}
struct address_space *
process_stratum_target::thread_address_space (ptid_t ptid)
{
/* Fall-back to the "main" address space of the inferior. */
inferior *inf = find_inferior_ptid (this, ptid);
if (inf == NULL || inf->aspace == NULL)
internal_error (__FILE__, __LINE__,
_("Can't determine the current "
"address space of thread %s\n"),
target_pid_to_str (ptid).c_str ());
return inf->aspace;
}
struct gdbarch *
process_stratum_target::thread_architecture (ptid_t ptid)
{
inferior *inf = find_inferior_ptid (this, ptid);
gdb_assert (inf != NULL);
return inf->gdbarch;
}
bool
process_stratum_target::has_all_memory ()
{
/* If no inferior selected, then we can't read memory here. */
return inferior_ptid != null_ptid;
}
bool
process_stratum_target::has_memory ()
{
/* If no inferior selected, then we can't read memory here. */
return inferior_ptid != null_ptid;
}
bool
process_stratum_target::has_stack ()
{
/* If no inferior selected, there's no stack. */
return inferior_ptid != null_ptid;
}
bool
process_stratum_target::has_registers ()
{
/* Can't read registers from no inferior. */
return inferior_ptid != null_ptid;
}
bool
process_stratum_target::has_execution (inferior *inf)
{
/* If there's a process running already, we can't make it run
through hoops. */
return inf->pid != 0;
}
void
process_stratum_target::follow_exec (inferior *follow_inf, ptid_t ptid,
const char *execd_pathname)
{
inferior *orig_inf = current_inferior ();
if (orig_inf != follow_inf)
{
/* Execution continues in a new inferior, push the original inferior's
process target on the new inferior's target stack. The process target
may decide to unpush itself from the original inferior's target stack
after that, at its discretion. */
follow_inf->push_target (orig_inf->process_target ());
thread_info *t = add_thread (follow_inf->process_target (), ptid);
/* Leave the new inferior / thread as the current inferior / thread. */
switch_to_thread (t);
}
}
/* See process-stratum-target.h. */
void
process_stratum_target::maybe_add_resumed_with_pending_wait_status
(thread_info *thread)
{
gdb_assert (!thread->resumed_with_pending_wait_status_node.is_linked ());
if (thread->resumed () && thread->has_pending_waitstatus ())
{
infrun_debug_printf ("adding to resumed threads with event list: %s",
thread->ptid.to_string ().c_str ());
m_resumed_with_pending_wait_status.push_back (*thread);
}
}
/* See process-stratum-target.h. */
void
process_stratum_target::maybe_remove_resumed_with_pending_wait_status
(thread_info *thread)
{
if (thread->resumed () && thread->has_pending_waitstatus ())
{
infrun_debug_printf ("removing from resumed threads with event list: %s",
thread->ptid.to_string ().c_str ());
gdb_assert (thread->resumed_with_pending_wait_status_node.is_linked ());
auto it = m_resumed_with_pending_wait_status.iterator_to (*thread);
m_resumed_with_pending_wait_status.erase (it);
}
else
gdb_assert (!thread->resumed_with_pending_wait_status_node.is_linked ());
}
/* See process-stratum-target.h. */
thread_info *
process_stratum_target::random_resumed_with_pending_wait_status
(inferior *inf, ptid_t filter_ptid)
{
auto matches = [inf, filter_ptid] (const thread_info &thread)
{
return thread.inf == inf && thread.ptid.matches (filter_ptid);
};
/* First see how many matching events we have. */
const auto &l = m_resumed_with_pending_wait_status;
unsigned int count = std::count_if (l.begin (), l.end (), matches);
if (count == 0)
return nullptr;
/* Now randomly pick a thread out of those that match the criteria. */
int random_selector
= (int) ((count * (double) rand ()) / (RAND_MAX + 1.0));
if (count > 1)
infrun_debug_printf ("Found %u events, selecting #%d",
count, random_selector);
/* Select the Nth thread that matches. */
auto it = std::find_if (l.begin (), l.end (),
[&random_selector, &matches]
(const thread_info &thread)
{
if (!matches (thread))
return false;
return random_selector-- == 0;
});
gdb_assert (it != l.end ());
return &*it;
}
/* See process-stratum-target.h. */
std::set<process_stratum_target *>
all_non_exited_process_targets ()
{
/* Inferiors may share targets. To eliminate duplicates, use a set. */
std::set<process_stratum_target *> targets;
for (inferior *inf : all_non_exited_inferiors ())
targets.insert (inf->process_target ());
return targets;
}
/* See process-stratum-target.h. */
void
switch_to_target_no_thread (process_stratum_target *target)
{
for (inferior *inf : all_inferiors (target))
{
switch_to_inferior_no_thread (inf);
break;
}
}