mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-08-06 14:49:38 +08:00
74daa597e7
The new_objfile observer is currently used to indicate both when a new
objfile is added to program space (when passed non-nullptr) and when all
objfiles of a program space were just removed (when passed nullptr).
I think this is confusing (and Andrew apparently thinks so too [1]).
Add a new "all_objfiles_removed" observer to remove the second role from
"new_objfile".
Some existing users of new_objfile do nothing if the passed objfile is
nullptr. For them, we can simply drop the nullptr check. For others,
add a new all_objfiles_removed callback, and refactor things a bit to
keep the existing behavior as much as possible.
Some callbacks relied on current_program_space, and following
the refactoring now use either objfile->pspace or the pspace passed to
all_objfiles_removed. I think this should be relatively safe, and in
general a step in the right direction.
On the notify side, I found only one call site to change from
new_objfile to all_objfiles_removed, in clear_symtab_users. It is not
entirely clear to me that this is entirely correct. clear_symtab_users
appears to be called in spots that don't remove all objfiles
(functions finish_new_objfile, remove_symbol_file_command, reread_symbols,
do_module_cleanups). But I think that this patch at least makes the
current code clearer.
[1] a0a031bce0
Change-Id: Icb648f72862e056267f30f44dd439bd4ec766f13
Approved-By: Tom Tromey <tom@tromey.com>
102 lines
3.2 KiB
C
102 lines
3.2 KiB
C
/* GDB Notifications to Observers.
|
|
|
|
Copyright (C) 2003-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "observable.h"
|
|
#include "command.h"
|
|
#include "gdbcmd.h"
|
|
|
|
namespace gdb
|
|
{
|
|
|
|
namespace observers
|
|
{
|
|
|
|
bool observer_debug = false;
|
|
|
|
#define DEFINE_OBSERVABLE(name) decltype (name) name (# name)
|
|
|
|
DEFINE_OBSERVABLE (normal_stop);
|
|
DEFINE_OBSERVABLE (signal_received);
|
|
DEFINE_OBSERVABLE (target_changed);
|
|
DEFINE_OBSERVABLE (executable_changed);
|
|
DEFINE_OBSERVABLE (inferior_created);
|
|
DEFINE_OBSERVABLE (inferior_execd);
|
|
DEFINE_OBSERVABLE (inferior_forked);
|
|
DEFINE_OBSERVABLE (solib_loaded);
|
|
DEFINE_OBSERVABLE (solib_unloaded);
|
|
DEFINE_OBSERVABLE (new_objfile);
|
|
DEFINE_OBSERVABLE (all_objfiles_removed);
|
|
DEFINE_OBSERVABLE (free_objfile);
|
|
DEFINE_OBSERVABLE (new_thread);
|
|
DEFINE_OBSERVABLE (thread_exit);
|
|
DEFINE_OBSERVABLE (thread_stop_requested);
|
|
DEFINE_OBSERVABLE (target_resumed);
|
|
DEFINE_OBSERVABLE (about_to_proceed);
|
|
DEFINE_OBSERVABLE (breakpoint_created);
|
|
DEFINE_OBSERVABLE (breakpoint_deleted);
|
|
DEFINE_OBSERVABLE (breakpoint_modified);
|
|
DEFINE_OBSERVABLE (architecture_changed);
|
|
DEFINE_OBSERVABLE (thread_ptid_changed);
|
|
DEFINE_OBSERVABLE (inferior_added);
|
|
DEFINE_OBSERVABLE (inferior_appeared);
|
|
DEFINE_OBSERVABLE (inferior_pre_detach);
|
|
DEFINE_OBSERVABLE (inferior_exit);
|
|
DEFINE_OBSERVABLE (inferior_removed);
|
|
DEFINE_OBSERVABLE (inferior_cloned);
|
|
DEFINE_OBSERVABLE (memory_changed);
|
|
DEFINE_OBSERVABLE (before_prompt);
|
|
DEFINE_OBSERVABLE (gdb_datadir_changed);
|
|
DEFINE_OBSERVABLE (inferior_call_pre);
|
|
DEFINE_OBSERVABLE (inferior_call_post);
|
|
DEFINE_OBSERVABLE (register_changed);
|
|
DEFINE_OBSERVABLE (user_selected_context_changed);
|
|
DEFINE_OBSERVABLE (styling_changed);
|
|
DEFINE_OBSERVABLE (current_source_symtab_and_line_changed);
|
|
DEFINE_OBSERVABLE (gdb_exiting);
|
|
DEFINE_OBSERVABLE (connection_removed);
|
|
DEFINE_OBSERVABLE (target_pre_wait);
|
|
DEFINE_OBSERVABLE (target_post_wait);
|
|
DEFINE_OBSERVABLE (new_program_space);
|
|
DEFINE_OBSERVABLE (free_program_space);
|
|
|
|
} /* namespace observers */
|
|
} /* namespace gdb */
|
|
|
|
static void
|
|
show_observer_debug (struct ui_file *file, int from_tty,
|
|
struct cmd_list_element *c, const char *value)
|
|
{
|
|
gdb_printf (file, _("Observer debugging is %s.\n"), value);
|
|
}
|
|
|
|
void _initialize_observer ();
|
|
void
|
|
_initialize_observer ()
|
|
{
|
|
add_setshow_boolean_cmd ("observer", class_maintenance,
|
|
&gdb::observers::observer_debug, _("\
|
|
Set observer debugging."), _("\
|
|
Show observer debugging."), _("\
|
|
When non-zero, observer debugging is enabled."),
|
|
NULL,
|
|
show_observer_debug,
|
|
&setdebuglist, &showdebuglist);
|
|
}
|