Files
binutils-gdb/gdb/unittests/cli-utils-selftests.c
Pedro Alves 6206060d9b Delete parse_flags/parse_flags_qcs
Now that "thread/frame apply" have been converted to the gdb::option
framework, these functions are no longer used.

For a while, I thought about keeping the unit tests, by making a local
version of parse_flags_qcs in the unit tests file.  But all that would
really test that is used by GDB itself, is the validate_flags_qcs
function.  So in the end, I went through all the unit tests, and
converted any that wasn't already covered to gdb.base/options.exp
tests.  And those have all already been added in previous patches.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
	* cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
	* unittests/cli-utils-selftests.c (test_parse_flags)
	(test_parse_flags_qcs): Delete.
	(test_cli_utils): Don't call deleted functions.
2019-06-13 00:24:17 +01:00

119 lines
3.0 KiB
C

/* Unit tests for the cli-utils.c file.
Copyright (C) 2018-2019 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "cli/cli-utils.h"
#include "common/selftest.h"
namespace selftests {
namespace cli_utils {
static void
test_number_or_range_parser ()
{
/* Test parsing a simple integer. */
{
number_or_range_parser one ("1");
SELF_CHECK (!one.finished ());
SELF_CHECK (one.get_number () == 1);
SELF_CHECK (one.finished ());
SELF_CHECK (strcmp (one.cur_tok (), "") == 0);
}
/* Test parsing an integer followed by a non integer. */
{
number_or_range_parser one_after ("1 after");
SELF_CHECK (!one_after.finished ());
SELF_CHECK (one_after.get_number () == 1);
SELF_CHECK (one_after.finished ());
SELF_CHECK (strcmp (one_after.cur_tok (), "after") == 0);
}
/* Test parsing a range. */
{
number_or_range_parser one_three ("1-3");
for (int i = 1; i < 4; i++)
{
SELF_CHECK (!one_three.finished ());
SELF_CHECK (one_three.get_number () == i);
}
SELF_CHECK (one_three.finished ());
SELF_CHECK (strcmp (one_three.cur_tok (), "") == 0);
}
/* Test parsing a range followed by a non-integer. */
{
number_or_range_parser one_three_after ("1-3 after");
for (int i = 1; i < 4; i++)
{
SELF_CHECK (!one_three_after.finished ());
SELF_CHECK (one_three_after.get_number () == i);
}
SELF_CHECK (one_three_after.finished ());
SELF_CHECK (strcmp (one_three_after.cur_tok (), "after") == 0);
}
/* Test a negative integer gives an error. */
{
number_or_range_parser minus_one ("-1");
SELF_CHECK (!minus_one.finished ());
try
{
minus_one.get_number ();
SELF_CHECK (false);
}
catch (const gdb_exception_error &ex)
{
SELF_CHECK (ex.reason == RETURN_ERROR);
SELF_CHECK (ex.error == GENERIC_ERROR);
SELF_CHECK (strcmp (ex.what (), "negative value") == 0);
SELF_CHECK (strcmp (minus_one.cur_tok (), "-1") == 0);
}
}
/* Test that a - followed by not a number does not give an error. */
{
number_or_range_parser nan ("-whatever");
SELF_CHECK (nan.finished ());
SELF_CHECK (strcmp (nan.cur_tok (), "-whatever") == 0);
}
}
static void
test_cli_utils ()
{
selftests::cli_utils::test_number_or_range_parser ();
}
}
}
void
_initialize_cli_utils_selftests ()
{
selftests::register_test ("cli_utils",
selftests::cli_utils::test_cli_utils);
}